astefanutti/decktape
1
1
Fork 0
mirror of https://github.com/astefanutti/decktape.git synced 2024-12-02 06:35:51 +03:00
Code Issues Projects Releases Wiki Activity

RISE 5.x compatibility and timing improvements

Browse Source
This commit is contained in:
Antonin Stefanutti 2017-09-07 20:17:53 +02:00
parent 656704c9c6
commit 64a163a988
1 changed files with 5 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
plugins/rise.js
View File

@ -18,17 +18,15 @@ class RISE {
}
async configure() {
// Wait a while until the RISE extension has loaded
// It'd be better to rely on a deterministic condition though the Jupyter JS API
// isn't stable and documented yet...
await pause(2000);
// Wait until the RISE extension has loaded
await this.page.waitForSelector('#start_livereveal', { timeout: 30000 });
// Click on the 'Enter/Exit Live Reveal Slideshow' button in the notebook toolbar
await this.page.evaluate(_ => {
$('#start_livereveal').click();
$('#help_b, #exit_b').fadeToggle();
});
// Then wait a bit until Reveal.js gets configured by the RISE extension
await pause(2000);
// Then wait until Reveal.js gets configured by the RISE extension
await this.page.waitForFunction('typeof Reveal !== \'undefined\'', { timeout: 30000 });
// Finally override Reveal.js configuration
await this.page.evaluate(_ => Reveal.configure({
controls : false,
@ -49,12 +47,7 @@ class RISE {
}
hasNextSlide() {
// The way RISE re-arranges cell DOM elements to fit into
// the expected Reveal.js structure is not compatible with the
// isLastSlide API exposed by Reveal.js
// return !Reveal.isLastSlide();
return this.page.evaluate(_ =>
Reveal.getCurrentSlide().parentNode.nextElementSibling.nodeName.match(/section/i));
return this.page.evaluate(_ => !Reveal.isLastSlide());
}
nextSlide() {