28eca6a · bat · git.iko.soy

git.iko.soy/bat

Use assert!(..) instead of assert_eq!(true, ..)

This fixes all of these lint warnings: https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison They only appear in recent versions of clippy. Not on our MSRV.

commit28eca6a2be4fdce2a8863fbbdbfe0a6db1480c3b authorMartin Nordholts <enselic@gmail.com> dateMon 2 Aug 2021, 15:06 (5 years ago) parentb7fd552

1 file changed+6−6

compare with master

unifiedsplit

src/input.rs+6−6

src/input.rs+6−6

@@ -282,21 +282,21 @@ fn basic() {

282282

283283 let res = reader.read_line(&mut buffer);

284284 assert!(res.is_ok());

285− assert_eq!(true, res.unwrap());

285+ assert!(res.unwrap());

286286 assert_eq!(b"#!/bin/bash\n", &buffer[..]);

287287

288288 buffer.clear();

289289

290290 let res = reader.read_line(&mut buffer);

291291 assert!(res.is_ok());

292− assert_eq!(true, res.unwrap());

292+ assert!(res.unwrap());

293293 assert_eq!(b"echo hello", &buffer[..]);

294294

295295 buffer.clear();

296296

297297 let res = reader.read_line(&mut buffer);

298298 assert!(res.is_ok());

299− assert_eq!(false, res.unwrap());

299+ assert!(!res.unwrap());

300300 assert!(buffer.is_empty());

301301}

302302

@@ -311,20 +311,20 @@ fn utf16le() {

311311

312312 let res = reader.read_line(&mut buffer);

313313 assert!(res.is_ok());

314− assert_eq!(true, res.unwrap());

314+ assert!(res.unwrap());

315315 assert_eq!(b"\xFF\xFE\x73\x00\x0A\x00", &buffer[..]);

316316

317317 buffer.clear();

318318

319319 let res = reader.read_line(&mut buffer);

320320 assert!(res.is_ok());

321− assert_eq!(true, res.unwrap());

321+ assert!(res.unwrap());

322322 assert_eq!(b"\x64\x00", &buffer[..]);

323323

324324 buffer.clear();

325325

326326 let res = reader.read_line(&mut buffer);

327327 assert!(res.is_ok());

328− assert_eq!(false, res.unwrap());

328+ assert!(!res.unwrap());

329329 assert!(buffer.is_empty());

330330}