on master help sign in
Rename field name, new constructors
commit90e7d2fe335052e7bd83a48a8925934978dcc37b authorsharkdp <davidpeter@web.de> dateSat 11 Apr 2020, 19:17 (7 years ago) parent04fa84a
6 files changed+27−17
examples/cat.rs+1−1 examples/simple.rs+1−2 src/assets.rs+1−1 src/bin/bat/app.rs+3−1 src/bin/bat/main.rs+3−4 src/inputfile.rs+18−8
examples/cat.rs+1−1
@@ -26,7 +26,7 @@ fn main() {
2626 ]),
2727 files: files
2828 .iter()
29− .map(|file| InputFile::Ordinary(OrdinaryFile::new(file, None)))
29+ .map(|file| InputFile::Ordinary(OrdinaryFile::from_path(file)))
3030 .collect(),
3131 ..Default::default()
3232 };
examples/simple.rs+1−2
@@ -9,9 +9,8 @@ fn main() {
99 let path_to_this_file = OsStr::new(file!());
1010
1111 let config = Config {
12− files: vec![InputFile::Ordinary(OrdinaryFile::new(
12+ files: vec![InputFile::Ordinary(OrdinaryFile::from_path(
1313 path_to_this_file,
14− None,
1514 ))],
1615 colored_output: true,
1716 true_color: true,
src/assets.rs+1−1
@@ -267,7 +267,7 @@ mod tests {
267267 writeln!(temp_file, "{}", first_line).unwrap();
268268 }
269269
270− let input_file = InputFile::Ordinary(OrdinaryFile::new(OsStr::new(&file_path), None));
270+ let input_file = InputFile::Ordinary(OrdinaryFile::from_path(OsStr::new(&file_path)));
271271 let syntax = self.assets.get_syntax(
272272 None,
273273 input_file,
src/bin/bat/app.rs+3−1
@@ -265,7 +265,9 @@ impl App {
265265 if input.to_str().unwrap() == "-" {
266266 file_input.push(InputFile::StdIn(name));
267267 } else {
268− file_input.push(InputFile::Ordinary(OrdinaryFile::new(input, name)))
268+ file_input.push(InputFile::Ordinary(OrdinaryFile::from_path_with_name(
269+ input, name,
270+ )))
269271 }
270272 }
271273 None => {}
src/bin/bat/main.rs+3−4
@@ -167,10 +167,9 @@ fn run() -> Result<bool> {
167167 Ok(true)
168168 } else {
169169 let mut config = app.config()?;
170− config.files = vec![InputFile::Ordinary(OrdinaryFile::new(
171− OsStr::new("cache"),
172− None,
173− ))];
170+ config.files = vec![InputFile::Ordinary(OrdinaryFile::from_path(OsStr::new(
171+ "cache",
172+ )))];
174173
175174 run_controller(&config)
176175 }
src/inputfile.rs+18−8
@@ -54,20 +54,30 @@ impl<'a> InputFileReader<'a> {
5454
5555#[derive(Debug, Clone, Copy, PartialEq)]
5656pub struct OrdinaryFile<'a> {
57− filename: &'a OsStr,
57+ path: &'a OsStr,
5858 user_provided_name: Option<&'a OsStr>,
5959}
6060
6161impl<'a> OrdinaryFile<'a> {
62− pub fn new(filename: &'a OsStr, user_provided_name: Option<&'a OsStr>) -> OrdinaryFile<'a> {
62+ pub fn from_path(path: &'a OsStr) -> OrdinaryFile<'a> {
6363 OrdinaryFile {
64− filename: filename,
65− user_provided_name: user_provided_name,
64+ path,
65+ user_provided_name: None,
66+ }
67+ }
68+
69+ pub fn from_path_with_name(
70+ path: &'a OsStr,
71+ user_provided_name: Option<&'a OsStr>,
72+ ) -> OrdinaryFile<'a> {
73+ OrdinaryFile {
74+ path,
75+ user_provided_name,
6676 }
6777 }
6878
6979 pub fn filename(&self) -> &'a OsStr {
70− self.user_provided_name.unwrap_or_else(|| self.filename)
80+ self.user_provided_name.unwrap_or_else(|| self.path)
7181 }
7282}
7383
@@ -83,12 +93,12 @@ impl<'a> InputFile<'a> {
8393 match self {
8494 InputFile::StdIn(_) => Ok(InputFileReader::new(stdin.lock())),
8595 InputFile::Ordinary(ofile) => {
86− let file = File::open(ofile.filename)
87− .map_err(|e| format!("'{}': {}", ofile.filename.to_string_lossy(), e))?;
96+ let file = File::open(ofile.path)
97+ .map_err(|e| format!("'{}': {}", ofile.path.to_string_lossy(), e))?;
8898
8999 if file.metadata()?.is_dir() {
90100 return Err(
91− format!("'{}' is a directory.", ofile.filename.to_string_lossy()).into(),
101+ format!("'{}' is a directory.", ofile.path.to_string_lossy()).into(),
92102 );
93103 }
94104