on master help sign in
7 files changed+192−9
since splitsnapshots
unifiedsplit
Data/Binary/Bits/Get.hs+23 Data/Binary/Bits/Internal.hs+21 Data/Binary/Bits/Put.hs+60−2 flake.lock+59 flake.nix+24 stack.yaml+1−2 stack.yaml.lock+4−5
Data/Binary/Bits/Get.hs+23
@@ -60,6 +60,7 @@ module Data.Binary.Bits.Get
6060
6161 -- ** Get bytes
6262 , getBool
63+ , getBool#
6364 , getWord8
6465 , getWord16
6566 , getWord32
@@ -114,6 +115,8 @@ import Control.Applicative
114115import Control.Monad (when,foldM_)
115116
116117import Prelude as P
118+import GHC.Word
119+import GHC.Base (uncheckedShiftLWord8#, wordToWord8#, Int (..), andWord8#, Word8#, (-#), Int#, xorI#, eqWord8#, TYPE)
117120
118121-- $bitget
119122-- Parse bits using a monad.
@@ -182,6 +185,18 @@ readBool (S bs o bo) = case bo of
182185 LL -> testBit (unsafeHead bs) o
183186 LB -> testBit (unsafeHead bs) o
184187
188+-- | Read a single bit
189+readBool# :: S -> Int
190+readBool# (S bs (I# o) bo) = case bo of
191+ BB -> testBit# (7# -# o)
192+ BL -> testBit# (7# -# o)
193+ LL -> testBit# o
194+ LB -> testBit# o
195+ where
196+ !(W8# w) = unsafeHead bs
197+ testBit# n = I# (((w `andWord8#` (wordToWord8# 1## `uncheckedShiftLWord8#` n)) `eqWord8#` wordToWord8# 0##) `xorI#` 1#)
198+
199+
185200-- | Extract a range of bits from (ws :: ByteString)
186201--
187202-- Constraint: 8 * (length ws -1 ) < o+n <= 8 * length ws
@@ -363,6 +378,10 @@ isEmpty = B $ \ (S bs o bo) -> if B.null bs
363378getBool :: BitGet Bool
364379getBool = block bool
365380
381+-- | Get 1 bit as a 'Bool'.
382+getBool# :: BitGet Int
383+getBool# = block bool#
384+
366385-- | Get @n@ bits as a 'Word8'. @n@ must be within @[0..8]@.
367386getWord8 :: Int -> BitGet Word8
368387getWord8 n = block (word8 n)
@@ -438,6 +457,10 @@ block (Block i p) = do
438457bool :: Block Bool
439458bool = Block 1 readBool
440459
460+-- | Read a 1 bit 'Bool'.
461+bool# :: Block Int
462+bool# = Block 1 readBool#
463+
441464-- | Read @n@ bits as a 'Word8'. @n@ must be within @[0..8]@.
442465word8 :: Int -> Block Word8
443466word8 n = Block n (readWordChecked 8 n)
Data/Binary/Bits/Internal.hs+21
@@ -12,10 +12,13 @@
1212
1313module Data.Binary.Bits.Internal
1414 ( make_mask
15+ , make_mask#
1516 , mask
17+ , mask#
1618 , bit_offset
1719 , byte_offset
1820 , reverseBits
21+ , reverseBits#
1922 , FastBits(..)
2023 )
2124where
@@ -38,11 +41,18 @@ make_mask n = (1 `shiftL` fromIntegral n) - 1
3841{-# SPECIALIZE make_mask :: Int -> Word32 #-}
3942{-# SPECIALIZE make_mask :: Int -> Word64 #-}
4043
44+make_mask# :: Int# -> Word#
45+make_mask# n = (1## `shiftL#` n) `minusWord#` 1##
46+
4147-- | Keep only the n least-significant bits of the given value
4248mask :: (Bits a, Num a) => Int -> a -> a
4349mask n v = v .&. make_mask n
4450{-# INLINE mask #-}
4551
52+-- | Keep only the n least-significant bits of the given value
53+mask# :: Int# -> Word# -> Word#
54+mask# n v = v `and#` make_mask# n
55+
4656-- | Compute bit offset (equivalent to x `mod` 8 but faster)
4757bit_offset :: Int -> Int
4858bit_offset n = make_mask 3 .&. n
@@ -65,6 +75,17 @@ reverseBits n value = rec value n 0
6575 rec 0 i r = r `fastShiftL` i
6676 rec v i r = rec (v `fastShiftR` 1) (i-1) ((r `fastShiftL` 1) .|. (v .&. 0x1))
6777
78+reverseBits# :: Int# -> Word# -> Word#
79+reverseBits# n value = rec value n 0##
80+ where
81+ -- rec v i r, where
82+ -- v is orginal value shifted
83+ -- i is the remaining number of bits
84+ -- r is current value
85+ rec 0## 0# r = r
86+ rec 0## i r = r `shiftL#` i
87+ rec v i r = rec (v `shiftRL#` 1#) (i -# 1#) ((r `shiftL#` 1#) `or#` (v `and#` 0x1##))
88+
6889
6990---------------------------------------------------------------------
7091-- Unchecked shifts, from the "binary" package
Data/Binary/Bits/Put.hs+60−2
@@ -1,3 +1,5 @@
1+{-# LANGUAGE MagicHash #-}
2+
13-----------------------------------------------------------------------------
24-- |
35-- Module : Data.Binary.Bits.Put
@@ -20,8 +22,10 @@ module Data.Binary.Bits.Put
2022 -- * Data types
2123 -- ** Bool
2224 , putBool
25+ , putBool#
2326
2427 -- ** Words
28+ , putWord#
2529 , putWord8
2630 , putWord16
2731 , putWord32
@@ -46,11 +50,11 @@ import Data.Binary.Bits.Alignment
4650import Data.ByteString as BS
4751import Data.ByteString.Unsafe as BS
4852
49−import Control.Applicative
5053import Control.Monad (when)
5154import Data.Bits
52−import Data.Monoid
5355import Data.Word
56+import GHC.Base (Word#, shiftRL#, Int (..), Int#, (-#), (<#), isTrue#, (+#), shiftL#, wordToWord8#, orWord8#)
57+import GHC.Word (Word8(..))
5458
5559data BitPut a = BitPut { run :: (S -> PairS a) }
5660
@@ -62,11 +66,18 @@ data S = S !Builder !Word8 !Int !BitOrder
6266putBool :: Bool -> BitPut ()
6367putBool b = putWord8 1 (if b then 0xff else 0x00)
6468
69+-- | Put a 1 bit 'Bool'.
70+putBool# :: Word# -> BitPut ()
71+putBool# b = putWord# 1# b
72+
6573
6674-- | Generic putWord
6775putWord :: (Num a, FastBits a, Integral a) => Int -> a -> BitPut ()
6876putWord n w = BitPut $ \s -> PairS () (putWordS n w s)
6977
78+putWord# :: Int# -> Word# -> BitPut ()
79+putWord# n w = BitPut $ \s -> PairS () (putWordS# n w s)
80+
7081putWordS :: (Num a, FastBits a, Integral a) => Int -> a -> S -> S
7182putWordS n w s@(S builder b o bo) = s'
7283 where
@@ -110,6 +121,53 @@ putWordS n w s@(S builder b o bo) = s'
110121 | o2 == 8 = S (b2 `mappend` B.singleton w2) 0 0 bo2
111122 | otherwise = s2
112123
124+putWordS# :: Int# -> Word# -> S -> S
125+putWordS# n w s@(S builder (W8# b) (I# o) bo) = s'
126+ where
127+ min# :: Int# -> Int# -> Int#
128+ min# x y | isTrue# (x <# y) = x
129+ min# _ y = y
130+
131+ -- number of bits that will be stored in the current byte
132+ cn = min# (8# -# o) n
133+
134+ -- new state
135+ s' = case n of
136+ 0# -> s
137+ _ -> putWordS# (n -# cn) w' (flush (S builder (W8# b') (I# (o +# cn)) bo))
138+
139+ -- new current byte
140+ b' = wordToWord8# (shl (selectBits w)) `orWord8#` b
141+
142+ -- Word containing the remaining (n-cn) bits to store in its LSB
143+ w' = case bo of
144+ BB -> w
145+ BL -> w `shiftRL#` cn
146+ LL -> w `shiftRL#` cn
147+ LB -> w
148+
149+ -- Select bits to store in the current byte.
150+ -- Put them in the correct order and return them in the least-significant
151+ -- bits of the returned value
152+ selectBits :: Word# -> Word#
153+ selectBits x = case bo of
154+ BB -> mask# cn (x `shiftRL#` (n -# cn))
155+ LB -> reverseBits# cn (mask# cn (x `shiftRL#` (n -# cn)))
156+ LL -> mask# cn x
157+ BL -> reverseBits# cn (mask# cn x)
158+
159+ -- shift left at the correct position
160+ shl :: Word# -> Word#
161+ shl x = case bo of
162+ BB -> x `shiftL#` (8# -# o -# cn)
163+ BL -> x `shiftL#` (8# -# o -# cn)
164+ LL -> x `shiftL#` o
165+ LB -> x `shiftL#` o
166+
167+ flush s2@(S b2 w2 o2 bo2)
168+ | o2 == 8 = S (b2 `mappend` B.singleton w2) 0 0 bo2
169+ | otherwise = s2
170+
113171
114172-- | Put the @n@ lower bits of a 'Word8'.
115173putWord8 :: Int -> Word8 -> BitPut ()
flake.locknew file+59
@@ -0,0 +1,59 @@
1+{
2+ "nodes": {
3+ "flake-utils": {
4+ "inputs": {
5+ "systems": "systems"
6+ },
7+ "locked": {
8+ "lastModified": 1731533236,
9+ "narHash": "sha256-l0KFg5HjrsfsO/JpG+r7fRrqm12kzFHyUHqHCVpMMbI=",
10+ "owner": "numtide",
11+ "repo": "flake-utils",
12+ "rev": "11707dc2f618dd54ca8739b309ec4fc024de578b",
13+ "type": "github"
14+ },
15+ "original": {
16+ "id": "flake-utils",
17+ "type": "indirect"
18+ }
19+ },
20+ "nixpkgs": {
21+ "locked": {
22+ "lastModified": 1737469691,
23+ "narHash": "sha256-nmKOgAU48S41dTPIXAq0AHZSehWUn6ZPrUKijHAMmIk=",
24+ "owner": "NixOS",
25+ "repo": "nixpkgs",
26+ "rev": "9e4d5190a9482a1fb9d18adf0bdb83c6e506eaab",
27+ "type": "github"
28+ },
29+ "original": {
30+ "id": "nixpkgs",
31+ "ref": "nixos-unstable",
32+ "type": "indirect"
33+ }
34+ },
35+ "root": {
36+ "inputs": {
37+ "flake-utils": "flake-utils",
38+ "nixpkgs": "nixpkgs"
39+ }
40+ },
41+ "systems": {
42+ "locked": {
43+ "lastModified": 1681028828,
44+ "narHash": "sha256-Vy1rq5AaRuLzOxct8nz4T6wlgyUR7zLU309k9mBC768=",
45+ "owner": "nix-systems",
46+ "repo": "default",
47+ "rev": "da67096a3b9bf56a91d16901293e51ba5b49a27e",
48+ "type": "github"
49+ },
50+ "original": {
51+ "owner": "nix-systems",
52+ "repo": "default",
53+ "type": "github"
54+ }
55+ }
56+ },
57+ "root": "root",
58+ "version": 7
59+}
flake.nixnew file+24
@@ -0,0 +1,24 @@
1+{
2+ inputs = {
3+ nixpkgs.url = "nixpkgs/nixos-unstable";
4+ flake-utils.url = "flake-utils";
5+ };
6+
7+ outputs = { self, flake-utils, nixpkgs }:
8+ let
9+ supportedSystems =
10+ [ "x86_64-linux" "x86_64-darwin" "aarch64-darwin" "aarch64-linux" ];
11+ compilerVersion = "966";
12+ in flake-utils.lib.eachSystem supportedSystems (system:
13+ let pkgs = import nixpkgs { inherit system; };
14+ in {
15+ devShells.default = pkgs.mkShell {
16+ buildInputs = with pkgs; [
17+ haskell.compiler."ghc${compilerVersion}"
18+ (pkgs.haskell-language-server.override {
19+ supportedGhcVersions = [ compilerVersion ];
20+ })
21+ ];
22+ };
23+ });
24+}
stack.yaml+1−2
@@ -17,8 +17,7 @@
1717#
1818# resolver: ./custom-snapshot.yaml
1919# resolver: https://example.com/snapshots/2018-01-01.yaml
20−resolver:
21− url: https://raw.githubusercontent.com/commercialhaskell/stackage-snapshots/master/lts/21/6.yaml
20+resolver: lts-22.43
2221
2322# User packages to be built.
2423# Various formats can be used as shown in the example below.
stack.yaml.lock+4−5
@@ -6,8 +6,7 @@
66packages: []
77snapshots:
88- completed:
9− sha256: 2e7d4a730d8eb5373b2d383fac84efcf7c81e3b7a5fce71b4c2e19a1768f25a6
10− size: 640239
11− url: https://raw.githubusercontent.com/commercialhaskell/stackage-snapshots/master/lts/21/6.yaml
12− original:
13− url: https://raw.githubusercontent.com/commercialhaskell/stackage-snapshots/master/lts/21/6.yaml
9+ sha256: 08bd13ce621b41a8f5e51456b38d5b46d7783ce114a50ab604d6bbab0d002146
10+ size: 720271
11+ url: https://raw.githubusercontent.com/commercialhaskell/stackage-snapshots/master/lts/22/43.yaml
12+ original: lts-22.43