on master help sign in
fix: revert stub env variable / README changes
commit12e03e4e33f51f8ced66e2a1d6e1325279a13d57 authorMatt Condon (shrugs) <mattgcondon@gmail.com> dateMon 17 Jun 2019, 16:05 (7 years ago) parente00f1f4
3 files changed+14−16
.env.development−1 README.md+13−14 src/bridge/Bridge.js+1−1
.env.development−1
@@ -2,4 +2,3 @@ REACT_APP_DEV_MNEMONIC='benefit crew supreme gesture quantum web media hazard th
22REACT_APP_DEV_GALAXY_TICKET='~wacfus-dabpex-danted-mosfep-pasrud-lavmer-nodtex-taslus-pactyp-milpub-pildeg-fornev-ralmed-dinfeb-fopbyr-sanbet-sovmyl-dozsut-mogsyx-mapwyc-sorrup-ricnec-marnys-lignex'
33REACT_APP_ROPSTEN_KEY='b7d2af9f01534031ba773374f766ef65'
44REACT_APP_HD_PATH="m/44'/60'/0'/0/0"
5−REACT_APP_STUB_LOCAL='false'
README.md+13−14
@@ -52,13 +52,14 @@ To validate your downloaded file's integrity, compare the lines in checksum.txt
5252
5353### Install / Build
5454
55−Clone the repo, and use a simple `npm install`. You can then use a `npm run build` to create an optimised static build (serve it with e.g. [serve][serv]).
55+Clone the repo, and use a simple `npm install`. You can then use a `npm run
56+build` to create an optimised static build (serve it with e.g. [serve][serv]).
5657
5758### General notes
5859
59−For development, use `npm run pilot` to get going after a `npm install`. This
60+For development, use `npm run pilot` to get going after a `npm install`. This
6061will boot up a Ganache node in the background, deploy the Azimuth contracts to
61−it, and fire up a local webserver. Bridge will be served on `localhost:3000`.
62+it, and fire up a local webserver. Bridge will be served on `localhost:3000`.
6263
6364Note that one of our dependencies itself depends on a library called
6465`handle-thing` which breaks under the Ledger support requirements (see below)
@@ -76,7 +77,7 @@ before running `npm run pilot`.
7677### Useful accounts
7778
7879The ecliptic owner is the only account that's able to create galaxies, so
79−it's a good place to get started. On the testnet, it's the address:
80+it's a good place to get started. On the testnet, it's the address:
8081
8182```
82830x6DEfFb0caFDB11D175F123F6891AA64F01c24F7d
@@ -113,15 +114,12 @@ You can also tweak a couple of things to change your development state
113114somewhat (say, for example, you want to start on the points list screen, instead
114115of having to re-authenticate whenever you make a change or refresh the page):
115116
116−- The `.env.development` file contains environment variables that you can
117− provide to the application when it's running in development. You can access
117+* The `.env.development` file contains environment variables that you can
118+ provide to the application when it's running in development. You can access
118119 them via `process.env.REACT_APP_<whatever>`.
119120
120−- Make `REACT_APP_STUB_LOCAL='true'` to enabled stubbing of some methods
121− in a local development environment.
122−
123−- The top of the Bridge component in `src/Bridge.js`
124− can be tweaked for setting your initial state. You can provide a specific
121+* The `componentDidMount` method of the Bridge component in `src/Bridge.js`
122+ can be tweaked for setting your initial state. You can provide a specific
125123 wallet, network type, and so on.
126124
127125### HTTPS
@@ -138,14 +136,15 @@ websocket. Do this by going to `about:config` and setting the
138136`network.websocket.allowInsecureFromHTTPS` flag to `true`.
139137
140138Additionally you need to run with the `HTTPS` environment variable set to
141−`true`. Note that `npm run pilot` will handle this automatically.
139+`true`. Note that `npm run pilot` will handle this automatically.
142140
143141### Releases
144142
145−To generate a release `bridge-$VERSION.zip` file, use a simple `npm run release`.
143+To generate a release `bridge-$VERSION.zip` file, use a simple `npm run
144+release`.
146145
147146This will pack the build directory together with the README, `bridge-https.py`
148−script, and also generate a set of checksums for the build directory. You can
147+script, and also generate a set of checksums for the build directory. You can
149148verify the checksums on e.g. OS X via `shasum -c checksums.txt`.
150149
151150[rele]: https://github.com/urbit/bridge/releases/latest
src/bridge/Bridge.js+1−1
@@ -26,7 +26,7 @@ const kInitialNetworkType = isDevelopment
2626 : NETWORK_TYPES.MAINNET;
2727
2828// NB(shrugs): modify these variables to change the default local state.
29−const shouldStubLocal = process.env.REACT_APP_STUB_LOCAL === 'true';
29+const shouldStubLocal = false;
3030const kIsStubbed = isDevelopment && shouldStubLocal;
3131const kInitialRoutes = kIsStubbed
3232 ? [