git.iko.soy/bridge
on master help sign in
Pull dumb constants out of function bodies
1a7e04eFang
src/views/Login.js+12−12
compare with master
unifiedsplit
@@ -24,6 +24,18 @@ const TABS = {
24 ADVANCED: Symbol('ADVANCED'),
24 ADVANCED: Symbol('ADVANCED'),
25};
25};
26
26
27+const tabViews = {
28+ [TABS.TICKET]: Ticket,
29+ [TABS.MNEMONIC]: Mnemonic,
30+ [TABS.ADVANCED]: Advanced,
31+};
32+
33+const tabOptions = [
34+ { title: 'Ticket', value: TABS.TICKET },
35+ { title: 'Mnemonic', value: TABS.MNEMONIC },
36+ { title: 'Advanced', value: TABS.ADVANCED },
37+];
38+
27export default function Login() {
39export default function Login() {
28 // globals
40 // globals
29 const history = useHistory();
41 const history = useHistory();
@@ -79,18 +91,6 @@ export default function Login() {
79 }
91 }
80 };
92 };
81
93
82− const tabViews = {
83− [TABS.TICKET]: Ticket,
84− [TABS.MNEMONIC]: Mnemonic,
85− [TABS.ADVANCED]: Advanced,
86− };
87−
88− const tabOptions = [
89− { title: 'Ticket', value: TABS.TICKET },
90− { title: 'Mnemonic', value: TABS.MNEMONIC },
91− { title: 'Advanced', value: TABS.ADVANCED },
92− ];
93−
94 return (
94 return (
95 <View>
95 <View>
96 <H1>Login</H1>
96 <H1>Login</H1>
src/views/Login/Ledger.js+6−5
@@ -14,6 +14,12 @@ import { InnerLabel, InnerLabelDropdown } from 'components/old/Base';
14import { LEDGER_LIVE_PATH, LEDGER_LEGACY_PATH } from 'lib/ledger';
14import { LEDGER_LIVE_PATH, LEDGER_LEGACY_PATH } from 'lib/ledger';
15import { useWallet } from 'store/wallet';
15import { useWallet } from 'store/wallet';
16
16
17+const pathOptions = [
18+ { title: 'Ledger Live', value: LEDGER_LIVE_PATH },
19+ { title: 'Ledger Legacy', value: LEDGER_LEGACY_PATH },
20+ { title: 'Custom path', value: 'custom' },
21+];
22+
17const chopHdPrefix = str => (str.slice(0, 2) === 'm/' ? str.slice(2) : str);
23const chopHdPrefix = str => (str.slice(0, 2) === 'm/' ? str.slice(2) : str);
18
24
19const addHdPrefix = str => (str.slice(0, 2) === 'm/' ? str : 'm/' + str);
25const addHdPrefix = str => (str.slice(0, 2) === 'm/' ? str : 'm/' + str);
@@ -61,11 +67,6 @@ export default function Ledger({ loginCompleted }) {
61 );
67 );
62 };
68 };
63
69
64− const pathOptions = [
65− { title: 'Ledger Live', value: LEDGER_LIVE_PATH },
66− { title: 'Ledger Legacy', value: LEDGER_LEGACY_PATH },
67− { title: 'Custom path', value: 'custom' },
68− ];
69 const basePathTitle = pathOptions.find(o => o.value === basePath).title;
70 const basePathTitle = pathOptions.find(o => o.value === basePath).title;
70
71
71 const accountOptions = times(20, i => ({
72 const accountOptions = times(20, i => ({