on master help sign in
fix: correctly re-execute onValues after validation resumes
686f74eMatt Condon (shrugs)
src/components/InlineEthereumTransaction.js+1−1
@@ -140,7 +140,7 @@ export default function InlineEthereumTransaction({
140 return (
140 return (
141 <Grid className={cn(className, 'mt1')}>
141 <Grid className={cn(className, 'mt1')}>
142 <BridgeForm validate={validate} onValues={onValues}>
142 <BridgeForm validate={validate} onValues={onValues}>
143− {({ handleSubmit }) => (
143+ {() => (
144 <>
144 <>
145 {renderPrimarySection()}
145 {renderPrimarySection()}
146
146
src/form/ValuesHandler.js+3−2
@@ -6,12 +6,13 @@ import { useForm } from 'react-final-form';
6 */
6 */
7export default function ValuesHandler({ valid, validating, values, onValues }) {
7export default function ValuesHandler({ valid, validating, values, onValues }) {
8 const form = useForm();
8 const form = useForm();
9+ const validationPaused = form.isValidationPaused();
9
10
10 useEffect(() => {
11 useEffect(() => {
11− if (!validating && !form.isValidationPaused()) {
12+ if (!validating && !validationPaused) {
12 onValues && onValues({ valid, values, form });
13 onValues && onValues({ valid, values, form });
13 }
14 }
14− }, [form, onValues, valid, validating, values]);
15+ }, [form, onValues, valid, validating, validationPaused, values]);
15
16
16 return null;
17 return null;
17}
18}
src/views/Admin/AdminNetworkingKeys.js+1−1
@@ -332,7 +332,7 @@ export default function AdminNetworkingKeys() {
332 validate={validate}
332 validate={validate}
333 onValues={onValues}
333 onValues={onValues}
334 initialValues={initialValues}>
334 initialValues={initialValues}>
335− {({ handleSubmit }) => (
335+ {() => (
336 <>
336 <>
337 <Grid.Item
337 <Grid.Item
338 full
338 full