@@ -63,6 +63,7 @@ const signTransaction = async config => {
6363 gasLimit,
6464 } = config;
6565
66+ //TODO require these in txn object
6667 nonce = toHex(nonce);
6768 chainId = toHex(chainId);
6869 gasPrice = toHex(toWei(gasPrice, 'gwei'));
@@ -117,6 +118,9 @@ const signTransaction = async config => {
117118
118119 const stx = new Tx(utx);
119120
121+ //TODO should try-catch and display error message to user,
122+ // ie ledger's "pls enable contract data"
123+ // needs to maybe happen at call-site though
120124 if (walletType === WALLET_TYPES.LEDGER) {
121125 await ledgerSignTransaction(stx, walletHdPath);
122126 } else if (walletType === WALLET_TYPES.TREZOR) {
@@ -166,7 +170,7 @@ const sendSignedTransaction = (web3, stx, doubtNonceError) => {
166170const waitForTransactionConfirm = (web3, txHash) => {
167171 return retry(async (bail, n) => {
168172 const receipt = await web3.eth.getTransactionReceipt(txHash);
169− let confirmed = receipt !== null;
173+ const confirmed = receipt !== null;
170174 if (confirmed) return receipt.status === true;
171175 else throw new Error('retrying');
172176 }, RETRY_OPTIONS);