938072c · bridge · git.iko.soy

git.iko.soy/bridge

Merge pull request #189 from urbit/indigo-admin-helper

indigo-admin helper

commit938072c9f7dda2a6b2c3442e69296ef2f4c7249e authorFang <Fang-@users.noreply.github.com> dateFri 12 Jul 2019, 19:04 (7 years ago) parentc9deecb 1bacc14

3 files changed+69−39

compare with master

unifiedsplit

src/lib/usePermissionsForPoint.js+2 src/views/Admin/AdminEditPermissions.js+31−29 src/views/Point.js+36−10

src/lib/usePermissionsForPoint.js+2

@@ -30,6 +30,7 @@ export default function usePermissionsForPoint(address, point) {

3030 const isGalaxy = pointSize === azimuth.PointSize.Galaxy;

3131

3232 const isOwner = eqAddr(address, details.owner);

33+ const isActiveOwner = isOwner && details.active;

3334 const isTransferProxy = eqAddr(address, details.transferProxy);

3435 const isManagementProxy = eqAddr(address, details.managementProxy);

3536 const isSpawnProxy = eqAddr(address, details.spawnProxy);

@@ -43,6 +44,7 @@ export default function usePermissionsForPoint(address, point) {

4344

4445 return {

4546 isOwner,

47+ isActiveOwner,

4648 isTransferProxy,

4749 isManagementProxy,

4850 canManage,

src/views/Admin/AdminEditPermissions.js+31−29

@@ -2,6 +2,7 @@ import React, { useState, useCallback } from 'react';

22import { Just, Nothing } from 'folktale/maybe';

33import * as need from 'lib/need';

44import { Grid } from 'indigo-react';

5+import { azimuth } from 'azimuth-js';

67import { ForwardButton } from 'components/Buttons';

78import { matchBlinky, matchBlinkyDate } from 'components/Blinky';

@@ -19,6 +20,7 @@ import { PROXY_TYPE, proxyTypeToHuman } from 'lib/proxy';

1920import { useLocalRouter } from 'lib/LocalRouter';

2021import { formatDots } from 'lib/dateFormat';

2122import capitalize from 'lib/capitalize';

23+import { eqAddr } from 'lib/wallet';

2224

2325//TODO consolidate with azimuth-js' getActivationBlock

2426const getRekeyDate = async (web3, contracts, point) => {

@@ -43,24 +45,25 @@ export default function AdminEditPermissions() {

4345 const { pointCursor } = usePointCursor();

4446 const { getDetails } = usePointCache();

4547

48+ const _web3 = need.web3(web3);

49+ const _contracts = need.contracts(contracts);

50+

4651 const [rekeyDate, setRekeyDate] = useState(Nothing());

4752

4853 const point = need.point(pointCursor);

54+ const pointSize = azimuth.getPointSize(point);

55+ const isParent = pointSize !== azimuth.PointSize.Planet;

56+ const isSenate = pointSize === azimuth.PointSize.Galaxy;

4957 const userAddress = need.wallet(wallet).address;

5058

5159 const details = need.details(getDetails(point));

52− const { canManage, canTransfer, canSpawn, canVote } = usePermissionsForPoint(

53− userAddress,

54− point

55− );

60+ const { canManage, isOwner } = usePermissionsForPoint(userAddress, point);

5661

5762 useLifecycle(() => {

58− getRekeyDate(need.web3(web3), need.contracts(contracts), point).then(

59− res => {

60− if (res === null) setRekeyDate(Just(new Date()));

61− else setRekeyDate(Just(res));

62− }

63− );

63+ getRekeyDate(_web3, _contracts, point).then(res => {

64+ if (res === null) setRekeyDate(Just(new Date()));

65+ else setRekeyDate(Just(res));

66+ });

6467 });

6568

6669 const goToProxy = useCallback(

@@ -71,8 +74,10 @@ export default function AdminEditPermissions() {

7174 const goSetKeys = useCallback(() => push(names.SET_KEYS), [push, names]);

7275

7376 const proxyAction = (proxyType, address, enabled) => {

74− if (address === ETH_ZERO_ADDR) {

75− address = 'Not yet set';

77+ if (eqAddr(address, ETH_ZERO_ADDR)) {

78+ address = 'Not set';

79+ } else if (eqAddr(address, _contracts.delegatedSending.address)) {

80+ address = address + ' (invites contract)';

7681 }

7782

7883 const detail = enabled

@@ -82,14 +87,17 @@ export default function AdminEditPermissions() {

8287 )} proxy.`;

8388

8489 return (

85− <Grid.Item full>

86− <ForwardButton

87− disabled={!enabled}

88− onClick={() => goToProxy(proxyType)}

89− detail={detail}>

90− {capitalize(proxyTypeToHuman(proxyType))} Proxy Address

91− </ForwardButton>

92− </Grid.Item>

90+ <>

91+ <Grid.Item full>

92+ <ForwardButton

93+ disabled={!enabled}

94+ onClick={() => goToProxy(proxyType)}

95+ detail={detail}>

96+ {capitalize(proxyTypeToHuman(proxyType))} Proxy Address

97+ </ForwardButton>

98+ </Grid.Item>

99+ <Grid.Divider />

100+ </>

93101 );

94102 };

95103

@@ -114,17 +122,11 @@ export default function AdminEditPermissions() {

114122 </Grid.Item>

115123 <Grid.Divider />

116124

117− {proxyAction(PROXY_TYPE.MANAGEMENT, details.managementProxy, canManage)}

118− <Grid.Divider />

125+ {proxyAction(PROXY_TYPE.MANAGEMENT, details.managementProxy, isOwner)}

119126

120− {proxyAction(PROXY_TYPE.SPAWN, details.spawnProxy, canSpawn)}

121− <Grid.Divider />

127+ {isParent && proxyAction(PROXY_TYPE.SPAWN, details.spawnProxy, isOwner)}

122128

123− {proxyAction(PROXY_TYPE.TRANSFER, details.transferProxy, canTransfer)}

124− <Grid.Divider />

125−

126− {proxyAction(PROXY_TYPE.VOTING, details.votingProxy, canVote)}

127− <Grid.Divider />

129+ {isSenate && proxyAction(PROXY_TYPE.VOTING, details.votingProxy, isOwner)}

128130

129131 <Grid.Item

130132 full

src/views/Point.js+36−10

@@ -1,7 +1,8 @@

1−import React, { useCallback } from 'react';

1+import React, { useCallback, useMemo } from 'react';

22import { Just } from 'folktale/maybe';

33import * as need from 'lib/need';

44import { Grid } from 'indigo-react';

5+import { azimuth } from 'azimuth-js';

67import { usePointCursor } from 'store/pointCursor';

78import { useHistory } from 'store/history';

@@ -20,14 +21,17 @@ import Actions from './Point/Actions';

2021import { useWallet } from 'store/wallet';

2122import usePermissionsForPoint from 'lib/usePermissionsForPoint';

2223

24+const isPlanet = point =>

25+ azimuth.getPointSize(point) === azimuth.PointSize.Planet;

26+

2327export default function Point() {

24− const history = useHistory();

28+ const { push, names } = useHistory();

2529 const { pointCursor } = usePointCursor();

2630 const { wallet } = useWallet();

2731

2832 const point = need.point(pointCursor);

2933

30− const { canManage } = usePermissionsForPoint(

34+ const { isActiveOwner, canManage } = usePermissionsForPoint(

3135 // using empty string should be ok here

3236 wallet.matchWith({

3337 Nothing: () => '',

@@ -38,16 +42,40 @@ export default function Point() {

3842

3943 // fetch the invites for the current cursor

4044 const { availableInvites } = useInvites(point);

41− const availableInvitesText = matchBlinky(availableInvites);

4245

4346 const showActions = Just.hasInstance(wallet);

4447

45− const goAdmin = useCallback(() => history.push(ROUTE_NAMES.ADMIN), [history]);

48+ const goAdmin = useCallback(() => push(names.ADMIN), [push, names]);

49+

50+ const goInvite = useCallback(() => push(names.INVITE), [push, names]);

4651

47− const goInvite = useCallback(() => history.push(ROUTE_NAMES.INVITE), [

48− history,

52+ const goParties = useCallback(() => push(names.INVITES_MANAGE), [

53+ push,

54+ names,

4955 ]);

5056

57+ const inviteButton = (() => {

58+ switch (azimuth.getPointSize(point)) {

59+ case azimuth.PointSize.Planet:

60+ const availableInvitesText = matchBlinky(availableInvites);

61+ return (

62+ <FooterButton disabled={!isActiveOwner} onClick={goInvite}>

63+ Invite <sup>{availableInvitesText} available</sup>

64+ </FooterButton>

65+ );

66+ //

67+ case azimuth.PointSize.Star:

68+ return (

69+ <FooterButton disabled={!isActiveOwner} onClick={goParties}>

70+ Manage parties

71+ </FooterButton>

72+ );

73+ //

74+ default:

75+ return null;

76+ }

77+ })();

78+

5179 // sync the current cursor

5280 useSyncOwnedPoints([point]);

5381

@@ -73,9 +101,7 @@ export default function Point() {

73101 )}

74102 </Grid>

75103

76− <FooterButton disabled={!canManage} onClick={goInvite}>

77− Invite <sup>{availableInvitesText} available</sup>

78− </FooterButton>

104+ {inviteButton}

79105 </View>

80106 );

81107}