on master help sign in
fix: only call `onValues` when validation is not paused

see https://github.com/final-form/react-final-form/issues/588 for more details

commit95edabbc146d520bbb65e422885b5d3fe6f2c212 authorMatt Condon (shrugs) <mattgcondon@gmail.com> dateMon 12 Aug 2019, 16:48 (7 years ago) parentceb0cae
2 files changed+4−11
src/form/BridgeForm.js+1−1 src/form/ValuesHandler.js+3−10
src/form/BridgeForm.js+1−1
@@ -39,7 +39,7 @@ export default function BridgeForm({
3939 <>
4040 <ValidationPauser />
4141 {children(formProps)}
42− {onValues && <ValuesHandler onValues={onValues} />}
42+ {onValues && <ValuesHandler {...formProps} onValues={onValues} />}
4343 </>
4444 )}
4545 </Form>
src/form/ValuesHandler.js+3−10
@@ -1,21 +1,14 @@
11import { useEffect } from 'react';
2−import { useFormState, useForm } from 'react-final-form';
2+import { useForm } from 'react-final-form';
33
44/**
55 * ValuesHandler notifies callback function when form values change.
66 */
7−export default function ValuesHandler({ onValues }) {
7+export default function ValuesHandler({ valid, validating, values, onValues }) {
88 const form = useForm();
9− const { valid, validating, values } = useFormState({
10− subscription: {
11− valid: true,
12− validating: true,
13− values: true,
14− },
15− });
169
1710 useEffect(() => {
18− if (!validating) {
11+ if (!validating && !form.isValidationPaused()) {
1912 onValues && onValues({ valid, values, form });
2013 }
2114 }, [form, onValues, valid, validating, values]);