on master help sign in
fix: clarify language around seed/mnemonic in lib/keys
commitcf2f7f761a9582503a15b9f2caf814aaf2e527f4 authorMatt Condon (shrugs) <mattgcondon@gmail.com> dateWed 17 Jul 2019, 15:37 (7 years ago) parent5afece3
1 file changed+11−9
src/lib/keys.js+11−9
src/lib/keys.js+11−9
@@ -90,7 +90,10 @@ export const deriveNetworkSeedFromUrbitWallet = async (
9090 urbitWallet,
9191 revision = 1
9292) => {
93− return await deriveNetworkSeedFromSeed(urbitWallet.management.seed, revision);
93+ return await deriveNetworkSeedFromMnemonic(
94+ urbitWallet.management.seed,
95+ revision
96+ );
9497};
9598
9699/**
@@ -100,7 +103,7 @@ export const deriveNetworkSeedFromUrbitWallet = async (
100103 * @param {number} revision
101104 * @return {Promise<Maybe<string>>}
102105 */
103−export const deriveNetworkSeedFromMnemonic = async (
106+export const deriveNetworkSeedFromManagementMnemonic = async (
104107 wallet,
105108 authMnemonic,
106109 details,
@@ -108,22 +111,21 @@ export const deriveNetworkSeedFromMnemonic = async (
108111) => {
109112 const isManagementProxy = eqAddr(wallet.address, details.managementProxy);
110113
111− // the network seed is derivable from mnemonic iff the management proxy
112− // is this mnemonic
114+ // the network seed is derivable iff this mnemonic is the management proxy
113115 if (isManagementProxy) {
114− return await deriveNetworkSeedFromSeed(authMnemonic, revision);
116+ return await deriveNetworkSeedFromMnemonic(authMnemonic, revision);
115117 }
116118
117119 return Nothing();
118120};
119121
120122/**
121− * @param {string} seed
123+ * @param {string} mnemonic
122124 * @param {number} revision
123125 * @return {Promise<Maybe<string>>}
124126 */
125−const deriveNetworkSeedFromSeed = async (seed, revision) => {
126− return Just(await kg.deriveNetworkSeed(seed, '', revision));
127+const deriveNetworkSeedFromMnemonic = async (mnemonic, revision) => {
128+ return Just(await kg.deriveNetworkSeed(mnemonic, '', revision));
127129};
128130
129131/**
@@ -141,7 +143,7 @@ export const attemptNetworkSeedDerivation = async ({
141143 }
142144
143145 if (Just.hasInstance(wallet) && Just.hasInstance(authMnemonic)) {
144− return await deriveNetworkSeedFromMnemonic(
146+ return await deriveNetworkSeedFromManagementMnemonic(
145147 wallet.value,
146148 authMnemonic.value,
147149 details,