browsermt/bergamot-translator
1
1
Fork 0
mirror of https://github.com/browsermt/bergamot-translator.git synced 2024-08-15 08:30:46 +03:00
Code Issues Packages Projects Releases Wiki Activity

Control validating the config options via a boolean flag (#116)

Browse Source 
* Control validating the config options via a boolean flag

 - parseOptions() function now validates the parsed options
   based on the validate argument

* Minor syntactic fix
This commit is contained in:
abhi-agg 2021-04-29 10:38:09 +02:00 committed by GitHub
parent 4be96a97d7
commit e5ec5bdd33
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/translator/parser.h
View File

@ -31,7 +31,7 @@ inline marian::ConfigParser createConfigParser() {
}
inline std::shared_ptr<marian::Options>
parseOptions(const std::string &config) {
parseOptions(const std::string &config, bool validate = true) {
marian::Options options;
// @TODO(jerinphilip) There's something off here, @XapaJIaMnu suggests
@ -58,8 +58,11 @@ parseOptions(const std::string &config) {
options.parse(config);
YAML::Node configCopy = options.cloneToYamlNode();
marian::ConfigValidator validator(configCopy);
validator.validateOptions(marian::cli::mode::translation);
if (validate) {
// Perform validation on parsed options only when requested
marian::ConfigValidator validator(configCopy);
validator.validateOptions(marian::cli::mode::translation);
}
return std::make_shared<marian::Options>(options);
}

2
src/translator/service.h
View File

@ -84,7 +84,7 @@ public:
explicit Service(const std::string &config,
AlignedMemory modelMemory = AlignedMemory(),
AlignedMemory shortlistMemory = AlignedMemory())
: Service(parseOptions(config), std::move(modelMemory),
: Service(parseOptions(config, /*validate=*/false), std::move(modelMemory),
std::move(shortlistMemory)) {}
/// Explicit destructor to clean up after any threads initialized in