claudiodangelis/qrcp
1
1
Fork 0
mirror of https://github.com/claudiodangelis/qrcp.git synced 2024-11-20 10:08:19 +03:00
Code Issues Projects Releases Wiki Activity

fix(server): Fix link when external IP is IPv6 (#335)

Browse Source 
The external IP module can return an IPv6 address, in which case the
method to append a port is to wrap it in square brackets before
appending the ":%d" port string.

Unfortunately Go's IP module does not have a great way to determine
whether an address is an IPv6 address, so fall back to counting the
number of colons in the result as suggested in
https://stackoverflow.com/a/48519490.
This commit is contained in:
Clemens Lang 2024-09-01 14:31:14 +00:00 committed by GitHub
parent a98e75432b
commit 0a0bd6079e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
server/server.go
View File

@ -135,7 +135,13 @@ func New(cfg *config.Config) (*Server, error) {
if err != nil {
panic(err)
}
hostname = fmt.Sprintf("%s:%d", extIP.String(), port)
extIPString := extIP.String()
fmtstring := "%s:%d"
if strings.Count(extIPString, ":") >= 2 {
// IPv6 address, wrap it in [] to add a port
fmtstring = "[%s]:%d"
}
hostname = fmt.Sprintf(fmtstring, extIPString, port)
}
// Use a fully-qualified domain name if set
if cfg.FQDN != "" {