coder/code-server
1
1
Fork 0
mirror of https://github.com/coder/code-server.git synced 2024-12-26 11:12:07 +03:00
Code Issues Packages Projects Releases Wiki Activity

Prevent process.exit()

Browse Source
This commit is contained in:
Asher 2019-10-11 17:00:17 -05:00
parent 567010e163
commit 56ce780522
No known key found for this signature in database
GPG Key ID: D63C1EF81242354A
2 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/node/cli.ts
View File

@ -250,13 +250,19 @@ const main = async(): Promise<boolean | void | void[]> => {
return startCli() || new WrapperProcess().start(); return startCli() || new WrapperProcess().start();
}; };
const exit = process.exit;
process.exit = function (code?: number) {
const err = new Error(`process.exit() was prevented: ${code || "unknown code"}.`);
console.warn(err.stack);
} as (code?: number) => never;
// It's possible that the pipe has closed (for example if you run code-server // It's possible that the pipe has closed (for example if you run code-server
// --version | head -1). Assume that means we're done. // --version | head -1). Assume that means we're done.
if (!process.stdout.isTTY) { if (!process.stdout.isTTY) {
process.stdout.on("error", () => process.exit()); process.stdout.on("error", () => exit());
} }
main().catch((error) => { main().catch((error) => {
logger.error(error.message); logger.error(error.message);
process.exit(typeof error.code === "number" ? error.code : 1); exit(typeof error.code === "number" ? error.code : 1);
}); });

6
src/node/server.ts
View File

@ -653,9 +653,9 @@ export class MainServer extends Server {
this._onDidClientConnect.fire({ this._onDidClientConnect.fire({
protocol, onDidClientDisconnect: connection.onClose, protocol, onDidClientDisconnect: connection.onClose,
}); });
// NOTE: We can do this because we only have one connection at a // TODO: Need a way to match clients with a connection. For now
// time but if that changes we need a way to determine which clients // dispose everything which only works because no extensions currently
// belong to a connection and dispose only those. // utilize long-running proxies.
(this.services.get(INodeProxyService) as NodeProxyService)._onUp.fire(); (this.services.get(INodeProxyService) as NodeProxyService)._onUp.fire();
connection.onClose(() => (this.services.get(INodeProxyService) as NodeProxyService)._onDown.fire()); connection.onClose(() => (this.services.get(INodeProxyService) as NodeProxyService)._onDown.fire());
} else { } else {