composewell/streamly
1
1
Fork 0
mirror of https://github.com/composewell/streamly.git synced 2024-09-11 11:37:22 +03:00
Code Issues Packages Projects Releases Wiki Activity

Change splice to spliceUnsafe

Browse Source 
splice reallocates every time, while we can just allocate the array once.
This commit is contained in:
Harendra Kumar 2024-01-03 15:55:55 +05:30
parent 3b0efcfc48
commit 55cc5d051e
1 changed files with 17 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
core/src/Streamly/Internal/Data/MutArray/Stream.hs
View File

@ -111,8 +111,11 @@ packArraysChunksOf n (D.Stream step state) =
then return $
D.Skip (SpliceYielding buf (SpliceBuffering s arr))
else do
buf1 <- MArray.splice buf arr
return $ D.Skip (SpliceBuffering s buf1)
buf' <- if MArray.byteCapacity buf < n
then liftIO $ MArray.realloc n buf
else return buf
buf'' <- MArray.spliceUnsafe buf' arr
return $ D.Skip (SpliceBuffering s buf'')
D.Skip s -> return $ D.Skip (SpliceBuffering s buf)
D.Stop -> return $ D.Skip (SpliceYielding buf SpliceFinish)
@ -155,19 +158,22 @@ lpackArraysChunksOf n (Fold step1 initial1 _ final1) =
step (Tuple' (Just buf) r1) arr = do
let len = MArray.byteLength buf + MArray.byteLength arr
buf1 <- MArray.splice buf arr
buf' <- if MArray.byteCapacity buf < len
then liftIO $ MArray.realloc (max n len) buf
else return buf
buf'' <- MArray.spliceUnsafe buf' arr
-- XXX this is common in both the equations of step
if len >= n
then do
r <- step1 r1 buf1
r <- step1 r1 buf''
case r of
FL.Done _ -> return $ FL.Done ()
FL.Partial s -> do
_ <- final1 s
res <- initial1
return $ first (Tuple' Nothing) res
else return $ FL.Partial $ Tuple' (Just buf1) r1
else return $ FL.Partial $ Tuple' (Just buf'') r1
-- XXX Several folds do extract >=> final, therefore, we need to make final
-- return "m b" rather than using extract post it if we want extract to be
@ -232,8 +238,12 @@ compactLEParserD n = ParserD.Parser step initial extract
in if len > nBytes
then return $ ParserD.Done 1 buf
else do
buf1 <- MArray.splice buf arr
return $ ParserD.Partial 0 (Just buf1)
buf1 <-
if MArray.byteCapacity buf < nBytes
then liftIO $ MArray.realloc nBytes buf
else return buf
buf2 <- MArray.spliceUnsafe buf1 arr
return $ ParserD.Partial 0 (Just buf2)
extract Nothing = return $ ParserD.Done 0 MArray.nil
extract (Just buf) = return $ ParserD.Done 0 buf