git.iko.soy/crush
on main help sign in
fix(bang): set title in bang mode
03bfdc6Kieran Klukas
internal/agent/agent.go+11−1
compare with main
unifiedsplit
@@ -1742,7 +1742,17 @@ func (a *sessionAgent) GenerateTitle(ctx context.Context, sessionID string, user
1742 title = orphanThinkTagRegex.ReplaceAllString(title, "")
1742 title = orphanThinkTagRegex.ReplaceAllString(title, "")
1743
1743
1744 title = strings.TrimSpace(title)
1744 title = strings.TrimSpace(title)
1745+ if title == "" {
1746+ // LLM returned empty content. Use the prompt itself as a
1747+ // fallback title, truncated to 50 chars, before resorting to
1748+ // the generic default.
1749+ fallback := strings.ReplaceAll(userPrompt, "\n", " ")
1750+ fallback = strings.TrimSpace(fallback)
1751+ if len(fallback) > 50 {
1752+ fallback = fallback[:50]
1753+ }
1745− title = cmp.Or(title, DefaultSessionName)
1754+ title = cmp.Or(fallback, DefaultSessionName)
1755+ }
1746
1756
1747 // Calculate usage and cost.
1757 // Calculate usage and cost.
1748 var openrouterCost *float64
1758 var openrouterCost *float64
internal/workspace/app_workspace.go+27−1
@@ -108,10 +108,22 @@ func (w *AppWorkspace) AgentRun(ctx context.Context, sessionID, prompt string, a
108}
108}
109
109
110func (w *AppWorkspace) AgentRunShellCommand(ctx context.Context, sessionID, command string, termWidth int) (proto.ShellCommandResponse, error) {
110func (w *AppWorkspace) AgentRunShellCommand(ctx context.Context, sessionID, command string, termWidth int) (proto.ShellCommandResponse, error) {
111+ var isFirstMessage bool
111 var persist shell.PersistFunc
112 var persist shell.PersistFunc
112 if sessionID != "" {
113 if sessionID != "" {
113 persist = func(cmd, output string, exitCode int) error {
114 persist = func(cmd, output string, exitCode int) error {
115+ // Check if this is the first user message before persisting.
116+ msgs, err := w.app.Messages.List(ctx, sessionID)
117+ if err == nil {
118+ isFirstMessage = true
119+ for _, msg := range msgs {
120+ if msg.Role == message.User {
121+ isFirstMessage = false
122+ break
123+ }
124+ }
125+ }
114− _, err := w.app.Messages.Create(ctx, sessionID, message.CreateMessageParams{
126+ _, err = w.app.Messages.Create(ctx, sessionID, message.CreateMessageParams{
115 Role: message.User,
127 Role: message.User,
116 Parts: []message.ContentPart{message.ShellCommand{
128 Parts: []message.ContentPart{message.ShellCommand{
117 Command: cmd,
129 Command: cmd,
@@ -132,6 +144,20 @@ func (w *AppWorkspace) AgentRunShellCommand(ctx context.Context, sessionID, comm
132 return proto.ShellCommandResponse{}, err
144 return proto.ShellCommandResponse{}, err
133 }
145 }
134
146
147+ // Generate a title from the shell command if it was the first message.
148+ if isFirstMessage {
149+ go func() {
150+ titleCtx := context.WithoutCancel(ctx)
151+ // Wait for the agent to be ready before generating.
152+ for i := 0; i < 50 && w.app.AgentCoordinator == nil; i++ {
153+ time.Sleep(100 * time.Millisecond)
154+ }
155+ if w.app.AgentCoordinator != nil {
156+ w.app.AgentCoordinator.GenerateTitle(titleCtx, sessionID, "$ "+command)
157+ }
158+ }()
159+ }
160+
135 return proto.ShellCommandResponse{
161 return proto.ShellCommandResponse{
136 Output: result.Output,
162 Output: result.Output,
137 ExitCode: result.ExitCode,
163 ExitCode: result.ExitCode,