055b30f · crush · git.iko.soy

on main help sign in

fix(tui): completions: close when no items match query

055b30fAyman Bagabas1 year ago

internal/tui/components/completions/completions.go+13−6

@@ -150,18 +150,25 @@ func (c *completionsCmp) Update(msg tea.Msg) (tea.Model, tea.Cmd) {

150 if !c.open {

151 return c, nil // If completions are not open, do nothing

152 }

153+ var cmds []tea.Cmd

153− cmd := c.list.Filter(msg.Query)

154+ cmds = append(cmds, c.list.Filter(msg.Query))

155+ itemsLen := len(c.list.Items())

154− c.height = max(min(10, len(c.list.Items())), 1)

156+ c.height = max(min(10, itemsLen), 1)

155− return c, tea.Batch(

156− cmd,

157− c.list.SetSize(c.width, c.height),

157+ cmds = append(cmds, c.list.SetSize(c.width, c.height))

158− )

158+ if itemsLen == 0 {

159+ // Close completions if no items match the query

160+ cmds = append(cmds, util.CmdHandler(CloseCompletionsMsg{}))

161+ }

162+ return c, tea.Batch(cmds...)

159 }

163 }

160 return c, nil

164 return c, nil

161}

165}

162

166

163// View implements Completions.

167// View implements Completions.

164func (c *completionsCmp) View() string {

168func (c *completionsCmp) View() string {

169+ if !c.open {

170+ return ""

171+ }

165 if len(c.list.Items()) == 0 {

172 if len(c.list.Items()) == 0 {

166 return c.style().Render("No completions found")

173 return c.style().Render("No completions found")

167 }

174 }