on main help sign in
fix: improve ux for presenting errors from providers (#1388)
commit07a4738eecdf33e66e659e0a77ad70db21aaea0d authorAndrey Nering <andreynering@users.noreply.github.com> dateFri 7 Nov 2025, 17:03 (1 year ago) parent87df66d
4 files changed+24−5
go.mod+1−1 go.sum+2−2 internal/agent/agent.go+11−2 internal/stringext/string.go+10
go.mod+1−1
@@ -5,7 +5,7 @@ go 1.25.0
55require (
66 charm.land/bubbles/v2 v2.0.0-beta.1.0.20251104200223-da0b892d1759
77 charm.land/bubbletea/v2 v2.0.0-rc.1.0.20251106195925-579e174cd7fa
8− charm.land/fantasy v0.1.6
8+ charm.land/fantasy v0.2.0
99 charm.land/lipgloss/v2 v2.0.0-beta.3.0.20251106193318-19329a3e8410
1010 github.com/JohannesKaufmann/html-to-markdown v1.6.0
1111 github.com/MakeNowJust/heredoc v1.0.0
go.sum+2−2
@@ -2,8 +2,8 @@ charm.land/bubbles/v2 v2.0.0-beta.1.0.20251104200223-da0b892d1759 h1:P1MxkVl8ZeI
22charm.land/bubbles/v2 v2.0.0-beta.1.0.20251104200223-da0b892d1759/go.mod h1:G7JWaj3kDT0BDB+h5BLDUhhBLpDoRLKrpOp5QrA2SQs=
33charm.land/bubbletea/v2 v2.0.0-rc.1.0.20251106195925-579e174cd7fa h1:J30WneaxF2CV3f2ofamxlr+RwyF6LKSJ3UesrtHfU9I=
44charm.land/bubbletea/v2 v2.0.0-rc.1.0.20251106195925-579e174cd7fa/go.mod h1:lUNldRH4wRBZ9SGFqlss1Pep7QXzgV/Fp+V9BsAhOPc=
5−charm.land/fantasy v0.1.6 h1:laomMUqUaniQoLx7UOb+MLUpIGJPoNwsXvw1PbzgnB8=
6−charm.land/fantasy v0.1.6/go.mod h1:JpFcJ5zs/1CjmYYGAZ7GaFmeBv0mPaTzEPRG6Eic5pc=
5+charm.land/fantasy v0.2.0 h1:BO1eMugePqrXe46zlNQZI6ajzqt/kft0IMiIAYBqsAo=
6+charm.land/fantasy v0.2.0/go.mod h1:JpFcJ5zs/1CjmYYGAZ7GaFmeBv0mPaTzEPRG6Eic5pc=
77charm.land/lipgloss/v2 v2.0.0-beta.3.0.20251106193318-19329a3e8410 h1:D9PbaszZYpB4nj+d6HTWr1onlmlyuGVNfL9gAi8iB3k=
88charm.land/lipgloss/v2 v2.0.0-beta.3.0.20251106193318-19329a3e8410/go.mod h1:1qZyvvVCenJO2M1ac2mX0yyiIZJoZmDM4DG4s0udJkU=
99cloud.google.com/go v0.116.0 h1:B3fRrSDkLRt5qSHWe40ERJvhvnQwdZiHu0bJOpldweE=
internal/agent/agent.go+11−2
@@ -8,6 +8,7 @@
88package agent
99
1010import (
11+ "cmp"
1112 "context"
1213 _ "embed"
1314 "errors"
@@ -32,6 +33,7 @@ import (
3233 "github.com/charmbracelet/crush/internal/message"
3334 "github.com/charmbracelet/crush/internal/permission"
3435 "github.com/charmbracelet/crush/internal/session"
36+ "github.com/charmbracelet/crush/internal/stringext"
3537)
3638
3739//go:embed templates/title.md
@@ -303,7 +305,7 @@ func (a *sessionAgent) Run(ctx context.Context, call SessionAgentCall) (*fantasy
303305 currentAssistant.AddToolCall(toolCall)
304306 return a.messages.Update(genCtx, *currentAssistant)
305307 },
306− OnRetry: func(err *fantasy.APICallError, delay time.Duration) {
308+ OnRetry: func(err *fantasy.ProviderError, delay time.Duration) {
307309 // TODO: implement
308310 },
309311 OnToolCall: func(tc fantasy.ToolCallContent) error {
@@ -459,12 +461,19 @@ func (a *sessionAgent) Run(ctx context.Context, call SessionAgentCall) (*fantasy
459461 return nil, createErr
460462 }
461463 }
464+ var fantasyErr *fantasy.Error
465+ var providerErr *fantasy.ProviderError
466+ const defaultTitle = "Provider Error"
462467 if isCancelErr {
463468 currentAssistant.AddFinish(message.FinishReasonCanceled, "User canceled request", "")
464469 } else if isPermissionErr {
465470 currentAssistant.AddFinish(message.FinishReasonPermissionDenied, "User denied permission", "")
471+ } else if errors.As(err, &providerErr) {
472+ currentAssistant.AddFinish(message.FinishReasonError, cmp.Or(stringext.Capitalize(providerErr.Title), defaultTitle), providerErr.Message)
473+ } else if errors.As(err, &fantasyErr) {
474+ currentAssistant.AddFinish(message.FinishReasonError, cmp.Or(stringext.Capitalize(fantasyErr.Title), defaultTitle), fantasyErr.Message)
466475 } else {
467− currentAssistant.AddFinish(message.FinishReasonError, "API Error", err.Error())
476+ currentAssistant.AddFinish(message.FinishReasonError, defaultTitle, err.Error())
468477 }
469478 // Note: we use the parent context here because the genCtx has been
470479 // cancelled.
internal/stringext/string.gonew file+10
@@ -0,0 +1,10 @@
1+package stringext
2+
3+import (
4+ "golang.org/x/text/cases"
5+ "golang.org/x/text/language"
6+)
7+
8+func Capitalize(text string) string {
9+ return cases.Title(language.English, cases.Compact).String(text)
10+}