git.iko.soy/crush
on main help sign in
fix: prevent flaky diffview golden tests on Windows CI

Chroma's regexp2 engine has a hardcoded 250ms match timeout. On Windows CI with -race and 110+ parallel subtests, CPU contention causes regex matches to exceed this timeout, silently skipping rules and producing different token types (NameOther instead of NameFunction). Remove t.Parallel() from innermost subtests to reduce contention while keeping parent-level parallelism.

commit1bb945c83f68f841c187b24638c4ca4d1ef4a8b7 authorKieran Klukas <kieran@dunkirk.sh> dateWed 24 Jun 2026, 11:53 (4 months ago) parent7206981
1 file changed−10
compare with main
unifiedsplit
internal/ui/diffview/diffview_test.go−10
internal/ui/diffview/diffview_test.go−10
@@ -212,8 +212,6 @@ func TestDiffViewWidth(t *testing.T) {
212212 }
213213
214214 t.Run(fmt.Sprintf("WidthOf%03d", width), func(t *testing.T) {
215− t.Parallel()
216−
217215 dv := diffview.New().
218216 Before("main.go", TestMultipleHunksBefore).
219217 After("main.go", TestMultipleHunksAfter).
@@ -237,8 +235,6 @@ func TestDiffViewHeight(t *testing.T) {
237235 t.Run(layoutName, func(t *testing.T) {
238236 for height := 1; height <= 20; height++ {
239237 t.Run(fmt.Sprintf("HeightOf%03d", height), func(t *testing.T) {
240− t.Parallel()
241−
242238 dv := diffview.New().
243239 Before("main.go", TestMultipleHunksBefore).
244240 After("main.go", TestMultipleHunksAfter).
@@ -260,8 +256,6 @@ func TestDiffViewXOffset(t *testing.T) {
260256 t.Run(layoutName, func(t *testing.T) {
261257 for xOffset := range 21 {
262258 t.Run(fmt.Sprintf("XOffsetOf%02d", xOffset), func(t *testing.T) {
263− t.Parallel()
264−
265259 dv := diffview.New().
266260 Before("main.go", TestDefaultBefore).
267261 After("main.go", TestDefaultAfter).
@@ -286,8 +280,6 @@ func TestDiffViewYOffset(t *testing.T) {
286280 t.Run(layoutName, func(t *testing.T) {
287281 for yOffset := range 17 {
288282 t.Run(fmt.Sprintf("YOffsetOf%02d", yOffset), func(t *testing.T) {
289− t.Parallel()
290−
291283 dv := diffview.New().
292284 Before("main.go", TestMultipleHunksBefore).
293285 After("main.go", TestMultipleHunksAfter).
@@ -310,8 +302,6 @@ func TestDiffViewYOffsetInfinite(t *testing.T) {
310302 t.Run(layoutName, func(t *testing.T) {
311303 for yOffset := range 17 {
312304 t.Run(fmt.Sprintf("YOffsetOf%02d", yOffset), func(t *testing.T) {
313− t.Parallel()
314−
315305 dv := diffview.New().
316306 Before("main.go", TestMultipleHunksBefore).
317307 After("main.go", TestMultipleHunksAfter).