2679ea6 · crush · git.iko.soy

git.iko.soy/crush

fix(tools): lowercase remaining view.go error messages, fix tests

Lowercased 'This model does not support image data', 'Content section is too large', and 'File content is not valid UTF-8' for consistency with Go error message conventions. Updated test expectations to match.

commit2679ea68bfea984c36c677f4f0c56cb1fc5710e3 authoriko <mail@iko.soy> dateThu 9 Jul 2026, 03:50 (3 months ago) parent19eb38a

2 files changed+6−6

compare with main

unifiedsplit

internal/agent/tools/view.go+4−4 internal/agent/tools/view_test.go+2−2

internal/agent/tools/view.go+4−4

@@ -209,7 +209,7 @@ func NewViewTool(

209209 }

210210 if !GetSupportsImagesFromContext(ctx) {

211211 modelName := GetModelNameFromContext(ctx)

212− return fantasy.NewTextErrorResponse(fmt.Sprintf("This model (%s) does not support image data.", modelName)), nil

212+ return fantasy.NewTextErrorResponse(fmt.Sprintf("this model (%s) does not support image data.", modelName)), nil

213213 }

214214

215215 imageData, readErr := os.ReadFile(filePath)

@@ -237,13 +237,13 @@ func NewViewTool(

237237 if err != nil {

238238 var tooLarge contentTooLargeError

239239 if errors.As(err, &tooLarge) {

240− return fantasy.NewTextErrorResponse(fmt.Sprintf("Content section is too large (%d bytes). Maximum size is %d bytes",

240+ return fantasy.NewTextErrorResponse(fmt.Sprintf("content section is too large (%d bytes). Maximum size is %d bytes",

241241 tooLarge.Size, tooLarge.Max)), nil

242242 }

243243 return fantasy.ToolResponse{}, fmt.Errorf("error reading file: %w", err)

244244 }

245245 if !utf8.ValidString(content) {

246− return fantasy.NewTextErrorResponse("File content is not valid UTF-8"), nil

246+ return fantasy.NewTextErrorResponse("file content is not valid UTF-8"), nil

247247 }

248248

249249 openInLSPs(ctx, lspManager, filePath)

@@ -453,7 +453,7 @@ func readBuiltinFile(params ViewParams, skillTracker *skills.Tracker) (fantasy.T

453453

454454 content := string(data)

455455 if !utf8.ValidString(content) {

456− return fantasy.NewTextErrorResponse("File content is not valid UTF-8"), nil

456+ return fantasy.NewTextErrorResponse("file content is not valid UTF-8"), nil

457457 }

458458

459459 limit := params.Limit

internal/agent/tools/view_test.go+2−2

@@ -151,7 +151,7 @@ func TestViewToolBlocksOversizedReturnedSections(t *testing.T) {

151151 })

152152

153153 require.True(t, resp.IsError)

154− require.Contains(t, resp.Content, "Content section is too large")

154+ require.Contains(t, resp.Content, "content section is too large")

155155}

156156

157157func TestViewToolBlocksOversizedImages(t *testing.T) {

@@ -169,7 +169,7 @@ func TestViewToolBlocksOversizedImages(t *testing.T) {

169169 })

170170

171171 require.True(t, resp.IsError)

172− require.Contains(t, resp.Content, "Image file is too large")

172+ require.Contains(t, resp.Content, "image file is too large")

173173}

174174

175175func TestReadTextFileEnforcesMaxContentSize(t *testing.T) {