git.iko.soy/crush
on main help sign in
chore: return empty slices instead of nil for safety

💘 Generated with Crush Assisted-by: GLM-4.7 via Crush <crush@charm.land>

commit2f845cc20e1b01310886a7dcbd440011e80cc8d4 authorChristian Rocha <christian@rocha.is> dateSun 18 Jan 2026, 17:41 (9 months ago) parent1ca8abc
2 files changed+5−10
compare with main
unifiedsplit
internal/env/env.go+1−8 internal/env/env_test.go+4−2
internal/env/env.go+1−8
@@ -17,11 +17,7 @@ func (o *osEnv) Get(key string) string {
1717}
1818
1919func (o *osEnv) Env() []string {
20− env := os.Environ()
21− if len(env) == 0 {
22− return nil
23− }
24− return env
20+ return os.Environ()
2521}
2622
2723func New() Env {
@@ -42,9 +38,6 @@ func (m *mapEnv) Get(key string) string {
4238
4339// Env implements Env.
4440func (m *mapEnv) Env() []string {
45− if len(m.m) == 0 {
46− return nil
47− }
4841 env := make([]string, 0, len(m.m))
4942 for k, v := range m.m {
5043 env = append(env, k+"="+v)
internal/env/env_test.go+4−2
@@ -90,13 +90,15 @@ func TestMapEnv_Env(t *testing.T) {
9090 t.Run("empty map", func(t *testing.T) {
9191 env := NewFromMap(map[string]string{})
9292 envVars := env.Env()
93− require.Nil(t, envVars)
93+ require.NotNil(t, envVars)
94+ require.Len(t, envVars, 0)
9495 })
9596
9697 t.Run("nil map", func(t *testing.T) {
9798 env := NewFromMap(nil)
9899 envVars := env.Env()
99− require.Nil(t, envVars)
100+ require.NotNil(t, envVars)
101+ require.Len(t, envVars, 0)
100102 })
101103}
102104