git.iko.soy/crush
on main help sign in
docs: fix misleading TODO comments
490c2f8iko
internal/ui/dialog/commands.go+3−3
compare with main
unifiedsplit
@@ -370,9 +370,9 @@ func (c *Commands) defaultCommands() []*CommandItem {
370
370
371 // Add external editor command if $EDITOR is available.
371 // Add external editor command if $EDITOR is available.
372 //
372 //
373− // TODO: Use [tea.EnvMsg] to get environment variable instead of os.Getenv;
373+ // TODO: Use [tea.EnvMsg] to get environment variables instead of os.Getenv;
374− // because os.Getenv does IO is breaks the TEA paradigm and is generally an
374+ // reading the environment directly bypasses the TEA message system and is
375− // antipattern.
375+ // generally an antipattern.
376 if os.Getenv("EDITOR") != "" {
376 if os.Getenv("EDITOR") != "" {
377 commands = append(commands, NewCommandItem(c.com.Styles, "open_external_editor", "Open External Editor", "ctrl+o", ActionExternalEditor{}))
377 commands = append(commands, NewCommandItem(c.com.Styles, "open_external_editor", "Open External Editor", "ctrl+o", ActionExternalEditor{}))
378 }
378 }
internal/ui/model/onboarding.go−1
@@ -72,7 +72,6 @@ func (m *UI) initializeProject() tea.Cmd {
72
72
73// skipInitializeProject skips project initialization and transitions to the landing view.
73// skipInitializeProject skips project initialization and transitions to the landing view.
74func (m *UI) skipInitializeProject() tea.Cmd {
74func (m *UI) skipInitializeProject() tea.Cmd {
75− // TODO: initialize the project
76 m.setState(uiLanding, uiFocusEditor)
75 m.setState(uiLanding, uiFocusEditor)
77 // mark the project as initialized
76 // mark the project as initialized
78 return m.markProjectInitializedCmd()
77 return m.markProjectInitializedCmd()