git.iko.soy/crush
on main help sign in
perf(lsp): don't watch for changes when simply reading files
6604dd0Christian Rocha
internal/agent/tools/diagnostics.go+23−3
compare with main
unifiedsplit
@@ -37,16 +37,36 @@ func NewDiagnosticsTool(lspManager *lsp.Manager) fantasy.AgentTool {
37 })
37 })
38}
38}
39
39
40−func notifyLSPs(
40+// openInLSPs ensures LSP servers are running and aware of the file, but does
41+// not notify changes or wait for fresh diagnostics. Use this for read-only
42+// operations like view where the file content hasn't changed.
43+func openInLSPs(
41 ctx context.Context,
44 ctx context.Context,
42 manager *lsp.Manager,
45 manager *lsp.Manager,
43 filepath string,
46 filepath string,
44) {
47) {
45− if filepath == "" {
48+ if filepath == "" || manager == nil {
46 return
49 return
47 }
50 }
48
51
52+ manager.Start(ctx, filepath)
53+
54+ for client := range manager.Clients().Seq() {
55+ if !client.HandlesFile(filepath) {
56+ continue
57+ }
58+ _ = client.OpenFileOnDemand(ctx, filepath)
59+ }
60+}
61+
62+// notifyLSPs notifies LSP servers that a file has changed and waits for
63+// updated diagnostics. Use this after edit/multiedit operations.
64+func notifyLSPs(
65+ ctx context.Context,
66+ manager *lsp.Manager,
67+ filepath string,
68+) {
49− if manager == nil {
69+ if filepath == "" || manager == nil {
50 return
70 return
51 }
71 }
52
72
internal/agent/tools/view.go+1−1
@@ -193,7 +193,7 @@ func NewViewTool(
193 return fantasy.NewTextErrorResponse("File content is not valid UTF-8"), nil
193 return fantasy.NewTextErrorResponse("File content is not valid UTF-8"), nil
194 }
194 }
195
195
196− notifyLSPs(ctx, lspManager, filePath)
196+ openInLSPs(ctx, lspManager, filePath)
197 output := "<file>\n"
197 output := "<file>\n"
198 output += addLineNumbers(content, params.Offset+1)
198 output += addLineNumbers(content, params.Offset+1)
199
199