git.iko.soy/crush
on main help sign in
fix(ui): dialog: no need for groupItems map in ModelsList.VisibleItems
67ac46aAyman Bagabas
internal/ui/dialog/models_list.go+2−4
compare with main
unifiedsplit
@@ -81,12 +81,10 @@ func (f *ModelsList) VisibleItems() []list.Item {
81 return items
81 return items
82 }
82 }
83
83
84− groupItems := map[int][]*ModelItem{}
85 filterableItems := []list.FilterableItem{}
84 filterableItems := []list.FilterableItem{}
86− for i, g := range f.groups {
85+ for _, g := range f.groups {
87 for _, item := range g.Items {
86 for _, item := range g.Items {
88 filterableItems = append(filterableItems, item)
87 filterableItems = append(filterableItems, item)
89− groupItems[i] = append(groupItems[i], item)
90 }
88 }
91 }
89 }
92
90
@@ -109,7 +107,7 @@ func (f *ModelsList) VisibleItems() []list.Item {
109 addedCount := 0
107 addedCount := 0
110 for _, match := range matches {
108 for _, match := range matches {
111 item := filterableItems[match.Index]
109 item := filterableItems[match.Index]
112− if slices.Contains(groupItems[gi], item.(*ModelItem)) {
110+ if slices.Contains(g.Items, item.(*ModelItem)) {
113 if !visitedGroups[gi] {
111 if !visitedGroups[gi] {
114 // Add section header
112 // Add section header
115 items = append(items, &g)
113 items = append(items, &g)