on main help sign in
Merge pull request #227 from charmbracelet/bugfix/panic-loglines

bugfix: fixup panic for oob range

commit7ee0eb0432c91f853982e7e02a9650a3a0bd92a0 authorKujtim Hoxha <kujtimii.h@gmail.com> dateFri 18 Jul 2025, 10:10 (1 year ago) parent52346a276fc7e7
1 file changed+4−12
cmd/logs.go+4−12
cmd/logs.go+4−12
@@ -77,17 +77,13 @@ func followLogs(ctx context.Context, logsFile string, tailLines int) error {
7777 }
7878
7979 var lines []string
80− lineCount := 0
8180 for line := range t.Lines {
8281 if line.Err != nil {
8382 continue
8483 }
8584 lines = append(lines, line.Text)
86− lineCount++
87− if lineCount >= tailLines {
88− if len(lines) > tailLines {
89− lines = lines[len(lines)-tailLines:]
90− }
85+ if len(lines) > tailLines {
86+ lines = lines[len(lines)-tailLines:]
9187 }
9288 }
9389 t.Stop()
@@ -138,17 +134,13 @@ func showLogs(logsFile string, tailLines int) error {
138134 defer t.Stop()
139135
140136 var lines []string
141− lineCount := 0
142137 for line := range t.Lines {
143138 if line.Err != nil {
144139 continue
145140 }
146141 lines = append(lines, line.Text)
147− lineCount++
148− if lineCount >= tailLines {
149− if len(lines) > tailLines {
150− lines = lines[len(lines)-tailLines:]
151− }
142+ if len(lines) > tailLines {
143+ lines = lines[len(lines)-tailLines:]
152144 }
153145 }
154146