on main help sign in
refactor: make func unexported
commit7ff6ba95be162d727eb3b0059566192dfd5f321f authorAndrey Nering <andreynering@users.noreply.github.com> dateMon 15 Sep 2025, 09:55 (1 year ago) parent8cae314
3 files changed+6−6
internal/lsp/watcher/global_watcher.go+1−1 internal/lsp/watcher/rlimit_stub.go+3−3 internal/lsp/watcher/rlimit_unix.go+2−2
internal/lsp/watcher/global_watcher.go+1−1
@@ -118,7 +118,7 @@ func Start() error {
118118 // Check if the error might be due to file descriptor limits
119119 if isFileLimitError(err) {
120120 slog.Warn("lsp watcher: Hit file descriptor limit, attempting to increase", "error", err)
121− if newLimit, rlimitErr := MaximizeOpenFileLimit(); rlimitErr == nil {
121+ if newLimit, rlimitErr := maximizeOpenFileLimit(); rlimitErr == nil {
122122 slog.Info("lsp watcher: Increased file descriptor limit", "limit", newLimit)
123123 // Retry the watch operation
124124 if err = notify.Watch(watchPath, gw.events, events); err == nil {
internal/lsp/watcher/rlimit_stub.go+3−3
@@ -2,11 +2,11 @@
22
33package watcher
44
5−// MaximizeOpenFileLimit is a no-op on non-Unix systems.
5+// maximizeOpenFileLimit is a no-op on non-Unix systems.
66// Returns a high value to indicate no practical limit.
7−func MaximizeOpenFileLimit() (int, error) {
7+func maximizeOpenFileLimit() (int, error) {
88 // Windows and other non-Unix systems don't have file descriptor limits
99 // in the same way Unix systems do. Return a very high value to indicate
1010 // there's no practical limit to worry about.
1111 return 10000000, nil // 10M handles - way more than any process would use
12−}
12+}
internal/lsp/watcher/rlimit_unix.go+2−2
@@ -16,11 +16,11 @@ const (
1616 darwinOpenMax = 10240
1717)
1818
19−// MaximizeOpenFileLimit tries to set the resource limit RLIMIT_NOFILE (number
19+// maximizeOpenFileLimit tries to set the resource limit RLIMIT_NOFILE (number
2020// of open file descriptors) to the max (hard limit), if the current (soft
2121// limit) is below the max. Returns the new (though possibly unchanged) limit,
2222// or an error if it could not be changed.
23−func MaximizeOpenFileLimit() (int, error) {
23+func maximizeOpenFileLimit() (int, error) {
2424 // Get the current limit on number of open files.
2525 var lim syscall.Rlimit
2626 if err := syscall.Getrlimit(syscall.RLIMIT_NOFILE, &lim); err != nil {