git.iko.soy/crush
on main help sign in
refactor(agent): clarify user-initiated cancellations and denials (#1368)
88c88c6Amolith
internal/agent/agent.go+3−3
compare with main
unifiedsplit
@@ -427,7 +427,7 @@ func (a *sessionAgent) Run(ctx context.Context, call SessionAgentCall) (*fantasy
427 if isCancelErr {
427 if isCancelErr {
428 content = "Tool execution canceled by user"
428 content = "Tool execution canceled by user"
429 } else if isPermissionErr {
429 } else if isPermissionErr {
430− content = "Permission denied"
430+ content = "User denied permission"
431 }
431 }
432 toolResult := message.ToolResult{
432 toolResult := message.ToolResult{
433 ToolCallID: tc.ID,
433 ToolCallID: tc.ID,
@@ -446,9 +446,9 @@ func (a *sessionAgent) Run(ctx context.Context, call SessionAgentCall) (*fantasy
446 }
446 }
447 }
447 }
448 if isCancelErr {
448 if isCancelErr {
449− currentAssistant.AddFinish(message.FinishReasonCanceled, "Request cancelled", "")
449+ currentAssistant.AddFinish(message.FinishReasonCanceled, "User canceled request", "")
450 } else if isPermissionErr {
450 } else if isPermissionErr {
451− currentAssistant.AddFinish(message.FinishReasonPermissionDenied, "Permission denied", "")
451+ currentAssistant.AddFinish(message.FinishReasonPermissionDenied, "User denied permission", "")
452 } else {
452 } else {
453 currentAssistant.AddFinish(message.FinishReasonError, "API Error", err.Error())
453 currentAssistant.AddFinish(message.FinishReasonError, "API Error", err.Error())
454 }
454 }
internal/permission/permission.go+1−1
@@ -13,7 +13,7 @@ import (
13 "github.com/google/uuid"
13 "github.com/google/uuid"
14)
14)
15
15
16−var ErrorPermissionDenied = errors.New("permission denied")
16+var ErrorPermissionDenied = errors.New("user denied permission")
17
17
18type CreatePermissionRequest struct {
18type CreatePermissionRequest struct {
19 SessionID string `json:"session_id"`
19 SessionID string `json:"session_id"`