git.iko.soy/crush
on main help sign in
Fix(gemini): ensure tool responses have the user role
a9d3080David Mohl
internal/llm/provider/gemini.go+12−20
compare with main
unifiedsplit
@@ -102,6 +102,7 @@ func (g *geminiClient) convertMessages(messages []message.Message) []*genai.Cont
102 }
102 }
103
103
104 case message.Tool:
104 case message.Tool:
105+ var toolParts []*genai.Part
105 for _, result := range msg.ToolResults() {
106 for _, result := range msg.ToolResults() {
106 response := map[string]any{"result": result.Content}
107 response := map[string]any{"result": result.Content}
107 parsed, err := parseJSONToMap(result.Content)
108 parsed, err := parseJSONToMap(result.Content)
@@ -121,16 +122,17 @@ func (g *geminiClient) convertMessages(messages []message.Message) []*genai.Cont
121 }
122 }
122 }
123 }
123
124
124− history = append(history, &genai.Content{
125+ toolParts = append(toolParts, &genai.Part{
125− Parts: []*genai.Part{
126− {
127− FunctionResponse: &genai.FunctionResponse{
126+ FunctionResponse: &genai.FunctionResponse{
128− Name: toolCall.Name,
127+ Name: toolCall.Name,
129− Response: response,
128+ Response: response,
130− },
131− },
132 },
129 },
130+ })
131+ }
132+ if len(toolParts) > 0 {
133+ history = append(history, &genai.Content{
134+ Parts: toolParts,
133− Role: genai.RoleModel,
135+ Role: genai.RoleUser,
134 })
136 })
135 }
137 }
136 }
138 }
@@ -373,17 +375,7 @@ func (g *geminiClient) stream(ctx context.Context, messages []message.Message, t
373 Finished: true,
375 Finished: true,
374 }
376 }
375
377
376− isNew := true
377− for _, existing := range toolCalls {
378− if existing.Name == newCall.Name && existing.Input == newCall.Input {
379− isNew = false
380− break
381− }
382− }
383−
384− if isNew {
385− toolCalls = append(toolCalls, newCall)
378+ toolCalls = append(toolCalls, newCall)
386− }
387 }
379 }
388 }
380 }
389 } else {
381 } else {