git.iko.soy/crush
on main help sign in
fix: disable providers (#1087)

* fix: disable providers if we remove then from the list, they'll still show up because they won't get merged with catwalk providers later on. closes #1037 Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

commitab96589e7ed71411582ae2b970ddadd1bb9d3a83 authorCarlos Alexandro Becker <caarlos0@users.noreply.github.com> dateTue 23 Sep 2025, 16:11 (1 year ago) parent4dd2b17
2 files changed+4−9
compare with main
unifiedsplit
internal/config/load.go−5 internal/config/load_test.go+4−4
internal/config/load.go−5
@@ -126,11 +126,6 @@ func (c *Config) configureProviders(env env.Env, resolver VariableResolver, know
126126 config, configExists := c.Providers.Get(string(p.ID))
127127 // if the user configured a known provider we need to allow it to override a couple of parameters
128128 if configExists {
129− if config.Disable {
130− slog.Debug("Skipping provider due to disable flag", "provider", p.ID)
131− c.Providers.Del(string(p.ID))
132− continue
133− }
134129 if config.BaseURL != "" {
135130 p.APIEndpoint = config.BaseURL
136131 }
internal/config/load_test.go+4−4
@@ -543,10 +543,10 @@ func TestConfig_configureProvidersWithDisabledProvider(t *testing.T) {
543543 err := cfg.configureProviders(env, resolver, knownProviders)
544544 require.NoError(t, err)
545545
546− // Provider should be removed from config when disabled
547− require.Equal(t, cfg.Providers.Len(), 0)
548− _, exists := cfg.Providers.Get("openai")
549− require.False(t, exists)
546+ require.Equal(t, cfg.Providers.Len(), 1)
547+ prov, exists := cfg.Providers.Get("openai")
548+ require.True(t, exists)
549+ require.True(t, prov.Disable)
550550}
551551
552552func TestConfig_configureProvidersCustomProviderValidation(t *testing.T) {