on main help sign in
fix(ui): dry up up/down key binding in dialog commands
c4cdc5dAyman Bagabas
internal/ui/dialog/commands.go+6−5
@@ -31,6 +31,7 @@ type Commands struct {
31 com *common.Common
31 com *common.Common
32 keyMap struct {
32 keyMap struct {
33 Select,
33 Select,
34+ UpDown,
34 Next,
35 Next,
35 Previous,
36 Previous,
36 Tab,
37 Tab,
@@ -87,6 +88,10 @@ func NewCommands(com *common.Common, sessionID string) (*Commands, error) {
87 key.WithKeys("enter", "ctrl+y"),
88 key.WithKeys("enter", "ctrl+y"),
88 key.WithHelp("enter", "confirm"),
89 key.WithHelp("enter", "confirm"),
89 )
90 )
91+ c.keyMap.UpDown = key.NewBinding(
92+ key.WithKeys("up", "down"),
93+ key.WithHelp("↑/↓", "choose"),
94+ )
90 c.keyMap.Next = key.NewBinding(
95 c.keyMap.Next = key.NewBinding(
91 key.WithKeys("down", "ctrl+n"),
96 key.WithKeys("down", "ctrl+n"),
92 key.WithHelp("↓", "next item"),
97 key.WithHelp("↓", "next item"),
@@ -240,13 +245,9 @@ func (c *Commands) View() string {
240
245
241// ShortHelp implements [help.KeyMap].
246// ShortHelp implements [help.KeyMap].
242func (c *Commands) ShortHelp() []key.Binding {
247func (c *Commands) ShortHelp() []key.Binding {
243− upDown := key.NewBinding(
244− key.WithKeys("up", "down"),
245− key.WithHelp("↑/↓", "choose"),
246− )
247 return []key.Binding{
248 return []key.Binding{
248 c.keyMap.Tab,
249 c.keyMap.Tab,
249− upDown,
250+ c.keyMap.UpDown,
250 c.keyMap.Select,
251 c.keyMap.Select,
251 c.keyMap.Close,
252 c.keyMap.Close,
252 }
253 }