git.iko.soy/crush
on main help sign in
fix(lint): don't shadow 'env' variable
d4d331fChristian Rocha
internal/agent/agent_test.go+1−1
compare with main
unifiedsplit
@@ -33,7 +33,7 @@ func getModels(t *testing.T, r *recorder.Recorder, pair modelPair) (fantasy.Lang
33 return large, small
33 return large, small
34}
34}
35
35
36−func setupAgent(t *testing.T, pair modelPair) (SessionAgent, env) {
36+func setupAgent(t *testing.T, pair modelPair) (SessionAgent, fakeEnv) {
37 r := newRecorder(t)
37 r := newRecorder(t)
38 large, small := getModels(t, r, pair)
38 large, small := getModels(t, r, pair)
39 env := testEnv(t)
39 env := testEnv(t)
internal/agent/common_test.go+6−5
@@ -30,7 +30,8 @@ import (
30 _ "github.com/joho/godotenv/autoload"
30 _ "github.com/joho/godotenv/autoload"
31)
31)
32
32
33+// fakeEnv is an environment for testing.
33−type env struct {
34+type fakeEnv struct {
34 workingDir string
35 workingDir string
35 sessions session.Service
36 sessions session.Service
36 messages message.Service
37 messages message.Service
@@ -100,7 +101,7 @@ func zAIBuilder(model string) builderFunc {
100 }
101 }
101}
102}
102
103
103−func testEnv(t *testing.T) env {
104+func testEnv(t *testing.T) fakeEnv {
104 workingDir := filepath.Join("/tmp/crush-test/", t.Name())
105 workingDir := filepath.Join("/tmp/crush-test/", t.Name())
105 os.RemoveAll(workingDir)
106 os.RemoveAll(workingDir)
106
107
@@ -123,7 +124,7 @@ func testEnv(t *testing.T) env {
123 os.RemoveAll(workingDir)
124 os.RemoveAll(workingDir)
124 })
125 })
125
126
126− return env{
127+ return fakeEnv{
127 workingDir,
128 workingDir,
128 sessions,
129 sessions,
129 messages,
130 messages,
@@ -133,7 +134,7 @@ func testEnv(t *testing.T) env {
133 }
134 }
134}
135}
135
136
136−func testSessionAgent(env env, large, small fantasy.LanguageModel, systemPrompt string, tools ...fantasy.AgentTool) SessionAgent {
137+func testSessionAgent(env fakeEnv, large, small fantasy.LanguageModel, systemPrompt string, tools ...fantasy.AgentTool) SessionAgent {
137 largeModel := Model{
138 largeModel := Model{
138 Model: large,
139 Model: large,
139 CatwalkCfg: catwalk.Model{
140 CatwalkCfg: catwalk.Model{
@@ -152,7 +153,7 @@ func testSessionAgent(env env, large, small fantasy.LanguageModel, systemPrompt
152 return agent
153 return agent
153}
154}
154
155
155−func coderAgent(r *recorder.Recorder, env env, large, small fantasy.LanguageModel) (SessionAgent, error) {
156+func coderAgent(r *recorder.Recorder, env fakeEnv, large, small fantasy.LanguageModel) (SessionAgent, error) {
156 fixedTime := func() time.Time {
157 fixedTime := func() time.Time {
157 t, _ := time.Parse("1/2/2006", "1/1/2025")
158 t, _ := time.Parse("1/2/2006", "1/1/2025")
158 return t
159 return t