e18a77f · crush · git.iko.soy

git.iko.soy/crush

on main help sign in

chore: small fix

e18a77fKujtim Hoxha1 year ago

internal/tui/exp/list/list.go+3−14

compare with main

unifiedsplit

@@ -746,20 +746,16 @@ func (l *list[T]) GetSize() (int, int) {

746

747// GoToBottom implements List.

748func (l *list[T]) GoToBottom() tea.Cmd {

749− if l.offset != 0 {

750− l.selectedItem = ""

751− }

752 l.offset = 0

749 l.offset = 0

750+ l.selectedItem = ""

753 l.direction = DirectionBackward

751 l.direction = DirectionBackward

754 return l.render()

752 return l.render()

755}

753}

756

754

757// GoToTop implements List.

755// GoToTop implements List.

758func (l *list[T]) GoToTop() tea.Cmd {

756func (l *list[T]) GoToTop() tea.Cmd {

759− if l.offset != 0 {

760− l.selectedItem = ""

761− }

762 l.offset = 0

757 l.offset = 0

758+ l.selectedItem = ""

763 l.direction = DirectionForward

759 l.direction = DirectionForward

764 return l.render()

760 return l.render()

765}

761}

@@ -996,14 +992,7 @@ func (l *list[T]) UpdateItem(id string, item T) tea.Cmd {

996 if hasOldItem && l.direction == DirectionBackward {

992 if hasOldItem && l.direction == DirectionBackward {

997 // if we are the last item and there is no offset

993 // if we are the last item and there is no offset

998 // make sure to go to the bottom

994 // make sure to go to the bottom

999− if inx == l.items.Len()-1 && l.offset == 0 {

1000− cmd = l.GoToBottom()

1001− if cmd != nil {

1002− cmds = append(cmds, cmd)

1003− }

1004−

1005− // if the item is at least partially below the viewport

1006− } else if oldPosition < oldItem.end {

995+ if oldPosition < oldItem.end {

1007 newItem, ok := l.renderedItems.Get(item.ID())

996 newItem, ok := l.renderedItems.Get(item.ID())

1008 if ok {

997 if ok {

1009 newLines := newItem.height - oldItem.height

998 newLines := newItem.height - oldItem.height

internal/tui/exp/list/testdata/TestListMovement/should_not_change_offset_when_new_items_are_appended_and_we_are_at_the_bottom_in_backwards_list.golden+10−10

@@ -1,10 +1,10 @@

1−[38;2;223;219;221m│Item 29[m

1+[38;2;223;219;221mItem 29[m

2−[38;2;223;219;221m│Item 29[m

2+[38;2;223;219;221mItem 29[m

3−[38;2;223;219;221m│Item 29[m

3+[38;2;223;219;221mItem 29[m

4−[38;2;223;219;221m│Item 29[m

4+[38;2;223;219;221mItem 29[m

5−[38;2;223;219;221m│Item 29[m

5+[38;2;223;219;221mItem 29[m

6−[38;2;223;219;221m│Item 29[m

6+[38;2;223;219;221mItem 29[m

7−[38;2;223;219;221m│Item 29[m

7+[38;2;223;219;221mItem 29[m

8−[38;2;223;219;221m│Item 29[m

8+[38;2;223;219;221mItem 29[m

9−[38;2;223;219;221m│Item 29[m

9+[38;2;223;219;221mItem 29[m

10−[38;2;223;219;221mTesting [m

10+[38;2;223;219;221m│Testing [m

internal/tui/exp/list/testdata/TestListMovement/should_not_change_offset_when_new_items_are_prepended_and_we_are_at_the_top_in_forward_list.golden+2−2

@@ -1,5 +1,5 @@

1−[38;2;223;219;221mTesting [m

1+[38;2;223;219;221m│Testing [m

2−[38;2;223;219;221m│Item 0[m

2+[38;2;223;219;221mItem 0[m

3[38;2;223;219;221mItem 1[m

4[38;2;223;219;221mItem 1[m

5[38;2;223;219;221mItem 2[m