on main help sign in
chore: run `modernize` (#906)
commite2e99af1446e4f6a243dc1550da25c4baeac8c6e authorAndrey Nering <andreynering@users.noreply.github.com> dateWed 27 Aug 2025, 14:37 (1 year ago) parent40599a0
4 files changed+10−21
internal/app/app.go+2−4 internal/app/lsp_events.go+2−5 internal/csync/slices.go+2−4 internal/permission/permission_test.go+4−8
internal/app/app.go+2−4
@@ -235,9 +235,7 @@ func setupSubscriber[T any](
235235 subscriber func(context.Context) <-chan pubsub.Event[T],
236236 outputCh chan<- tea.Msg,
237237) {
238− wg.Add(1)
239− go func() {
240− defer wg.Done()
238+ wg.Go(func() {
241239 subCh := subscriber(ctx)
242240 for {
243241 select {
@@ -260,7 +258,7 @@ func setupSubscriber[T any](
260258 return
261259 }
262260 }
263− }()
261+ })
264262}
265263
266264func (app *App) InitCoderAgent() error {
internal/app/lsp_events.go+2−5
@@ -2,6 +2,7 @@ package app
22
33import (
44 "context"
5+ "maps"
56 "time"
67
78 "github.com/charmbracelet/crush/internal/csync"
@@ -48,11 +49,7 @@ func SubscribeLSPEvents(ctx context.Context) <-chan pubsub.Event[LSPEvent] {
4849
4950// GetLSPStates returns the current state of all LSP clients
5051func GetLSPStates() map[string]LSPClientInfo {
51− states := make(map[string]LSPClientInfo)
52− for name, info := range lspStates.Seq2() {
53− states[name] = info
54− }
55− return states
52+ return maps.Collect(lspStates.Seq2())
5653}
5754
5855// GetLSPState returns the state of a specific LSP client
internal/csync/slices.go+2−4
@@ -16,11 +16,9 @@ type LazySlice[K any] struct {
1616// to populate it.
1717func NewLazySlice[K any](load func() []K) *LazySlice[K] {
1818 s := &LazySlice[K]{}
19− s.wg.Add(1)
20− go func() {
19+ s.wg.Go(func() {
2120 s.inner = load()
22− s.wg.Done()
23− }()
21+ })
2422 return s
2523}
2624
internal/permission/permission_test.go+4−8
@@ -154,12 +154,10 @@ func TestPermissionService_SequentialProperties(t *testing.T) {
154154 events := service.Subscribe(t.Context())
155155 var result1 bool
156156 var wg sync.WaitGroup
157− wg.Add(1)
158157
159− go func() {
160− defer wg.Done()
158+ wg.Go(func() {
161159 result1 = service.Request(req)
162− }()
160+ })
163161
164162 var permissionReq PermissionRequest
165163 event := <-events
@@ -170,12 +168,10 @@ func TestPermissionService_SequentialProperties(t *testing.T) {
170168 assert.True(t, result1, "First request should be granted")
171169
172170 var result2 bool
173− wg.Add(1)
174171
175− go func() {
176− defer wg.Done()
172+ wg.Go(func() {
177173 result2 = service.Request(req)
178− }()
174+ })
179175
180176 event = <-events
181177 permissionReq = event.Payload