git.iko.soy/crush
on main help sign in
perf(shell): reduce allocations in updateShellFromRunner (#1817)
e4400adCarlos Alexandro Becker
internal/shell/shell.go+5−3
compare with main
unifiedsplit
@@ -247,12 +247,14 @@ func (s *Shell) newInterp(stdout, stderr io.Writer) (*interp.Runner, error) {
247 )
247 )
248}
248}
249
249
250−// updateShellFromRunner updates the shell from the interpreter after execution
250+// updateShellFromRunner updates the shell from the interpreter after execution.
251func (s *Shell) updateShellFromRunner(runner *interp.Runner) {
251func (s *Shell) updateShellFromRunner(runner *interp.Runner) {
252 s.cwd = runner.Dir
252 s.cwd = runner.Dir
253− s.env = nil
253+ s.env = s.env[:0]
254 for name, vr := range runner.Vars {
254 for name, vr := range runner.Vars {
255+ if vr.Exported {
255− s.env = append(s.env, fmt.Sprintf("%s=%s", name, vr.Str))
256+ s.env = append(s.env, name+"="+vr.Str)
257+ }
256 }
258 }
257}
259}
258
260