git.iko.soy/crush
on main help sign in
chore(ui): standardize dialog identifiers
commited7ef782eae8e202e606c09e1aecf9635dea9eae authorAyman Bagabas <ayman.bagabas@gmail.com> dateMon 15 Dec 2025, 15:50 (1 year ago) parent039f744
3 files changed+10−10
compare with main
unifiedsplit
internal/ui/dialog/quit.go+3−3 internal/ui/dialog/sessions.go+3−3 internal/ui/model/ui.go+4−4
internal/ui/dialog/quit.go+3−3
@@ -7,8 +7,8 @@ import (
77 "github.com/charmbracelet/crush/internal/ui/common"
88)
99
10−// QuitDialogID is the identifier for the quit dialog.
11−const QuitDialogID = "quit"
10+// QuitID is the identifier for the quit dialog.
11+const QuitID = "quit"
1212
1313// Quit represents a confirmation dialog for quitting the application.
1414type Quit struct {
@@ -56,7 +56,7 @@ func NewQuit(com *common.Common) *Quit {
5656
5757// ID implements [Model].
5858func (*Quit) ID() string {
59− return QuitDialogID
59+ return QuitID
6060}
6161
6262// Update implements [Model].
internal/ui/dialog/sessions.go+3−3
@@ -13,8 +13,8 @@ import (
1313 "github.com/charmbracelet/crush/internal/ui/list"
1414)
1515
16−// SessionDialogID is the identifier for the session selector dialog.
17−const SessionDialogID = "session"
16+// SessionsID is the identifier for the session selector dialog.
17+const SessionsID = "session"
1818
1919// Session is a session selector dialog.
2020type Session struct {
@@ -96,7 +96,7 @@ func (s *Session) SelectedItem() list.Item {
9696
9797// ID implements Dialog.
9898func (s *Session) ID() string {
99− return SessionDialogID
99+ return SessionsID
100100}
101101
102102// Update implements Dialog.
internal/ui/model/ui.go+4−4
@@ -193,7 +193,7 @@ func (m *UI) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
193193 sessions.SetSize(min(120, m.width-8), 30)
194194 m.dialog.AddDialog(sessions)
195195 case dialog.SessionSelectedMsg:
196− m.dialog.RemoveDialog(dialog.SessionDialogID)
196+ m.dialog.RemoveDialog(dialog.SessionsID)
197197 cmds = append(cmds,
198198 m.loadSession(msg.Session.ID),
199199 m.loadSessionFiles(msg.Session.ID),
@@ -347,7 +347,7 @@ func (m *UI) handleKeyPressMsg(msg tea.KeyPressMsg) (cmds []tea.Cmd) {
347347 handleQuitKeys := func(msg tea.KeyPressMsg) bool {
348348 switch {
349349 case key.Matches(msg, m.keyMap.Quit):
350− if !m.dialog.ContainsDialog(dialog.QuitDialogID) {
350+ if !m.dialog.ContainsDialog(dialog.QuitID) {
351351 m.dialog.AddDialog(dialog.NewQuit(m.com))
352352 return true
353353 }
@@ -370,9 +370,9 @@ func (m *UI) handleKeyPressMsg(msg tea.KeyPressMsg) (cmds []tea.Cmd) {
370370 case key.Matches(msg, m.keyMap.Models):
371371 // TODO: Implement me
372372 case key.Matches(msg, m.keyMap.Sessions):
373− if m.dialog.ContainsDialog(dialog.SessionDialogID) {
373+ if m.dialog.ContainsDialog(dialog.SessionsID) {
374374 // Bring to front
375− m.dialog.BringToFront(dialog.SessionDialogID)
375+ m.dialog.BringToFront(dialog.SessionsID)
376376 } else {
377377 cmds = append(cmds, m.loadSessionsCmd)
378378 }