on master help sign in
18 files changed+575−122
since splitsnapshots
unifiedsplit
.github/workflows/release.yml+23−8 host/diagonal-host.py+49−30 host/tests/golden/labels.json+102 host/tests/test_host.py+56 host/tests/test_prompts_validate.py+7−7 host/validate.py+92−14 scripts/install-manifest.sh+11−2 src/background/host.ts+3 src/background/index.ts+26−10 src/background/naming.ts+75−23 src/background/organize.ts+11−3 src/background/state.ts+1 src/shared/health.ts+4−2 src/shared/label.ts+35−9 test/auto.test.ts+1 test/naming.test.ts+72−2 test/url.test.ts+6−12 tsconfig.json+1
.github/workflows/release.yml+23−8
@@ -9,8 +9,11 @@ on:
99permissions:
1010 contents: write
1111
12+# One release at a time, in push order: an older run finishing last must not become the latest release,
13+# which is what the Homebrew cask downloads.
1214concurrency:
13− group: release-${{ github.sha }}
15+ group: release
16+ cancel-in-progress: false
1417
1518jobs:
1619 release:
@@ -32,8 +35,23 @@ jobs:
3235
3336 - name: Version from commit time
3437 id: version
38+ env:
39+ GH_TOKEN: ${{ github.token }}
3540 run: |
36− version=$(TZ=UTC git log -1 --format=%cd --date=format-local:%Y.%m.%d.%H%M "$GITHUB_SHA")
41+ # The commit's minute, or the next free minute when another commit already released in it. A re-run
42+ # for a commit that already released publishes nothing: a rebuilt zip has new bytes, which would
43+ # break the sha256 the tap already has, and users on that version would never get the new one.
44+ t=$(git log -1 --format=%ct "$GITHUB_SHA")
45+ for _ in $(seq 1 30); do
46+ version=$(date -u -d "@$t" +%Y.%m.%d.%H%M)
47+ target=$(gh release view "$version" --json targetCommitish -q .targetCommitish 2>/dev/null || true)
48+ [ -z "$target" ] && break
49+ if [ "$target" = "$GITHUB_SHA" ]; then
50+ echo "published=true" >> "$GITHUB_OUTPUT"
51+ break
52+ fi
53+ t=$((t + 60))
54+ done
3755 echo "version=$version" >> "$GITHUB_OUTPUT"
3856 echo "Version $version"
3957
@@ -54,22 +72,19 @@ jobs:
5472 npm run zip:store
5573
5674 - name: Publish release
75+ if: steps.version.outputs.published != 'true'
5776 env:
5877 GH_TOKEN: ${{ github.token }}
5978 VERSION: ${{ steps.version.outputs.version }}
6079 run: |
6180 asset="diagonal-extension-${VERSION}.zip"
6281 notes="Built from ${GITHUB_SHA::7}. Install with: brew install iko-soy/tap/diagonal. Or by hand: unzip, load the folder at brave://extensions (Developer mode → Load unpacked), then install the native host once from Terminal: bash <that folder>/install-host.command"
63− if gh release view "$VERSION" >/dev/null 2>&1; then
64− # Two commits in the same minute share a version: refresh the asset on the existing release.
65− gh release upload "$VERSION" "$asset" diagonal-extension.zip diagonal-store.zip --clobber
66− else
67− gh release create "$VERSION" "$asset" diagonal-extension.zip diagonal-store.zip --target "$GITHUB_SHA" --title "Diagonal $VERSION" --notes "$notes" --latest
68− fi
82+ gh release create "$VERSION" "$asset" diagonal-extension.zip diagonal-store.zip --target "$GITHUB_SHA" --title "Diagonal $VERSION" --notes "$notes" --latest
6983
7084 # Uploads the release to the Chrome Web Store and submits it for review, once the listing exists and
7185 # its API credentials are set as repository secrets (docs/store/listing.md). Skipped until then.
7286 - name: Upload to the Chrome Web Store
87+ if: steps.version.outputs.published != 'true'
7388 env:
7489 CWS_EXTENSION_ID: ${{ secrets.CWS_EXTENSION_ID }}
7590 CWS_CLIENT_ID: ${{ secrets.CWS_CLIENT_ID }}
host/diagonal-host.py+49−30
@@ -206,7 +206,7 @@ def count_tokens(prompt):
206206 """fm's exact count (under 0.1 s), or None when it can't give one."""
207207 try:
208208 p = subprocess.run([FM, "count-tokens", "-q", "-i", prompt.instructions], input=prompt.text,
209− capture_output=True, text=True, timeout=10, env=fm_env())
209+ capture_output=True, text=True, encoding="utf-8", errors="replace", timeout=10, env=fm_env())
210210 except (OSError, subprocess.TimeoutExpired):
211211 return None
212212 out = p.stdout.strip()
@@ -255,28 +255,41 @@ PERMISSIVE = ["--guardrails", "permissive-content-transformations"]
255255USAGE_EXIT = 64
256256
257257
258−def run_fm(prompt, schema, model, timeout_s):
259− """`prompt` is a prompts.Prompt: its fixed rules go to -i, the tab text on stdin."""
258+# Below this much time left in a request, a second fm call (the permissive retry, naming one more new
259+# group) is not started: it would only be cut off.
260+MIN_CALL_S = 5.0
261+
262+
263+def run_fm(prompt, schema, opts):
264+ """`prompt` is a prompts.Prompt: its fixed rules go to -i, the tab text on stdin. Every call in one
265+ request shares its deadline, so the extension's guard (its timeout plus 10 s) is a real upper bound."""
260266 try:
261− return _run_fm(prompt, schema, model, timeout_s, [])
267+ return _run_fm(prompt, schema, opts, [])
262268 except Fail as f:
263− if f.code != "GUARDRAIL":
269+ if f.code != "GUARDRAIL" or time_left(opts) < MIN_CALL_S:
264270 raise
265− return _run_fm(prompt, schema, model, timeout_s, PERMISSIVE)
271+ return _run_fm(prompt, schema, opts, PERMISSIVE)
272+
273+
274+def time_left(opts):
275+ return opts["deadline"] - time.time()
266276
267277
268−def _run_fm(prompt, schema, model, timeout_s, extra):
278+def _run_fm(prompt, schema, opts, extra):
269279 # The tab text goes on stdin (fm reads it there when no prompt argument is given), so it never shows up
270280 # in the process list. fm has no timeout of its own; subprocess enforces ours.
271281 # --greedy: the same tabs get the same topics and name on every run (measured on macOS 27: five runs,
272− # one answer), so groups don't get renamed or reshuffled each time Diagonal looks at them.
273− args = [FM, "respond", "--model", model, "--no-stream", "--greedy", "--schema", schema, "-i", prompt.instructions, *extra]
282+ # one answer), so groups don't get renamed or reshuffled each time Diagonal looks at them. The strict
283+ # retry after an unusable answer samples instead: greedy would give the same answer again.
284+ greedy = [] if opts.get("strict") else ["--greedy"]
285+ args = [FM, "respond", "--model", opts["model"], "--no-stream", *greedy, "--schema", schema, "-i", prompt.instructions, *extra]
286+ timeout_s = max(1.0, time_left(opts))
274287 try:
275− p = subprocess.run(args, input=prompt.text, capture_output=True, text=True, timeout=timeout_s, env=fm_env())
288+ p = subprocess.run(args, input=prompt.text, capture_output=True, text=True, encoding="utf-8", errors="replace", timeout=timeout_s, env=fm_env())
276289 except FileNotFoundError:
277290 raise Fail("MODEL_UNAVAILABLE", f"fm not found at {FM} — requires macOS 27")
278291 except subprocess.TimeoutExpired:
279− raise Fail("TIMEOUT", f"fm exceeded {timeout_s:g}s", retryable=True)
292+ raise Fail("TIMEOUT", f"fm exceeded {opts['timeout_s']:g}s", retryable=True)
280293 if p.returncode != 0:
281294 code = classify(p.stderr, p.returncode)
282295 if code == "LICENSE_REQUIRED":
@@ -295,11 +308,11 @@ def organize_mode():
295308
296309def op_ping(_payload, _opts):
297310 if not os.path.exists(FM):
298− return {"hostVersion": HOST_VERSION, "fmPath": FM, "fmAvailable": False,
311+ return {"hostVersion": HOST_VERSION, "fmPath": FM, "fmAvailable": False, "licenseRequired": False,
299312 "fmMessage": f"fm not found at {FM} — requires macOS 27", "schemasOk": False, "organizeMode": organize_mode()}
300313 license_required = False
301314 try:
302− avail = subprocess.run([FM, "available", "--model", "system"], capture_output=True, text=True, timeout=15, env=fm_env())
315+ avail = subprocess.run([FM, "available", "--model", "system"], capture_output=True, text=True, encoding="utf-8", errors="replace", timeout=15, env=fm_env())
303316 ok, msg = avail.returncode == 0, (avail.stdout + avail.stderr).strip()[:300]
304317 if not ok and license_needed(avail.returncode, avail.stdout + avail.stderr):
305318 license_required, msg = True, LICENSE_MESSAGE
@@ -367,7 +380,7 @@ def op_name(payload, opts):
367380 raise Fail("SCHEMA_MISSING", f"fm could not write {os.path.join(SCHEMAS, 'name.json')}")
368381 prompt = fit(lambda cap: prompts.build_name_prompt(payload, strict=opts.get("strict", False), desc_cap=cap), len(payload["items"]))
369382 try:
370− out = run_fm(prompt, schema, opts["model"], opts["timeout_s"])
383+ out = run_fm(prompt, schema, opts)
371384 except Fail as f:
372385 raise _fit_overflow(f, len(payload["items"]))
373386 try:
@@ -383,7 +396,7 @@ def op_organize(payload, opts):
383396 raise Fail("SCHEMA_MISSING", f"fm could not write {os.path.join(SCHEMAS, 'topics.json')}")
384397 prompt = fit(lambda cap: prompts.build_topics_prompt(payload, strict=opts.get("strict", False), desc_cap=cap), len(payload["items"]))
385398 try:
386− out = run_fm(prompt, schema, opts["model"], opts["timeout_s"])
399+ out = run_fm(prompt, schema, opts)
387400 except Fail as f:
388401 raise _fit_overflow(f, len(payload["items"]))
389402 _, owner = prompts.topic_items(payload)
@@ -393,29 +406,31 @@ def op_organize(payload, opts):
393406 raise Fail("BAD_MODEL_OUTPUT", str(e), retryable=True, raw=json.dumps(out, ensure_ascii=False)[:2000])
394407 chars = prompts.size(prompt)
395408 if payload.get("nameGroups") is not False: # the extension's fit check only needs the topics
396− chars += name_new_groups(result, payload, opts, time.time() + opts["timeout_s"])
409+ chars += name_new_groups(result, payload, opts)
397410 return result, chars, "topics"
398411
399412
400−def name_new_groups(result, payload, opts, deadline):
413+def name_new_groups(result, payload, opts):
401414 """Title each new group with the name op (well under a second each on fm), so groups appear named.
402− A group that fails, or runs past the deadline, keeps "" and the extension's naming loop names it."""
403− taken = [g.get("title") for g in payload.get("existingGroups") or [] if g.get("title")]
415+ A group that fails, runs past the request's deadline, or gets a title another group in the window
416+ already has keeps "" and the extension's naming loop, which checks every sibling, names it."""
417+ taken = [t for t in [g.get("title") for g in payload.get("existingGroups") or []] + list(payload.get("siblingTitles") or []) if t]
404418 chars = 0
405419 for g in result["groups"]:
406420 if "existing" in g or g.get("title"):
407421 continue
408− left = deadline - time.time()
409− if left < 5:
422+ if time_left(opts) < MIN_CALL_S:
410423 break
411424 sub = {"items": [dict(payload["items"][i], i=n) for n, i in enumerate(g["members"])], "siblingTitles": taken[:20]}
412425 try:
413− named, n, _ = op_name(sub, {**opts, "timeout_s": min(opts["timeout_s"], left)})
426+ named, n, _ = op_name(sub, {**opts, "strict": False})
414427 except Fail:
415428 continue
429+ chars += n
430+ if any(validate.same_label(named["title"], t) for t in taken):
431+ continue
416432 g["title"], g["emoji"] = named["title"], named["emoji"]
417433 taken.append(named["title"])
418− chars += n
419434 return chars
420435
421436
@@ -429,8 +444,8 @@ def handle(req):
429444 raw_opts = req.get("opts") or {}
430445 timeout_ms = raw_opts.get("timeoutMs", 45000)
431446 timeout_ms = timeout_ms if isinstance(timeout_ms, (int, float)) and not isinstance(timeout_ms, bool) else 45000
432− opts = {"model": "system", "strict": bool(raw_opts.get("strict")),
433− "timeout_s": max(5.0, min(120.0, timeout_ms / 1000))}
447+ timeout_s = max(5.0, min(120.0, timeout_ms / 1000))
448+ opts = {"model": "system", "strict": bool(raw_opts.get("strict")), "timeout_s": timeout_s, "deadline": t0 + timeout_s}
434449 op = req["op"]
435450 if op == "ping":
436451 return {"v": 1, "id": rid, "ok": True, "result": op_ping(req["payload"], opts)}
@@ -484,7 +499,7 @@ def install_schemas():
484499 if "{%s}" % key not in args:
485500 continue
486501 try:
487− p = subprocess.run([FM, *sub_args], capture_output=True, text=True, timeout=30, env=fm_env())
502+ p = subprocess.run([FM, *sub_args], capture_output=True, text=True, encoding="utf-8", errors="replace", timeout=30, env=fm_env())
488503 except (FileNotFoundError, subprocess.TimeoutExpired) as e:
489504 print(f" {name}: fm failed ({e})", file=sys.stderr)
490505 return "error"
@@ -496,7 +511,7 @@ def install_schemas():
496511 subs["{%s}" % key] = p.stdout.strip()
497512 args = [subs.get(a, a) for a in args]
498513 try:
499− p = subprocess.run([FM, *args], capture_output=True, text=True, timeout=30, env=fm_env())
514+ p = subprocess.run([FM, *args], capture_output=True, text=True, encoding="utf-8", errors="replace", timeout=30, env=fm_env())
500515 except (FileNotFoundError, subprocess.TimeoutExpired) as e:
501516 print(f" {name}: fm failed ({e})", file=sys.stderr)
502517 return "error"
@@ -553,14 +568,16 @@ def selftest():
553568
554569 ping = op_ping({}, {})
555570 check("fm found", os.path.exists(FM), FM)
556− if ping["licenseRequired"]:
571+ if not os.path.exists(FM):
572+ return 1 # nothing else can work without it
573+ if ping.get("licenseRequired"):
557574 check("fm terms accepted", False, f"run: {LICENSE_FIX}")
558575 else:
559576 check("model available (fm available --model system)", ping["fmAvailable"], ping["fmMessage"])
560577 for name in SCHEMA_COMMANDS:
561578 path = os.path.join(SCHEMAS, name)
562579 readable = os.path.isfile(path) and os.path.getsize(path) > 0
563− hint = f"written on their own after {LICENSE_FIX}" if ping["licenseRequired"] else "missing: run diagonal-host --install-schemas"
580+ hint = f"written on their own after {LICENSE_FIX}" if ping.get("licenseRequired") else "missing: run diagonal-host --install-schemas"
564581 check(f"schema {name}", readable, path if readable else hint)
565582 check("allowed origin pinned", "<" not in ALLOWED_ORIGIN, ALLOWED_ORIGIN)
566583 if ping["fmAvailable"] and schema_path("name.json"):
@@ -670,7 +687,9 @@ def register(host_path):
670687 f.write("\n".join(written) + "\n")
671688 except OSError:
672689 pass
673− return 1 if failures else 0
690+ # One browser that could not be written (a locked folder, a stale profile) does not undo the others:
691+ # the install goes on and the ones that failed were named above.
692+ return 0 if len(dirs) - failures > 0 else 1
674693
675694
676695def unregister():
host/tests/golden/labels.jsonnew file+102
@@ -0,0 +1,102 @@
1+[
2+ [
3+ "\"Rust async runtimes.\"",
4+ "Rust async runtimes"
5+ ],
6+ [
7+ "rust async runtimes",
8+ "Rust async runtimes"
9+ ],
10+ [
11+ "Rust tabs and docs",
12+ "Rust and docs"
13+ ],
14+ [
15+ "One two three four five six",
16+ "One two three four"
17+ ],
18+ [
19+ "Machine learning research papers reading list",
20+ "Machine learning research"
21+ ],
22+ [
23+ "iPhone camera tips",
24+ "iPhone camera tips"
25+ ],
26+ [
27+ "macOS updates",
28+ "macOS updates"
29+ ],
30+ [
31+ "Children's books",
32+ "Children's books"
33+ ],
34+ [
35+ "'Quoted' title words",
36+ "Quoted title words"
37+ ],
38+ [
39+ "Planning a trip to Japan",
40+ "Planning a trip"
41+ ],
42+ [
43+ "Recipes for",
44+ null
45+ ],
46+ [
47+ "Python教程",
48+ "Python教程"
49+ ],
50+ [
51+ "React 教程",
52+ "React 教程"
53+ ],
54+ [
55+ "日本旅行",
56+ "日本旅行"
57+ ],
58+ [
59+ "京都の旅行計画",
60+ "京都の旅行計画"
61+ ],
62+ [
63+ "日本旅行。",
64+ "日本旅行"
65+ ],
66+ [
67+ "这是一个非常非常非常非常非常长的标题名字",
68+ "这是一个非常非常非常非常非常长的"
69+ ],
70+ [
71+ "Kubernetes 集群部署与运维指南 最佳实践",
72+ "Kubernetes 集群部署与运维指南"
73+ ],
74+ [
75+ "ทริปญี่ปุ่น",
76+ "ทริปญี่ปุ่น"
77+ ],
78+ [
79+ "日",
80+ null
81+ ],
82+ [
83+ "Tabs",
84+ null
85+ ],
86+ [
87+ "Misc stuff",
88+ null
89+ ],
90+ [
91+ "",
92+ null
93+ ],
94+ [
95+ "x",
96+ null
97+ ],
98+ [
99+ "Supercalifragilisticexpialidocious extraordinarily",
100+ null
101+ ]
102+]
host/tests/test_host.py+56
@@ -287,6 +287,19 @@ class ErrorCodes(HostCase):
287287 self.assertIn("Reply with only the object", argv[argv.index("-i") + 1])
288288
289289
290+ def test_strict_retry_samples_instead_of_repeating_the_greedy_answer(self):
291+ self.respond(json.dumps({"title": "Rust async", "emoji": "🦀"}))
292+ self.call("name", {"items": ITEMS3}, strict=True)
293+ self.assertNotIn("--greedy", [a for a in self.argv_log() if a[0] == "respond"][0])
294+
295+ def test_permissive_retry_shares_the_request_deadline(self):
296+ # The first call uses up the request's time: no second call runs past what the extension waits for.
297+ self.control({"respond_queue": [{"stderr": "Error: The model's safety guardrails were triggered.\n", "exit": 1, "sleep": 2.5}]})
298+ r = self.call("name", {"items": ITEMS3}, timeoutMs=5000)
299+ self.assertEqual(r["error"]["code"], "GUARDRAIL")
300+ self.assertEqual(len([a for a in self.argv_log() if a[0] == "respond"]), 1)
301+
302+
290303class Organize(HostCase):
291304 ITEMS = ITEMS3 + [
292305 {"title": "Hotels in Lisbon", "url": "https://booking.com/lisbon"},
@@ -331,6 +344,33 @@ class Organize(HostCase):
331344 self.assertIn("Tokio", name_calls[0])
332345 self.assertIn('"Lisbon trip"', name_calls[0]) # existing titles are off limits
333346
347+ def test_a_new_group_named_like_another_group_is_left_to_the_naming_loop(self):
348+ self.control({"respond_queue": [
349+ {"stdout": json.dumps({"tabs": [{"index": i, "topic": "Programming"} for i in (0, 1, 2)]})},
350+ {"stdout": json.dumps({"title": "Rust async", "emoji": "🦀"})},
351+ ]})
352+ r = self.call("organize", {"items": self.ITEMS, "siblingTitles": ["rust async"]})
353+ self.assertEqual(r["result"]["groups"][0]["title"], "")
354+ self.assertIn('"rust async"', self.stdin_log()[1]) # the name call was told, too
355+
356+ def test_a_topic_two_groups_share_equally_joins_neither_unless_the_words_say_which(self):
357+ existing = [{"g": 0, "title": "Lisbon trip", "samples": ["Flights to Lisbon"]},
358+ {"g": 1, "title": "Porto trip", "samples": ["Porto restaurants"]}]
359+ # Examples 8 (group 0) and 9 (group 1) both got Travel: a tie.
360+ self.topics([(3, "Travel"), (4, "Travel"), (8, "Travel"), (9, "Travel")])
361+ r = self.call("organize", {"items": self.ITEMS, "existingGroups": existing})
362+ self.assertEqual([g.get("existing") for g in r["result"]["groups"]], [0]) # "Lisbon" is in both tabs' titles
363+ items = [{"title": "Beach day", "url": "https://a.example/"}, {"title": "City walk", "url": "https://b.example/"}]
364+ self.topics([(0, "Travel"), (1, "Travel"), (2, "Travel"), (3, "Travel")])
365+ r = self.call("organize", {"items": items, "existingGroups": existing})
366+ self.assertNotIn("existing", r["result"]["groups"][0])
367+
368+ def test_only_vague_topics_leave_every_tab_loose(self):
369+ self.topics([(0, "Other"), (1, "Misc"), (2, "General")])
370+ r = self.call("organize", {"items": ITEMS3})
371+ self.assertTrue(r["ok"], r)
372+ self.assertEqual(r["result"], {"groups": [], "leftovers": [0, 1, 2]})
373+
334374 def test_two_topics_joining_one_group_make_one_join(self):
335375 # The group's two example tabs (8 and 9) got different topics; both topics still join group 0 once.
336376 self.topics([(3, "Travel"), (4, "Hotels"), (8, "Travel"), (9, "Hotels"), (0, "Programming")])
@@ -487,6 +527,15 @@ class Register(HostCase):
487527 self.assertEqual(p.returncode, 1)
488528 self.assertIn("missing or not executable", p.stderr)
489529
530+ def test_one_browser_that_cannot_be_written_does_not_fail_the_rest(self):
531+ chrome = self.make_profile("Google/Chrome")
532+ brave = self.make_profile("BraveSoftware/Brave-Browser")
533+ open(os.path.join(brave, "NativeMessagingHosts"), "w").close() # a file where the folder should be
534+ p = self.run_copy("--register", self.host_copy)
535+ self.assertEqual(p.returncode, 0, p.stderr)
536+ self.assertIn("BraveSoftware/Brave-Browser: could not write", p.stderr)
537+ self.assertTrue(os.path.exists(os.path.join(chrome, "NativeMessagingHosts", "io.diagonal.host.json")))
538+
490539 def test_no_browser_found(self):
491540 os.makedirs(self.env["DIAGONAL_APP_SUPPORT"])
492541 p = self.run_copy("--register", self.host_copy)
@@ -508,6 +557,13 @@ class SelfTest(HostCase):
508557 self.assertEqual(code, 1)
509558 self.assertIn("FAIL model available", p.stdout.decode())
510559
560+ def test_selftest_without_fm_says_so_and_stops(self):
561+ self.env["DIAGONAL_FM"] = os.path.join(self.tmp, "no-such-fm")
562+ code, _, p = self.run_host(args=["--selftest"])
563+ self.assertEqual(code, 1)
564+ self.assertIn("FAIL fm found", p.stdout.decode())
565+ self.assertNotIn("Traceback", p.stderr.decode())
566+
511567 def test_selftest_names_the_license_fix(self):
512568 self.control({"license": True})
513569 code, _, p = self.run_host(args=["--selftest"])
host/tests/test_prompts_validate.py+7−7
@@ -1,3 +1,4 @@
1+import json
12import os
23import unittest
34
@@ -73,13 +74,12 @@ class ValidateName(unittest.TestCase):
7374 with self.assertRaises(validate.ValidationError, msg=bad):
7475 self.v(bad)
7576
76− def test_chinese_and_japanese_titles_need_no_spaces(self):
77− self.assertEqual(self.v("日本旅行")["title"], "日本旅行")
78− self.assertEqual(self.v("京都の旅行計画")["title"], "京都の旅行計画")
79− self.assertEqual(self.v("React 教程")["title"], "React 教程")
80− for bad in ("日", "这是一个非常非常非常非常非常长的标题名字"):
81− with self.assertRaises(validate.ValidationError, msg=bad):
82− self.v(bad)
77+ def test_same_labels_as_the_extension(self):
78+ # test/url.test.ts runs these cases against src/shared/label.ts.
79+ with open(os.path.join(GOLDEN, "labels.json"), encoding="utf-8") as f:
80+ cases = json.load(f)
81+ for raw, fixed in cases:
82+ self.assertEqual(validate.repair_label(raw), fixed, msg=raw)
8383
8484 def test_emoji_default(self):
8585 self.assertEqual(self.v("Rust async", "not-an-emoji")["emoji"], "🧭")
host/validate.py+92−14
@@ -7,7 +7,6 @@ from urllib.parse import urlsplit
77HERE = os.path.dirname(os.path.realpath(__file__))
88COLORS = ["grey", "blue", "red", "yellow", "green", "pink", "purple", "cyan", "orange"]
99BANNED_WORDS = {"tab", "tabs", "group", "groups", "misc", "various", "stuff"}
10−QUOTES = "\"'“”‘’«»`"
1110TRAILING_PUNCT = re.compile(r"[\s.,;:!?…\-–—。、,!?:;]+$")
1211
1312
@@ -89,39 +88,82 @@ def default_emoji(items):
8988 return CATEGORIES[category_for_host(majority)][0]
9089
9190
91+# Quotes go; an apostrophe between two letters ("Children's", "Rock'n'roll") is part of the word and stays.
92+_QUOTE = re.compile(r"(?<![^\W\d_])['’]|['’](?![^\W\d_])|[\"“”‘«»`]")
93+# A label cut short should not end mid-phrase: "Planning a trip to" reads as "Planning a trip".
94+DANGLING = {"a", "an", "the", "to", "of", "for", "in", "on", "at", "by", "and", "or", "with", "from"}
95+
96+
9297def repair_label(raw):
93− """Trim, drop quotes, banned words and trailing punctuation, cap at 4 words / 28 chars, capitalise."""
98+ """Trim, drop quotes, banned words and trailing punctuation, cap at 4 words / 28 chars (16 wide characters
99+ for no-space scripts), drop a dangling "to"/"of", capitalise. Kept in step with src/shared/label.ts."""
94100 if not isinstance(raw, str):
95101 return None
96− s = raw.translate({ord(q): None for q in QUOTES})
102+ s = _QUOTE.sub("", raw)
97103 s = TRAILING_PUNCT.sub("", " ".join(s.split()))
98104 words = [w for w in s.split(" ") if w and re.sub(r"[^\w]", "", w.lower()) not in BANNED_WORDS]
99105 words = words[:4]
100− while len(words) > 2 and len(" ".join(words)) > 28:
106+ if _no_space(" ".join(words)):
107+ while len(words) > 1 and _width(" ".join(words)) > 16:
108+ words.pop()
109+ if _width(" ".join(words)) > 16:
110+ words = [_cut_to_width(" ".join(words), 16)]
111+ else:
112+ while len(words) > 2 and len(" ".join(words)) > 28:
113+ words.pop()
114+ while len(words) > 1 and words[-1].lower() in DANGLING:
101115 words.pop()
102116 label = TRAILING_PUNCT.sub("", " ".join(words))
103117 if not label:
104118 return None
105− label = label[0].upper() + label[1:]
119+ # "rust async" becomes "Rust async"; "iPhone tips" and "macOS updates" keep the brand's own casing.
120+ if not any(c.isupper() for c in words[0][1:]):
121+ label = label[0].upper() + label[1:]
106122 return label if is_valid_label(label) else None
107123
108124
109−# Chinese and Japanese titles have no spaces between words, so they're checked by length instead.
125+# Chinese, Japanese, Korean, Thai, Lao, Khmer and Myanmar titles don't put spaces between words, so a label
126+# with any of their characters ("Python教程") is checked by width instead of word count. Each such character
127+# is about as wide as two Latin letters on the tab strip.
128+NO_SPACE = re.compile(r"[\u0e00-\u0eff\u1000-\u109f\u1780-\u17ff\u3040-\u30ff\u3400-\u4dbf\u4e00-\u9fff\uac00-\ud7af\uf900-\ufaff]")
129+# Chinese, Japanese and Korean, for the host's token estimate.
110130CJK = re.compile(r"[\u3040-\u30ff\u3400-\u4dbf\u4e00-\u9fff\uac00-\ud7af\uf900-\ufaff]")
111131
112132
133+def _no_space(label):
134+ return bool(NO_SPACE.search(label))
135+
136+
137+def _width(label):
138+ wide = len(NO_SPACE.findall(label))
139+ return wide + (len(label) - wide) / 2
140+
141+
142+def _cut_to_width(label, most):
143+ out = ""
144+ for ch in label:
145+ if _width(out + ch) > most:
146+ break
147+ out += ch
148+ return out.strip()
149+
150+
113151def is_valid_label(label):
114152 words = label.split()
115− cjk = len(CJK.findall(label)) * 2 > len(label.replace(" ", ""))
153+ wide = _no_space(label)
116154 return (
117− (2 <= len(label) <= 16 if cjk else 3 <= len(label) <= 28)
118− and (1 <= len(words) <= 4 if cjk else 2 <= len(words) <= 4)
119− and not any(q in label for q in QUOTES)
155+ (2 <= len(label) <= 28 and _width(label) <= 16 if wide else 3 <= len(label) <= 28)
156+ and (1 <= len(words) <= 4 if wide else 2 <= len(words) <= 4)
157+ and not _QUOTE.search(label)
120158 and not TRAILING_PUNCT.search(label)
121159 and not any(w.lower() in BANNED_WORDS for w in words)
122160 )
123161
124162
163+def same_label(a, b):
164+ return bool(a) and bool(b) and " ".join(a.split()).casefold() == " ".join(b.split()).casefold()
165+
166+
125167def validate_name(out, payload):
126168 if not isinstance(out, dict):
127169 raise ValidationError("reply is not an object")
@@ -227,16 +269,52 @@ def organize_from_topics(out, payload, owner):
227269 votes = group_votes.setdefault(topic, {})
228270 votes[owner[i]] = votes.get(owner[i], 0) + 1
229271 if not tab_topic:
230− raise ValidationError("no tab got a topic")
272+ if not any(isinstance(t, dict) and _in_range(t.get("index"), n_items) for t in out["tabs"]):
273+ raise ValidationError("no tab got a topic")
274+ # Every tab got only a vague topic ("Other", "Misc"): the model found nothing in common.
275+ return validate_organize({"groups": [], "leftovers": []}, payload)
231276 clusters = {}
232277 for i in sorted(tab_topic):
233278 clusters.setdefault(tab_topic[i], []).append(i)
234279 groups = []
235280 for topic, members in clusters.items():
236− votes = group_votes.get(topic)
237− if votes:
238− g = max(sorted(votes), key=lambda k: votes[k])
281+ g = _winner(group_votes.get(topic) or {}, members, payload)
282+ if g is not None:
239283 groups.append({"existing": g, "members": members})
240284 else:
241285 groups.append({"title": "", "emoji": "", "color": "", "members": members})
242286 return validate_organize({"groups": groups, "leftovers": []}, payload)
287+
288+
289+def _in_range(i, n):
290+ return isinstance(i, int) and not isinstance(i, bool) and 0 <= i < n
291+
292+
293+_WORD = re.compile(r"\w{3,}")
294+
295+
296+def _words(text):
297+ return {w.casefold() for w in _WORD.findall(text or "")}
298+
299+
300+def _winner(votes, members, payload):
301+ """The existing group a topic's tabs join: the one whose example tabs share it most. When two groups tie,
302+ the one whose title and examples share more words with these tabs; when that ties too, none (the tabs
303+ form a group of their own, or stay loose), rather than whichever group happens to be listed first."""
304+ if not votes:
305+ return None
306+ top = max(votes.values())
307+ tied = sorted(k for k, v in votes.items() if v == top)
308+ if len(tied) == 1:
309+ return tied[0]
310+ tab_words = set().union(*(_words(payload["items"][i].get("title")) for i in members))
311+ groups = {g["g"]: g for g in payload.get("existingGroups") or []}
312+
313+ def overlap(k):
314+ g = groups.get(k) or {}
315+ return len(tab_words & _words(" ".join([g.get("title") or "", *(g.get("samples") or [])])))
316+
317+ scores = {k: overlap(k) for k in tied}
318+ best = max(scores.values())
319+ leaders = [k for k in tied if scores[k] == best]
320+ return leaders[0] if len(leaders) == 1 and best > 0 else None
scripts/install-manifest.sh+11−2
@@ -53,7 +53,16 @@ echo "host: $BIN -> $SHARE/diagonal-host.py"
5353"$BIN" --version >/dev/null # the host must start with the python3 it was pinned to
5454# Writes the manifest into every Chromium browser's NativeMessagingHosts folder (Chrome, Brave and
5555# Brave Origin, Edge, Vivaldi, Arc, Opera, …) and checks each one the way the browser reads it.
56−"$BIN" --register "$BIN"
56+# A browser that was never opened has no folder yet: the rest of the install still runs, and the end
57+# says how to finish.
58+register_rc=0
59+"$BIN" --register "$BIN" || register_rc=$?
60+register_note() {
61+ if [[ $register_rc -ne 0 ]]; then
62+ echo "No browser could be set up for Diagonal yet. Open your browser once, then run: bash '$HERE/$(basename "$0")'"
63+ fi
64+}
65+trap register_note EXIT
5766
5867FM="${DIAGONAL_FM:-/usr/bin/fm}"
5968
@@ -89,7 +98,7 @@ fi
8998# Diagonal also writes these on first use; doing it now lets the self-test below cover the model.
9099schemas_out=$("$BIN" --install-schemas 2>&1) || true
91100if selftest_out=$("$BIN" --selftest 2>&1); then
92− echo "Diagonal's host is ready."
101+ [[ $register_rc -ne 0 ]] || echo "Diagonal's host is ready."
93102else
94103 echo "Diagonal's host is installed, but its self-test found a problem:"
95104 echo "$schemas_out"
src/background/host.ts+3
@@ -102,6 +102,9 @@ export function normalizeReply<T>(reply: unknown, at: number): HostReply<T> {
102102 };
103103}
104104
105+/** Errors about what one request carried, not about the host: they don't count toward pausing it. */
106+export const REQUEST_ERRORS = new Set<HostErrorCode>(["GUARDRAIL", "BAD_MODEL_OUTPUT", "OVER_BUDGET", "BAD_REQUEST"]);
107+
105108/** Errors that mean "fix the setup", not "try this group again later". */
106109export const SETUP_ERRORS = new Set<HostErrorCode>([
107110 "HOST_NOT_FOUND", "HOST_FORBIDDEN", "FORBIDDEN_ORIGIN", "SCHEMA_MISSING", "MODEL_UNAVAILABLE", "LICENSE_REQUIRED",
src/background/index.ts+26−10
@@ -1,6 +1,6 @@
11import { stripTitle } from "../shared/label";
22import { applyEvent, bury, type Action, type EngineEvent, type GroupSnapshot, type TabSnapshot } from "./engine";
3−import { callHost, chromeSender, explain, HOST_MANIFEST_PATH, SETUP_ERRORS, type HostOpts, type HostReply, type Op } from "./host";
3+import { callHost, chromeSender, explain, HOST_MANIFEST_PATH, REQUEST_ERRORS, SETUP_ERRORS, type HostOpts, type HostReply, type Op } from "./host";
44import { GLOBAL_PAUSE_AFTER, GLOBAL_PAUSE_MS, Naming, RATE_LIMIT_PAUSES_MS, type Member, type NamePayload, type NameResult } from "./naming";
55import { AutoOrganizer, organizeWindow, undoOrganize, UNDO_WINDOW_MS as ORGANIZE_UNDO_MS } from "./organize";
66import { FitChecker } from "./fit";
@@ -93,7 +93,11 @@ async function host<T>(op: Op, payload: object, extra: Partial<HostOpts> = {}):
9393 h.lastOkAt = Date.now();
9494 h.consecutiveFailures = 0;
9595 h.consecutiveTimeouts = 0;
96− h.rateLimitStep = 0;
96+ if (op !== "ping") {
97+ h.rateLimitStep = 0; // a ping doesn't use the model, so it says nothing about its limit
98+ // A model answer (a manual Organize or Name now during a pause) proves the helper works again.
99+ if (h.pausedUntil) recovered();
100+ }
97101 if (reply.meta?.ms !== undefined) void pushRing("latency", reply.meta.ms, 100);
98102 } else {
99103 recordHostError(reply.error);
@@ -107,6 +111,8 @@ async function host<T>(op: Op, payload: object, extra: Partial<HostOpts> = {}):
107111}
108112
109113function recordHostError(e: HostError): void {
114+ // About one request's tabs, not the host's health: the caller retries or sets those tabs aside.
115+ if (REQUEST_ERRORS.has(e.code)) return;
110116 const h = state.host;
111117 const now = Date.now();
112118 h.lastError = { ...e, at: now };
@@ -138,11 +144,7 @@ async function ping(): Promise<HostReply<PingResult>> {
138144 } else if (!reply.result.schemasOk) {
139145 recordHostError({ code: "SCHEMA_MISSING", message: reply.result.schemaMessage || "fm could not write Diagonal's schema files" });
140146 } else {
141− h.pausedUntil = undefined;
142− h.lastError = undefined;
143− chrome.alarms.clear(ALARM_HOST);
144− void naming.sweepDirty();
145− void autoOrganizer.sweep();
147+ recovered();
146148 }
147149 }
148150 commit();
@@ -150,6 +152,16 @@ async function ping(): Promise<HostReply<PingResult>> {
150152 return reply;
151153}
152154
155+/** The helper answers again: lift the pause and pick up what waited for it. */
156+function recovered(): void {
157+ const h = state.host;
158+ h.pausedUntil = undefined;
159+ h.lastError = undefined;
160+ chrome.alarms.clear(ALARM_HOST);
161+ void naming.sweepDirty();
162+ void autoOrganizer.sweep();
163+}
164+
153165// ----- badge -----------------------------------------------------------------------------------
154166
155167function busy(on: boolean): void {
@@ -161,7 +173,6 @@ function hostUnhealthy(): boolean {
161173 const h = state.host;
162174 const now = Date.now();
163175 if (h.pausedUntil && h.pausedUntil > now) return true;
164− if (h.consecutiveFailures >= 3) return true;
165176 return !!h.lastError && SETUP_ERRORS.has(h.lastError.code) && (!h.lastOkAt || h.lastOkAt < (h.lastError.at ?? 0));
166177}
167178
@@ -501,12 +512,14 @@ if (GROUPS_SUPPORTED) {
501512
502513 chrome.tabs.onReplaced.addListener((added, removed) =>
503514 void serial("tabs.onReplaced", async () => {
515+ // Chromium swapped in a new tab (a prerendered page, a discarded tab coming back): it is the same
516+ // tab to the user, so it keeps what Diagonal knew about it, including choices the user made.
504517 const rec = state.tabs[removed];
505518 delete state.tabs[removed];
506519 const t = await tabById(added);
507520 if (t) {
521+ if (rec && !state.tabs[added]) state.tabs[added] = { ...rec, id: added };
508522 await feed({ type: "tabUpdated", tab: snapTab(t) });
509− if (rec?.description && state.tabs[added]) state.tabs[added].description = rec.description;
510523 }
511524 }),
512525 );
@@ -601,9 +614,12 @@ async function rewriteTitles(before: Settings): Promise<void> {
601614async function nameGroupNow(groupId: number): Promise<void> {
602615 const g = state.groups[groupId];
603616 if (!g) return;
604− // An explicit request overrides "don't name" and a hand-typed title for this group.
617+ // An explicit request overrides "don't name" and a hand-typed title for this group, and the model's
618+ // answer goes on the strip even when it is close to the label it gave before.
605619 g.managed = true;
606620 g.userNamed = false;
621+ g.title = undefined;
622+ g.lastNamedAt = undefined;
607623 commit();
608624 await naming.nameNow(groupId);
609625}
src/background/naming.ts+75−23
@@ -1,6 +1,7 @@
11import { labelOf, repairLabel, safeEmoji, sameLabel, stripTitle, titleKey, LABEL_MAX_CHARS } from "../shared/label";
22import { sha1 } from "../shared/sha1";
33import { isInternalUrl, promptUrl, trimText } from "../shared/url";
4+import { pathKey } from "./engine";
45import type { HostOpts, HostReply } from "./host";
56import { SETUP_ERRORS } from "./host";
67import type { Settings } from "./settings";
@@ -113,8 +114,9 @@ export function shouldApply(g: GroupRecord, label: string, urls: string[]): bool
113114 if (g.userNamed) return false;
114115 if (!g.lastNamedAt || !g.title) return true; // first name replaces the provisional hostname
115116 if (sameLabel(label, g.title)) return false;
116− const before = new Set(g.memberUrls ?? []);
117− const after = new Set(urls);
117+ // By page, not by exact address: a tab that moved to ?page=2 or #comments is the same member.
118+ const before = new Set((g.memberUrls ?? []).map(pathKey));
119+ const after = new Set(urls.map(pathKey));
118120 const changed = [...after].some((u) => !before.has(u)) || [...before].some((u) => !after.has(u));
119121 return changed; // a paraphrase with the same members keeps the old title
120122}
@@ -214,18 +216,32 @@ export class Naming {
214216 }
215217 const now = this.d.now();
216218 if (!force) {
217− if (g.nextAttemptAt && g.nextAttemptAt > now) return;
219+ // A refusal waits for the members to change, which only a look at them can tell.
220+ if (g.nextAttemptAt && g.nextAttemptAt > now && !g.refusedHash) return;
218221 if (s.host.pausedUntil && s.host.pausedUntil > now) return;
219222 if (s.inFlight?.groupId === groupId && this.current !== groupId && now - s.inFlight.startedAt < settings.timeoutMs + 5000) return;
220223 }
221224 const members = (await this.d.liveMembers(groupId))?.filter(nameable);
222225 if (!members) return;
223− if (members.length < 2 || !members.every(settled)) return; // stay dirty; the load finishing touches it again
224− if (!force && membersHash(members) === g.membersHash) {
225− g.dirty = false;
226+ if (!members.every(settled)) return; // stay dirty; the load finishing touches it again
227+ if (members.length < 2) {
228+ // Nothing to name from yet. A tab joining or loading a page marks the group dirty again.
229+ if (g.dirty && !force) {
230+ g.dirty = false;
231+ this.d.commit();
232+ }
233+ return;
234+ }
235+ const hash = membersHash(members);
236+ if (!force && hash === g.membersHash) {
237+ settle(g);
226238 this.d.commit();
227239 return;
228240 }
241+ if (g.refusedHash && !force) {
242+ if (hash === g.refusedHash && g.nextAttemptAt && g.nextAttemptAt > now) return;
243+ clearFailures(g); // different tabs now: Apple's filter may well take them
244+ }
229245 if (this.current === groupId && !force) return; // re-queued when the in-flight reply lands
230246 if (!this.queue.some((q) => q.groupId === groupId)) this.queue.push({ groupId, force });
231247 void this.pump();
@@ -261,7 +277,7 @@ export class Naming {
261277 if (!members || members.length < 2 || !members.every(settled)) return;
262278 const hash = membersHash(members);
263279 if (!force && hash === g.membersHash) {
264− g.dirty = false;
280+ settle(g);
265281 this.d.commit();
266282 return;
267283 }
@@ -296,9 +312,10 @@ export class Naming {
296312 }
297313 if (e.code === "BAD_MODEL_OUTPUT" && !retried.output) {
298314 retried.output = true;
315+ mustDifferFrom = withRejected(mustDifferFrom, e.raw);
299316 continue;
300317 }
301− this.fail(g, e);
318+ this.fail(g, e, hash);
302319 return;
303320 }
304321
@@ -307,9 +324,10 @@ export class Naming {
307324 const e: HostError = { code: "BAD_MODEL_OUTPUT", message: "label failed worker validation", raw: JSON.stringify(reply.result).slice(0, 500), at: this.d.now() };
308325 if (!retried.output) {
309326 retried.output = true;
327+ mustDifferFrom = withRejected(mustDifferFrom, e.raw);
310328 continue;
311329 }
312− this.fail(g, e);
330+ this.fail(g, e, hash);
313331 return;
314332 }
315333 const emoji = safeEmoji(reply.result.emoji);
@@ -324,12 +342,15 @@ export class Naming {
324342 finalLabel = suffixLabel(label, siblings);
325343 }
326344 this.d.hostOk();
327− await this.apply(g, finalLabel, emoji, members, hash);
345+ const written = await this.apply(g, finalLabel, emoji, members, hash);
328346 g = this.d.state().groups[groupId];
329− if (g) {
330− if (g.dirtySeq === seq) g.dirty = false;
331− else this.touch(groupId); // dirtied while in flight: go again with the new membership
332− }
347+ if (!g) return;
348+ if (!written) {
349+ // The strip refused the title (a drag in progress, the window closing): try again shortly.
350+ g.nextAttemptAt = this.d.now() + BACKOFF_MS[0];
351+ this.d.scheduleFallback(g.nextAttemptAt);
352+ } else if (g.dirtySeq === seq) g.dirty = false;
353+ else this.touch(groupId); // dirtied while in flight: go again with the new membership
333354 return;
334355 }
335356 } finally {
@@ -340,16 +361,20 @@ export class Naming {
340361 }
341362 }
342363
343− private async apply(g: GroupRecord, label: string, emoji: string, members: Member[], hash: string): Promise<void> {
364+ /** Put the label on the strip if the policy allows; false when the strip would not take the title. */
365+ private async apply(g: GroupRecord, label: string, emoji: string, members: Member[], hash: string): Promise<boolean> {
344366 const settings = this.d.settings();
345367 const urls = memberUrls(members);
346− if (g.userNamed) return; // renamed by hand while the model was thinking
368+ if (g.userNamed) return true; // renamed by hand while the model was thinking
347369 if (shouldApply(g, label, urls)) {
348370 const title = stripTitle(label, emoji, settings.emoji);
349371 this.d.state().ownWrites[g.id] = { title, at: this.d.now() };
350372 this.d.commit();
351373 const ok = await this.d.writeTitle(g.id, title);
352− if (!ok) return;
374+ if (!ok) {
375+ delete this.d.state().ownWrites[g.id];
376+ return false;
377+ }
353378 g.title = label;
354379 g.emoji = emoji;
355380 g.stripTitle = title;
@@ -357,21 +382,24 @@ export class Naming {
357382 g.lastNamedAt = this.d.now();
358383 g.membersHash = hash;
359384 g.memberUrls = urls;
360− g.nameAttempts = 0;
361− g.firstFailureAt = undefined;
362− g.nextAttemptAt = undefined;
385+ clearFailures(g);
386+ return true;
363387 }
364388
365− private fail(g: GroupRecord, e: HostError): void {
389+ private fail(g: GroupRecord, e: HostError, hash: string): void {
366390 const now = this.d.now();
367391 this.d.hostFailed(e);
368392 if (e.code === "BAD_REQUEST") {
369393 g.dirty = false; // a bug on our side: log and drop
370394 return;
371395 }
396+ // Setup errors pause every model call until the host is fixed, and its recovery picks this group up
397+ // again: they say nothing about this group, so they don't use up its retries.
398+ if (SETUP_ERRORS.has(e.code)) return;
372399 if (e.code === "GUARDRAIL") {
373400 g.nameAttempts = MAX_ATTEMPTS;
374401 g.nextAttemptAt = now + GIVE_UP_AFTER_MS;
402+ g.refusedHash = hash;
375403 this.d.scheduleFallback(g.nextAttemptAt);
376404 return;
377405 }
@@ -381,11 +409,35 @@ export class Naming {
381409 g.dirty = false; // retried for a day: keep the provisional title
382410 return;
383411 }
384− const wait = SETUP_ERRORS.has(e.code) ? Math.max(GLOBAL_PAUSE_MS, backoffFor(g.nameAttempts)) : backoffFor(g.nameAttempts);
385− g.nextAttemptAt = now + wait;
412+ g.nextAttemptAt = now + backoffFor(g.nameAttempts);
386413 this.d.scheduleFallback(g.nextAttemptAt);
387414 }
388415}
389416
417+/** The retry after an unusable title lists that title as not allowed, so the model doesn't give it again. */
418+function withRejected(list: string[] | undefined, raw: string | undefined): string[] | undefined {
419+ let title: unknown;
420+ try {
421+ title = raw ? JSON.parse(raw)?.title : undefined;
422+ } catch {
423+ return list;
424+ }
425+ return typeof title === "string" && title.trim() ? [...(list ?? []), title.trim().slice(0, 60)] : list;
426+}
427+
428+/** The retry bookkeeping of earlier failures, which no longer applies. */
429+function clearFailures(g: GroupRecord): void {
430+ g.nameAttempts = 0;
431+ g.firstFailureAt = undefined;
432+ g.nextAttemptAt = undefined;
433+ g.refusedHash = undefined;
434+}
435+
436+/** The members are the ones last named: nothing to do, and nothing left to retry. */
437+function settle(g: GroupRecord): void {
438+ g.dirty = false;
439+ clearFailures(g);
440+}
441+
390442export const eligible = (g: GroupRecord, settings: Settings): boolean =>
391443 settings.naming && g.managed && !g.userNamed && g.origin !== "tidy";
src/background/organize.ts+11−3
@@ -27,6 +27,8 @@ export interface ExistingGroup {
2727export interface OrganizePayload {
2828 items: NameItem[];
2929 existingGroups: ExistingGroup[];
30+ /** Every group label in the window: a new group the host names must not repeat one. */
31+ siblingTitles?: string[];
3032 allowNew: boolean;
3133 maxGroups: number;
3234 minGroupSize: number;
@@ -177,11 +179,17 @@ const CONTENT_ERRORS = new Set<HostErrorCode>(["OVER_BUDGET", "GUARDRAIL", "BAD_
177179const MAX_TIMEOUT_SPLITS = 1;
178180
179181/** One organize call, with the retries that can rescue the same tabs: strict output, then no page text. */
180−async function askOrganize(rt: Runtime, part: Member[], existingGroups: ExistingGroup[], withDescriptions: boolean): Promise<HostReply<OrganizeResult>> {
182+async function askOrganize(rt: Runtime, part: Member[], windowId: number, existingGroups: ExistingGroup[], withDescriptions: boolean): Promise<HostReply<OrganizeResult>> {
181183 const settings = rt.settings();
184+ const s = rt.state();
182185 const payload: OrganizePayload = {
183186 items: toItems(part, settings, withDescriptions),
184187 existingGroups,
188+ siblingTitles: Object.values(s.groups)
189+ .filter((g) => g.windowId === windowId && g.origin !== "tidy")
190+ .map((g) => labelOf(g.stripTitle || g.title))
191+ .filter(Boolean)
192+ .slice(0, 20),
185193 allowNew: part.length >= 2,
186194 maxGroups: maxGroupsFor(part.length),
187195 minGroupSize: settings.organizeMinGroupSize,
@@ -224,7 +232,7 @@ export async function sortPart(rt: Runtime, part: Member[], run: SortRun, probe
224232 run.left += part.length;
225233 return; // one tab and nothing to join: no call can place it (a probe still learns whether the model takes it)
226234 }
227− const reply = await askOrganize(rt, part, existingGroups, true);
235+ const reply = await askOrganize(rt, part, run.windowId, existingGroups, true);
228236 if (!reply.ok) {
229237 const e = reply.error;
230238 const timedOut = e.code === "TIMEOUT" && part.length > 4 && run.timeoutSplits < MAX_TIMEOUT_SPLITS;
@@ -305,7 +313,7 @@ export async function organizeWindow(rt: Runtime, windowId: number): Promise<Org
305313 report.left = tabs.length;
306314 return report;
307315 }
308− const run = newRun(windowId, false);
316+ const run = newRun(windowId, true); // auto-organize need not send the same tabs again right after
309317 rt.state().inFlight = { groupId: -1, startedAt: rt.now() };
310318 rt.refreshBadge();
311319 try {
src/background/state.ts+1
@@ -47,6 +47,7 @@ export interface GroupRecord {
4747 nameAttempts: number;
4848 firstFailureAt?: number;
4949 nextAttemptAt?: number;
50+ refusedHash?: string; // the members Apple's filter refused to name: not asked again until they change
5051 registeredAt?: number; // first seen as a group Diagonal did not know: it may yet turn out to be one of Diagonal's coming back
5152 revivedAt?: number; // came back after Chromium removed it (window move, reopen, restart)
5253 restored?: boolean; // "Restored": the archive brought back, not a topic other tabs should join
src/shared/health.ts+4−2
@@ -46,7 +46,9 @@ export function notices(s: Health): Notice[] {
4646 case "HOST_NOT_FOUND":
4747 out.push({
4848 tone: "bad", title: "Finish setting up Diagonal",
49− body: "Diagonal's helper isn't registered with this browser yet. Run this in Terminal, then reopen Diagonal.",
49+ body: chrome.runtime.getManifest().update_url
50+ ? "Diagonal's helper isn't registered with this browser yet. Run this in Terminal, then reopen Diagonal."
51+ : "Diagonal's helper isn't registered with this browser yet. Installed with Homebrew? Run this in Terminal, then reopen Diagonal. Installed from a zip? Run: bash <the Diagonal folder>/install-host.command",
5052 // A Web Store install has an update_url and may never have had the cask; an unpacked one came from it.
5153 command: chrome.runtime.getManifest().update_url ? "brew install iko-soy/tap/diagonal" : "brew reinstall diagonal",
5254 });
@@ -80,7 +82,7 @@ export function notices(s: Health): Notice[] {
8082 out.push({ tone: "bad", title: "Naming is paused", body: s.message || "The helper didn't answer. Diagonal retries on its own." });
8183 }
8284 }
83− if (s.timeoutHint && s.health !== "degraded") {
85+ if (s.timeoutHint) {
8486 out.push({ tone: "info", title: "The model is slow right now", body: "It timed out three times in a row. You can give it longer under Naming in Settings." });
8587 }
8688 return out;
src/shared/label.ts+35−9
@@ -7,9 +7,12 @@ export const LABEL_MAX_CHARS = 28;
77export const LABEL_MIN_WORDS = 2;
88export const LABEL_MAX_WORDS = 4;
99
10−const QUOTES = /["'“”‘’«»`]/g;
11−const HAS_QUOTE = /["'“”‘’«»`]/;
10+// Quotes go; an apostrophe between two letters ("Children's", "Rock'n'roll") is part of the word and stays.
11+const QUOTES = /(?<!\p{L})['’]|['’](?!\p{L})|["“”‘«»`]/gu;
12+const HAS_QUOTE = /(?<!\p{L})['’]|['’](?!\p{L})|["“”‘«»`]/u;
1213const TRAILING_PUNCT = /[\s.,;:!?…\-–—。、,!?:;]+$/u;
14+// A label cut short should not end mid-phrase: "Planning a trip to" reads as "Planning a trip".
15+const DANGLING = new Set(["a", "an", "the", "to", "of", "for", "in", "on", "at", "by", "and", "or", "with", "from"]);
1316
1417/** Repair what is repairable; return undefined when the label cannot be made valid. */
1518export function repairLabel(raw: unknown): string | undefined {
@@ -17,26 +20,49 @@ export function repairLabel(raw: unknown): string | undefined {
1720 let words = raw.replace(QUOTES, "").replace(/\s+/g, " ").trim().replace(TRAILING_PUNCT, "").split(" ").filter(Boolean);
1821 words = words.filter((w) => !BANNED_WORDS.has(w.toLowerCase().replace(/[^\p{L}\p{N}]/gu, "")));
1922 if (words.length > LABEL_MAX_WORDS) words = words.slice(0, LABEL_MAX_WORDS);
20− while (words.length > LABEL_MIN_WORDS && words.join(" ").length > LABEL_MAX_CHARS) words.pop();
23+ if (noSpace(words.join(" "))) {
24+ while (words.length > 1 && widthOf(words.join(" ")) > CJK_MAX_CHARS) words.pop();
25+ if (widthOf(words.join(" ")) > CJK_MAX_CHARS) words = [cutToWidth(words.join(" "), CJK_MAX_CHARS)];
26+ } else {
27+ while (words.length > LABEL_MIN_WORDS && words.join(" ").length > LABEL_MAX_CHARS) words.pop();
28+ }
29+ while (words.length > 1 && DANGLING.has(words[words.length - 1].toLowerCase())) words.pop();
2130 let label = words.join(" ").replace(TRAILING_PUNCT, "");
2231 if (!label) return undefined;
23− label = label[0].toLocaleUpperCase() + label.slice(1);
32+ // "rust async" becomes "Rust async"; "iPhone tips" and "macOS updates" keep the brand's own casing.
33+ if (!/\p{Lu}/u.test(words[0].slice(1))) label = label[0].toLocaleUpperCase() + label.slice(1);
2434 return isValidLabel(label) ? label : undefined;
2535}
2636
27−/** Chinese, Japanese and Korean titles have no spaces between words, so they're checked by length instead. */
28−const CJK = /[\u3040-\u30ff\u3400-\u4dbf\u4e00-\u9fff\uac00-\ud7af\uf900-\ufaff]/g;
37+/**
38+ * Chinese, Japanese, Korean, Thai, Lao, Khmer and Myanmar titles don't put spaces between words, so a label
39+ * with any of their characters ("Python教程") is checked by width instead of word count. Each such character
40+ * is about as wide as two Latin letters on the tab strip.
41+ */
42+const NO_SPACE = /[\u0e00-\u0eff\u1000-\u109f\u1780-\u17ff\u3040-\u30ff\u3400-\u4dbf\u4e00-\u9fff\uac00-\ud7af\uf900-\ufaff]/g;
2943export const CJK_MIN_CHARS = 2;
3044export const CJK_MAX_CHARS = 16;
3145
32−const isCjk = (label: string): boolean => (label.match(CJK)?.length ?? 0) * 2 > label.replace(/ /g, "").length;
46+const noSpace = (label: string): boolean => (label.match(NO_SPACE)?.length ?? 0) > 0;
47+const widthOf = (label: string): number => {
48+ const wide = label.match(NO_SPACE)?.length ?? 0;
49+ return wide + (label.length - wide) / 2;
50+};
51+const cutToWidth = (label: string, max: number): string => {
52+ let out = "";
53+ for (const ch of label) {
54+ if (widthOf(out + ch) > max) break;
55+ out += ch;
56+ }
57+ return out.trim();
58+};
3359
3460export function isValidLabel(label: string): boolean {
3561 const words = label.split(" ").filter(Boolean);
36− const cjk = isCjk(label);
62+ const cjk = noSpace(label);
3763 return (
3864 label.length >= (cjk ? CJK_MIN_CHARS : LABEL_MIN_CHARS) &&
39− label.length <= (cjk ? CJK_MAX_CHARS : LABEL_MAX_CHARS) &&
65+ (cjk ? widthOf(label) <= CJK_MAX_CHARS && label.length <= LABEL_MAX_CHARS : label.length <= LABEL_MAX_CHARS) &&
4066 words.length >= (cjk ? 1 : LABEL_MIN_WORDS) &&
4167 words.length <= LABEL_MAX_WORDS &&
4268 !HAS_QUOTE.test(label) &&
test/auto.test.ts+1
@@ -94,6 +94,7 @@ describe("auto-organize", () => {
9494 await auto.run(1);
9595 expect(calls[0].items.map((i) => i.title)).toEqual(["Tab 3", "Tab 2"]);
9696 expect(calls[0].existingGroups).toEqual([expect.objectContaining({ g: 0, title: "Rust" })]);
97+ expect(calls[0].siblingTitles).toEqual(["Rust"]);
9798 expect(live.find((t) => t.id === 3)!.groupId).toBe(50);
9899 });
99100
test/naming.test.ts+72−2
@@ -50,6 +50,10 @@ describe("evolving-name policy", () => {
5050 it("same label is never rewritten", () => {
5151 expect(shouldApply(g(), "rust async runtimes", ["a", "b", "c"])).toBe(false);
5252 });
53+ it("a member that only moved within its page is not a membership change", () => {
54+ const g2 = newGroupRecord(1, 1, "opener", "blue", { title: "Rust async runtimes", lastNamedAt: 1, memberUrls: ["https://a.com/x", "https://b.com/y"] });
55+ expect(shouldApply(g2, "Tokio and async-std", ["https://a.com/x?page=2", "https://b.com/y#top"])).toBe(false);
56+ });
5357 it("user-named groups are skipped", () => {
5458 expect(shouldApply({ ...g(), userNamed: true }, "Anything else", ["x"])).toBe(false);
5559 });
@@ -151,15 +155,25 @@ describe("naming queue", () => {
151155 expect(state.groups[7].dirty).toBe(false);
152156 });
153157
154− it("waits while a member is still loading or the group has one tab", async () => {
158+ it("waits while a member is still loading", async () => {
155159 members = [member(1), member(2, { status: "loading" })];
156160 naming.touch(7);
157161 await settle();
162+ expect(calls).toHaveLength(0);
163+ expect(state.groups[7].dirty).toBe(true);
164+ });
165+
166+ it("a group with one tab to name from is not kept waiting; the next tab to join names it", async () => {
158167 members = [member(1)];
159168 naming.touch(7);
160169 await settle();
161170 expect(calls).toHaveLength(0);
162− expect(state.groups[7].dirty).toBe(true);
171+ expect(state.groups[7].dirty).toBe(false);
172+ members = [member(1), member(2)];
173+ markDirty(state.groups[7], 0);
174+ naming.touch(7);
175+ await settle();
176+ expect(calls).toHaveLength(1);
163177 });
164178
165179 it("names a group whose member the browser discarded to save memory", async () => {
@@ -206,6 +220,54 @@ describe("naming queue", () => {
206220 expect(state.groups[7].nextAttemptAt).toBe(now + 24 * 3_600_000);
207221 });
208222
223+ it("a group Apple's filter refused is asked again as soon as its tabs change, not only after a day", async () => {
224+ replies.push({ ok: false, error: { code: "GUARDRAIL", message: "no" } }, { ok: false, error: { code: "GUARDRAIL", message: "no" } });
225+ naming.touch(7);
226+ await settle();
227+ expect(calls).toHaveLength(2);
228+ naming.touch(7);
229+ await settle();
230+ expect(calls).toHaveLength(2); // the same tabs: still refused
231+ members = [member(1), member(3)];
232+ naming.touch(7);
233+ await settle();
234+ expect(calls).toHaveLength(3);
235+ expect(state.groups[7]).toMatchObject({ title: "Rust crate docs", dirty: false, nameAttempts: 0 });
236+ expect(state.groups[7].refusedHash).toBeUndefined();
237+ });
238+
239+ it("setup errors don't use up a group's retries; the host's recovery picks it up", async () => {
240+ replies.push({ ok: false, error: { code: "LICENSE_REQUIRED", message: "terms" } });
241+ naming.touch(7);
242+ await settle();
243+ expect(state.groups[7]).toMatchObject({ dirty: true, nameAttempts: 0 });
244+ expect(state.groups[7].firstFailureAt).toBeUndefined();
245+ expect(state.groups[7].nextAttemptAt).toBeUndefined();
246+ });
247+
248+ it("a title the strip would not take is tried again shortly", async () => {
249+ let refuse = true;
250+ naming = new Naming({ ...(naming as any).d, writeTitle: async () => !refuse });
251+ naming.touch(7);
252+ await settle();
253+ expect(state.groups[7]).toMatchObject({ dirty: true, nextAttemptAt: now + 30_000 });
254+ expect(state.groups[7].title).toBeUndefined();
255+ expect(state.ownWrites[7]).toBeUndefined();
256+ refuse = false;
257+ now += 30_000;
258+ await naming.consider(7);
259+ await settle();
260+ expect(state.groups[7]).toMatchObject({ dirty: false, title: "Rust crate docs" });
261+ });
262+
263+ it("members back as they were last named clear old failures", async () => {
264+ Object.assign(state.groups[7], { membersHash: membersHash(members), nameAttempts: 3, firstFailureAt: 1, nextAttemptAt: 1 });
265+ naming.touch(7);
266+ await settle();
267+ expect(state.groups[7]).toMatchObject({ dirty: false, nameAttempts: 0 });
268+ expect(state.groups[7].firstFailureAt).toBeUndefined();
269+ });
270+
209271 it("failures back off 30 s, 2 min, 10 min, then hourly; the title is left alone", async () => {
210272 const fail: HostReply<NameResult> = { ok: false, error: { code: "FM_ERROR", message: "boom" } };
211273 replies.push(fail);
@@ -237,6 +299,14 @@ describe("naming queue", () => {
237299 expect(writes).toEqual([[7, "🦀 Rust crates"]]);
238300 });
239301
302+ it("the retry after a title the host rejected lists that title as not allowed", async () => {
303+ replies.push({ ok: false, error: { code: "BAD_MODEL_OUTPUT", message: "rules", raw: JSON.stringify({ title: "Python", emoji: "🐍" }) } });
304+ naming.touch(7);
305+ await settle();
306+ expect(calls).toHaveLength(2);
307+ expect(calls[1].mustDifferFrom).toEqual(["Python"]);
308+ });
309+
240310 it("a group renamed by hand while the model runs keeps the user's title", async () => {
241311 const n = new Naming({
242312 ...(naming as any).d,
test/url.test.ts+6−12
@@ -2,6 +2,7 @@ import { describe, expect, it } from "vitest";
22import { isValidLabel, labelOf, repairLabel, safeEmoji, titleKey } from "../src/shared/label";
33import { colorFor, hostname, isInternalUrl, promptAddress, promptUrl, provisionalTitle, registrableDomain, trimText } from "../src/shared/url";
44import { withDefaults } from "../src/background/settings";
5+import labelCases from "../host/tests/golden/labels.json";
56
67describe("url helpers", () => {
78 it("strips www.", () => {
@@ -45,19 +46,12 @@ describe("url helpers", () => {
4546 });
4647});
4748
48−describe("labels", () => {
49− it.each([
50− ['"Rust async runtimes."', "Rust async runtimes"],
51− ["rust async runtimes", "Rust async runtimes"],
52− ["Rust tabs and docs", "Rust and docs"],
53− ["One two three four five six", "One two three four"],
54− ["Machine learning research papers reading list", "Machine learning research"],
55− ])("repairs %s", (raw, fixed) => {
56− expect(repairLabel(raw)).toBe(fixed);
57− });
49+// The same cases run against the host's validate.repair_label, so the two sides agree on every label.
50+const LABEL_CASES = labelCases as [string, string | null][];
5851
59− it.each(["Tabs", "Misc stuff", "", "x", "Supercalifragilisticexpialidocious extraordinarily"])("rejects %s", (raw) => {
60− expect(repairLabel(raw)).toBeUndefined();
52+describe("labels", () => {
53+ it.each(LABEL_CASES)("repairs %s", (raw, fixed) => {
54+ expect(repairLabel(raw) ?? null).toBe(fixed);
6155 });
6256
6357 it("validates", () => {
tsconfig.json+1
@@ -9,6 +9,7 @@
99 "noEmit": true,
1010 "skipLibCheck": true,
1111 "isolatedModules": true,
12+ "resolveJsonModule": true,
1213 "noFallthroughCasesInSwitch": true,
1314 "forceConsistentCasingInFileNames": true
1415 },