digital-asset/daml
1
1
Fork 0
mirror of https://github.com/digital-asset/daml.git synced 2024-09-20 09:17:43 +03:00
Code Issues Projects Releases Wiki Activity
b87acab897
daml/security-evidence.md

70 lines
9.2 KiB
Markdown
Raw Normal View History

Generate security evidence by documenting security testcases (#11306) * Generate security evidence by documenting security testcases. CHANGELOG_BEGIN CHANGELOG_END * move generated file to root of repo, so links work * formatError function instead of Show instance * dont use Show instances for generating Markdown * magic comment: SECURITY_TEST --> TEST_EVIDENCE * use megaparsec and Data.Text * remove redundant T.pack * use: Text.Megaparsec.Char.space
2021-10-26 12:07:59 +03:00
# Security tests, by category
## Authorization:
Add by_interface field in Create, Fetch, & Exercise transaction nodes. (#11576) * Add by_interface field in tx nodes. This PR adds an optional `by_interface` field in the Create, Fetch, and Exercise nodes, as part of #10915. It also updates TransactionCoder to support these fields. Setting these fields (in the LF interpreter) is left to a separate PR. changelog_begin changelog_end * update security-evidence.md * Add version checks in TransactionCoder
2021-11-08 19:33:02 +03:00
- badly-authorized create is rejected: [AuthorizationSpec.scala](daml-lf/engine/src/test/scala/com/digitalasset/daml/lf/engine/AuthorizationSpec.scala#L61)
- badly-authorized exercise is rejected: [AuthorizationSpec.scala](daml-lf/engine/src/test/scala/com/digitalasset/daml/lf/engine/AuthorizationSpec.scala#L159)
Improve evidence of testing (#11428) * fine grained test evidence for authorization * fine grained test evidence for privacy * fine grained test evidence for input-validation (typing) * fix exit code of security/update.sh script (set -euo pipefail) * add security evidence test category: Input Validation * regenerate security-evidence.md CHANGELOG_BEGIN CHANGELOG_END * fix bug in securoty evidence generation (must sort before group, or else we loose lines) * evidence for input validation of commands * address comments * cleanup: remove backticks from evidence free text
2021-10-28 12:24:52 +03:00
- badly-authorized exercise/create (create is unauthorized) is rejected: [AuthPropagationSpec.scala](daml-lf/engine/src/test/scala/com/digitalasset/daml/lf/engine/AuthPropagationSpec.scala#L265)
- badly-authorized exercise/create (exercise is unauthorized) is rejected: [AuthPropagationSpec.scala](daml-lf/engine/src/test/scala/com/digitalasset/daml/lf/engine/AuthPropagationSpec.scala#L233)
- badly-authorized exercise/exercise (no implicit authority from outer exercise) is rejected: [AuthPropagationSpec.scala](daml-lf/engine/src/test/scala/com/digitalasset/daml/lf/engine/AuthPropagationSpec.scala#L324)
Add by_interface field in Create, Fetch, & Exercise transaction nodes. (#11576) * Add by_interface field in tx nodes. This PR adds an optional `by_interface` field in the Create, Fetch, and Exercise nodes, as part of #10915. It also updates TransactionCoder to support these fields. Setting these fields (in the LF interpreter) is left to a separate PR. changelog_begin changelog_end * update security-evidence.md * Add version checks in TransactionCoder
2021-11-08 19:33:02 +03:00
- badly-authorized fetch is rejected: [AuthorizationSpec.scala](daml-lf/engine/src/test/scala/com/digitalasset/daml/lf/engine/AuthorizationSpec.scala#L96)
- badly-authorized lookup is rejected: [AuthorizationSpec.scala](daml-lf/engine/src/test/scala/com/digitalasset/daml/lf/engine/AuthorizationSpec.scala#L118)
- create with no signatories is rejected: [AuthorizationSpec.scala](daml-lf/engine/src/test/scala/com/digitalasset/daml/lf/engine/AuthorizationSpec.scala#L51)
- create with non-signatory maintainers is rejected: [AuthorizationSpec.scala](daml-lf/engine/src/test/scala/com/digitalasset/daml/lf/engine/AuthorizationSpec.scala#L73)
- exercise with no controllers is rejected: [AuthorizationSpec.scala](daml-lf/engine/src/test/scala/com/digitalasset/daml/lf/engine/AuthorizationSpec.scala#L149)
- well-authorized create is accepted: [AuthorizationSpec.scala](daml-lf/engine/src/test/scala/com/digitalasset/daml/lf/engine/AuthorizationSpec.scala#L44)
- well-authorized exercise is accepted: [AuthorizationSpec.scala](daml-lf/engine/src/test/scala/com/digitalasset/daml/lf/engine/AuthorizationSpec.scala#L142)
Improve evidence of testing (#11428) * fine grained test evidence for authorization * fine grained test evidence for privacy * fine grained test evidence for input-validation (typing) * fix exit code of security/update.sh script (set -euo pipefail) * add security evidence test category: Input Validation * regenerate security-evidence.md CHANGELOG_BEGIN CHANGELOG_END * fix bug in securoty evidence generation (must sort before group, or else we loose lines) * evidence for input validation of commands * address comments * cleanup: remove backticks from evidence free text
2021-10-28 12:24:52 +03:00
- well-authorized exercise/create is accepted: [AuthPropagationSpec.scala](daml-lf/engine/src/test/scala/com/digitalasset/daml/lf/engine/AuthPropagationSpec.scala#L211)
- well-authorized exercise/exercise is accepted: [AuthPropagationSpec.scala](daml-lf/engine/src/test/scala/com/digitalasset/daml/lf/engine/AuthPropagationSpec.scala#L367)
Add by_interface field in Create, Fetch, & Exercise transaction nodes. (#11576) * Add by_interface field in tx nodes. This PR adds an optional `by_interface` field in the Create, Fetch, and Exercise nodes, as part of #10915. It also updates TransactionCoder to support these fields. Setting these fields (in the LF interpreter) is left to a separate PR. changelog_begin changelog_end * update security-evidence.md * Add version checks in TransactionCoder
2021-11-08 19:33:02 +03:00
- well-authorized fetch is accepted: [AuthorizationSpec.scala](daml-lf/engine/src/test/scala/com/digitalasset/daml/lf/engine/AuthorizationSpec.scala#L90)
- well-authorized lookup is accepted: [AuthorizationSpec.scala](daml-lf/engine/src/test/scala/com/digitalasset/daml/lf/engine/AuthorizationSpec.scala#L112)
Generate security evidence by documenting security testcases (#11306) * Generate security evidence by documenting security testcases. CHANGELOG_BEGIN CHANGELOG_END * move generated file to root of repo, so links work * formatError function instead of Show instance * dont use Show instances for generating Markdown * magic comment: SECURITY_TEST --> TEST_EVIDENCE * use megaparsec and Data.Text * remove redundant T.pack * use: Text.Megaparsec.Char.space
2021-10-26 12:07:59 +03:00
## Privacy:
Improve evidence of testing (#11428) * fine grained test evidence for authorization * fine grained test evidence for privacy * fine grained test evidence for input-validation (typing) * fix exit code of security/update.sh script (set -euo pipefail) * add security evidence test category: Input Validation * regenerate security-evidence.md CHANGELOG_BEGIN CHANGELOG_END * fix bug in securoty evidence generation (must sort before group, or else we loose lines) * evidence for input validation of commands * address comments * cleanup: remove backticks from evidence free text
2021-10-28 12:24:52 +03:00
- ensure correct privacy for create node: [BlindingSpec.scala](daml-lf/engine/src/test/scala/com/digitalasset/daml/lf/engine/BlindingSpec.scala#L32)
- ensure correct privacy for exercise node (consuming): [BlindingSpec.scala](daml-lf/engine/src/test/scala/com/digitalasset/daml/lf/engine/BlindingSpec.scala#L43)
- ensure correct privacy for exercise node (non-consuming): [BlindingSpec.scala](daml-lf/engine/src/test/scala/com/digitalasset/daml/lf/engine/BlindingSpec.scala#L62)
Add by_interface field in Create, Fetch, & Exercise transaction nodes. (#11576) * Add by_interface field in tx nodes. This PR adds an optional `by_interface` field in the Create, Fetch, and Exercise nodes, as part of #10915. It also updates TransactionCoder to support these fields. Setting these fields (in the LF interpreter) is left to a separate PR. changelog_begin changelog_end * update security-evidence.md * Add version checks in TransactionCoder
2021-11-08 19:33:02 +03:00
- ensure correct privacy for exercise subtree: [BlindingSpec.scala](daml-lf/engine/src/test/scala/com/digitalasset/daml/lf/engine/BlindingSpec.scala#L139)
Improve evidence of testing (#11428) * fine grained test evidence for authorization * fine grained test evidence for privacy * fine grained test evidence for input-validation (typing) * fix exit code of security/update.sh script (set -euo pipefail) * add security evidence test category: Input Validation * regenerate security-evidence.md CHANGELOG_BEGIN CHANGELOG_END * fix bug in securoty evidence generation (must sort before group, or else we loose lines) * evidence for input validation of commands * address comments * cleanup: remove backticks from evidence free text
2021-10-28 12:24:52 +03:00
- ensure correct privacy for fetch node: [BlindingSpec.scala](daml-lf/engine/src/test/scala/com/digitalasset/daml/lf/engine/BlindingSpec.scala#L82)
- ensure correct privacy for lookup-by-key node (found): [BlindingSpec.scala](daml-lf/engine/src/test/scala/com/digitalasset/daml/lf/engine/BlindingSpec.scala#L94)
Add by_interface field in Create, Fetch, & Exercise transaction nodes. (#11576) * Add by_interface field in tx nodes. This PR adds an optional `by_interface` field in the Create, Fetch, and Exercise nodes, as part of #10915. It also updates TransactionCoder to support these fields. Setting these fields (in the LF interpreter) is left to a separate PR. changelog_begin changelog_end * update security-evidence.md * Add version checks in TransactionCoder
2021-11-08 19:33:02 +03:00
- ensure correct privacy for lookup-by-key node (not-found): [BlindingSpec.scala](daml-lf/engine/src/test/scala/com/digitalasset/daml/lf/engine/BlindingSpec.scala#L116)
- ensure correct privacy for rollback subtree: [BlindingSpec.scala](daml-lf/engine/src/test/scala/com/digitalasset/daml/lf/engine/BlindingSpec.scala#L201)
Generate security evidence by documenting security testcases (#11306) * Generate security evidence by documenting security testcases. CHANGELOG_BEGIN CHANGELOG_END * move generated file to root of repo, so links work * formatError function instead of Show instance * dont use Show instances for generating Markdown * magic comment: SECURITY_TEST --> TEST_EVIDENCE * use megaparsec and Data.Text * remove redundant T.pack * use: Text.Megaparsec.Char.space
2021-10-26 12:07:59 +03:00
## Semantics:
- Exceptions, throw/catch.: [ExceptionTest.scala](daml-lf/interpreter/src/test/scala/com/digitalasset/daml/lf/speedy/ExceptionTest.scala#L24)
Evidence for contract-key testing (#11479) * Split contract-key tests from engine tests, and mark for evidence. CHANGELOG_BEGIN CHANGELOG_END * remove contract key tests from their original location * evidence for unique/non-unique contract keys
2021-11-01 19:38:26 +03:00
- contract key behaviour (non-unique mode): [ContractKeySpec.scala](daml-lf/engine/src/test/scala/com/digitalasset/daml/lf/engine/ContractKeySpec.scala#L383)
- contract key behaviour (unique mode): [ContractKeySpec.scala](daml-lf/engine/src/test/scala/com/digitalasset/daml/lf/engine/ContractKeySpec.scala#L389)
- contract keys must have a non-empty set of maintainers: [ContractKeySpec.scala](daml-lf/engine/src/test/scala/com/digitalasset/daml/lf/engine/ContractKeySpec.scala#L218)
- contract keys should be evaluated after ensure clause: [ContractKeySpec.scala](daml-lf/engine/src/test/scala/com/digitalasset/daml/lf/engine/ContractKeySpec.scala#L185)
- contract keys should be evaluated only when executing create: [ContractKeySpec.scala](daml-lf/engine/src/test/scala/com/digitalasset/daml/lf/engine/ContractKeySpec.scala#L146)
Generate security evidence by documenting security testcases (#11306) * Generate security evidence by documenting security testcases. CHANGELOG_BEGIN CHANGELOG_END * move generated file to root of repo, so links work * formatError function instead of Show instance * dont use Show instances for generating Markdown * magic comment: SECURITY_TEST --> TEST_EVIDENCE * use megaparsec and Data.Text * remove redundant T.pack * use: Text.Megaparsec.Char.space
2021-10-26 12:07:59 +03:00
## Performance:
- Tail call optimization: Tail recursion does not blow the scala JVM stack.: [TailCallTest.scala](daml-lf/interpreter/src/test/scala/com/digitalasset/daml/lf/speedy/TailCallTest.scala#L18)
Improve evidence of testing (#11428) * fine grained test evidence for authorization * fine grained test evidence for privacy * fine grained test evidence for input-validation (typing) * fix exit code of security/update.sh script (set -euo pipefail) * add security evidence test category: Input Validation * regenerate security-evidence.md CHANGELOG_BEGIN CHANGELOG_END * fix bug in securoty evidence generation (must sort before group, or else we loose lines) * evidence for input validation of commands * address comments * cleanup: remove backticks from evidence free text
2021-10-28 12:24:52 +03:00
## Input Validation:
- ensure builtin operators have the correct type: [TypingSpec.scala](daml-lf/validation/src/test/scala/com/digitalasset/daml/lf/validation/TypingSpec.scala#L47)
- ensure expression forms have the correct type: [TypingSpec.scala](daml-lf/validation/src/test/scala/com/digitalasset/daml/lf/validation/TypingSpec.scala#L107)
- ill-formed create command is rejected: [CommandPreprocessorSpec.scala](daml-lf/engine/src/test/scala/com/digitalasset/daml/lf/engine/CommandPreprocessorSpec.scala#L137)
- ill-formed create-and-exercise command is rejected: [CommandPreprocessorSpec.scala](daml-lf/engine/src/test/scala/com/digitalasset/daml/lf/engine/CommandPreprocessorSpec.scala#L158)
- ill-formed exception definitions are rejected: [TypingSpec.scala](daml-lf/validation/src/test/scala/com/digitalasset/daml/lf/validation/TypingSpec.scala#L1078)
- ill-formed exercise command is rejected: [CommandPreprocessorSpec.scala](daml-lf/engine/src/test/scala/com/digitalasset/daml/lf/engine/CommandPreprocessorSpec.scala#L142)
- ill-formed exercise-by-key command is rejected: [CommandPreprocessorSpec.scala](daml-lf/engine/src/test/scala/com/digitalasset/daml/lf/engine/CommandPreprocessorSpec.scala#L149)
- ill-formed expressions are rejected: [TypingSpec.scala](daml-lf/validation/src/test/scala/com/digitalasset/daml/lf/validation/TypingSpec.scala#L408)
- ill-formed fetch command is rejected: [CommandPreprocessorSpec.scala](daml-lf/engine/src/test/scala/com/digitalasset/daml/lf/engine/CommandPreprocessorSpec.scala#L171)
- ill-formed fetch-by-key command is rejected: [CommandPreprocessorSpec.scala](daml-lf/engine/src/test/scala/com/digitalasset/daml/lf/engine/CommandPreprocessorSpec.scala#L174)
- ill-formed kinds are rejected: [TypingSpec.scala](daml-lf/validation/src/test/scala/com/digitalasset/daml/lf/validation/TypingSpec.scala#L19)
- ill-formed lookup command is rejected: [CommandPreprocessorSpec.scala](daml-lf/engine/src/test/scala/com/digitalasset/daml/lf/engine/CommandPreprocessorSpec.scala#L179)
- ill-formed records are rejected: [TypingSpec.scala](daml-lf/validation/src/test/scala/com/digitalasset/daml/lf/validation/TypingSpec.scala#L1220)
- ill-formed templates are rejected: [TypingSpec.scala](daml-lf/validation/src/test/scala/com/digitalasset/daml/lf/validation/TypingSpec.scala#L815)
- ill-formed type synonyms applications are rejected: [TypingSpec.scala](daml-lf/validation/src/test/scala/com/digitalasset/daml/lf/validation/TypingSpec.scala#L1199)
- ill-formed type synonyms definitions are rejected: [TypingSpec.scala](daml-lf/validation/src/test/scala/com/digitalasset/daml/lf/validation/TypingSpec.scala#L1266)
- ill-formed types are rejected: [TypingSpec.scala](daml-lf/validation/src/test/scala/com/digitalasset/daml/lf/validation/TypingSpec.scala#L99)
- ill-formed variants are rejected: [TypingSpec.scala](daml-lf/validation/src/test/scala/com/digitalasset/daml/lf/validation/TypingSpec.scala#L1243)
- well formed create command is accepted: [CommandPreprocessorSpec.scala](daml-lf/engine/src/test/scala/com/digitalasset/daml/lf/engine/CommandPreprocessorSpec.scala#L83)
- well formed create-and-exercise command is accepted: [CommandPreprocessorSpec.scala](daml-lf/engine/src/test/scala/com/digitalasset/daml/lf/engine/CommandPreprocessorSpec.scala#L102)
- well formed exercise command is accepted: [CommandPreprocessorSpec.scala](daml-lf/engine/src/test/scala/com/digitalasset/daml/lf/engine/CommandPreprocessorSpec.scala#L88)
- well formed exercise-by-key command is accepted: [CommandPreprocessorSpec.scala](daml-lf/engine/src/test/scala/com/digitalasset/daml/lf/engine/CommandPreprocessorSpec.scala#L95)
- well formed fetch command is accepted: [CommandPreprocessorSpec.scala](daml-lf/engine/src/test/scala/com/digitalasset/daml/lf/engine/CommandPreprocessorSpec.scala#L109)
- well formed fetch-by-key command is accepted: [CommandPreprocessorSpec.scala](daml-lf/engine/src/test/scala/com/digitalasset/daml/lf/engine/CommandPreprocessorSpec.scala#L114)
- well formed lookup command is accepted: [CommandPreprocessorSpec.scala](daml-lf/engine/src/test/scala/com/digitalasset/daml/lf/engine/CommandPreprocessorSpec.scala#L119)
Generate security evidence by documenting security testcases (#11306) * Generate security evidence by documenting security testcases. CHANGELOG_BEGIN CHANGELOG_END * move generated file to root of repo, so links work * formatError function instead of Show instance * dont use Show instances for generating Markdown * magic comment: SECURITY_TEST --> TEST_EVIDENCE * use megaparsec and Data.Text * remove redundant T.pack * use: Text.Megaparsec.Char.space
2021-10-26 12:07:59 +03:00
Reference in New Issue Copy Permalink