Add logback.xml file in the distributable JAR for the Trigger Service (#13295)

Fixes #13042

changelog_begin
[Trigger Service] Debug logging is now hidden by default. See #13042
changelog_end

Summary of changes:
- remove unused `exports_files`
- refactor trigger-service-binary rules in a single comprehension
- add the `logback.xml` file in the JAR root

Tested manually: listed the contents of the output of `bazel build //triggers/service:trigger-service-binary-ce_deploy.jar` and `bazel build //triggers/service:trigger-service-binary-ee_deploy.jar` before and after the fix, observed that the only difference is the `logback.xml` file in the JAR root; added a debug logger call and ran both JARs before and after the fix, observed that after the fix the debug logging line is no longer printed.
This commit is contained in:
Stefano Baghino 2022-03-15 17:03:01 +01:00 committed by GitHub
parent 54847efb20
commit 0ffb88a6ca
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -106,30 +106,30 @@ binary_deps = [
"@maven//:org_slf4j_slf4j_api",
]
da_scala_binary(
name = "trigger-service-binary-ce",
srcs = [triggerMain],
main_class = "com.daml.lf.engine.trigger.ServiceMain",
scala_deps = scala_binary_deps,
visibility = ["//visibility:public"],
deps = binary_deps + [
"//runtime-components/jdbc-drivers:jdbc-drivers-ce",
],
)
trigger_service_runtime_deps = {
"ce": [],
"ee": ["@maven//:com_oracle_database_jdbc_ojdbc8"],
}
da_scala_binary(
name = "trigger-service-binary-ee",
srcs = [triggerMain],
main_class = "com.daml.lf.engine.trigger.ServiceMain",
scala_deps = scala_binary_deps,
visibility = ["//visibility:public"],
runtime_deps = [
"@maven//:com_oracle_database_jdbc_ojdbc8",
],
deps = binary_deps + [
"//runtime-components/jdbc-drivers:jdbc-drivers-ee",
],
)
[
da_scala_binary(
name = "trigger-service-binary-{}".format(edition),
srcs = [triggerMain],
main_class = "com.daml.lf.engine.trigger.ServiceMain",
resource_strip_prefix = "triggers/service/release/trigger-service-",
resources = ["release/trigger-service-logback.xml"],
scala_deps = scala_binary_deps,
visibility = ["//visibility:public"],
runtime_deps = trigger_service_runtime_deps.get(edition),
deps = binary_deps + [
"//runtime-components/jdbc-drivers:jdbc-drivers-{}".format(edition),
],
)
for edition in [
"ce",
"ee",
]
]
da_scala_library(
name = "trigger-service-tests",