update canton to 20240703.13595.v030861a1 (#19504)

tell-slack: canton

Co-authored-by: Azure Pipelines Daml Build <support@digitalasset.com>

sdk/canton/community/admin-api/src/main/protobuf/com/digitalasset/canton/admin/participant/v30/enterprise_participant_replication_service.proto

@@ -12,5 +12,7 @@ service EnterpriseParticipantReplicationService {
 message SetPassive {
   message Request {}
 
-  message Response {}
+  message Response {
+    bool became_passive = 1;
+  }
 }

sdk/canton/community/app-base/src/main/scala/com/digitalasset/canton/admin/api/client/commands/ParticipantAdminCommands.scala

@@ -1841,7 +1841,7 @@ object ParticipantAdminCommands {
   object Replication {
 
     final case class SetPassiveCommand()
-        extends GrpcAdminCommand[SetPassive.Request, SetPassive.Response, Unit] {
+        extends GrpcAdminCommand[SetPassive.Request, SetPassive.Response, Boolean] {
       override type Svc = EnterpriseParticipantReplicationServiceStub
 
       override def createService(
@@ -1858,9 +1858,9 @@ object ParticipantAdminCommands {
       ): Future[SetPassive.Response] =
         service.setPassive(request)
 
-      override def handleResponse(response: SetPassive.Response): Either[String, Unit] =
+      override def handleResponse(response: SetPassive.Response): Either[String, Boolean] =
         response match {
-          case SetPassive.Response() => Right(())
+          case SetPassive.Response(becamePassive) => Right(becamePassive)
         }
     }
   }

sdk/canton/community/app-base/src/main/scala/com/digitalasset/canton/console/commands/ParticipantAdministration.scala

@@ -1077,9 +1077,9 @@ class ParticipantReplicationAdministrationGroup(
 
   @Help.Summary("Set the participant replica to passive")
   @Help.Description(
-    "Trigger a graceful fail-over from this active replica to another passive replica."
+    "Trigger a graceful fail-over from this active replica to another passive replica. Returns true if another replica became active."
   )
-  def set_passive(): Unit = {
+  def set_passive(): Boolean = {
     consoleEnvironment.run {
       runner.adminCommand(
         ParticipantAdminCommands.Replication.SetPassiveCommand()

sdk/canton/community/app-base/src/main/scala/com/digitalasset/canton/environment/Environment.scala

@@ -51,7 +51,7 @@ import scala.util.control.NonFatal
   */
 trait Environment extends NamedLogging with AutoCloseable with NoTracing {
 
-  type Config <: CantonConfig
+  type Config <: CantonConfig & ConfigDefaults[DefaultPorts, Config]
   type Console <: ConsoleEnvironment
 
   val config: Config

sdk/canton/community/base/src/main/scala/com/digitalasset/canton/crypto/HashPurpose.scala

@@ -91,4 +91,5 @@ object HashPurpose {
   val OrderingRequestSignature = HashPurpose(42, "OrderingRequestSignature")
   val TopologyMappingUniqueKey = HashPurpose(43, "TopologyMappingUniqueKey")
   val CantonScript = HashPurpose(44, "CantonScriptHash")
+  val BftAvailabilityAck = HashPurpose(45, "BftAvailabilityAck")
 }

sdk/canton/community/base/src/main/scala/com/digitalasset/canton/protocol/LocalRejectError.scala

@@ -60,14 +60,20 @@ sealed trait LocalRejectError
   def _resourcesType: Option[ErrorResource] = None
 
   /** The affected resources.
-    * Will be logged as part of the context information.
-    * If this error is converted to an rpc Status, this field is included as com.google.rpc.ResourceInfo.
+    * It is used as follows:
+    * - It will be logged as part of the context information.
+    * - It is included into the resulting LocalReject.
+    * - The LocalReject is sent via the sequencer to the mediator. Therefore: do not include any confidential data!
+    * - The LocalReject is also output through the ledger API.
     */
   def _resources: Seq[String] = Seq()
 
   override def resources: Seq[(ErrorResource, String)] =
     _resourcesType.fold(Seq.empty[(ErrorResource, String)])(rt => _resources.map(rs => (rt, rs)))
 
+  override def context: Map[String, String] =
+    _resourcesType.map(_.asString -> _resources.show).toList.toMap ++ super.context
+
   override def pretty: Pretty[LocalRejectError] =
     prettyOfClass(
       param("code", _.code.id.unquoted),

sdk/canton/community/domain/src/main/scala/com/digitalasset/canton/domain/sequencing/SequencerNode.scala

@@ -233,6 +233,7 @@ class SequencerNodeBootstrap(
         storage,
         sequencerId,
         arguments.parameterConfig,
+        arguments.futureSupervisor,
         loggerFactory,
       )(config.sequencer)
       addCloseable(ret)

sdk/canton/community/domain/src/main/scala/com/digitalasset/canton/domain/sequencing/sequencer/SequencerFactory.scala

@@ -160,6 +160,7 @@ trait MkSequencerFactory {
       storage: Storage,
       sequencerId: SequencerId,
       nodeParameters: CantonNodeParameters,
+      futureSupervisor: FutureSupervisor,
       loggerFactory: NamedLoggerFactory,
   )(
       sequencerConfig: SequencerConfig
@@ -177,6 +178,7 @@ object CommunitySequencerFactory extends MkSequencerFactory {
       storage: Storage,
       sequencerId: SequencerId,
       nodeParameters: CantonNodeParameters,
+      futureSupervisor: FutureSupervisor,
       loggerFactory: NamedLoggerFactory,
   )(sequencerConfig: SequencerConfig)(implicit
       executionContext: ExecutionContext

sdk/canton/community/domain/src/test/scala/com/digitalasset/canton/domain/sequencing/sequencer/SequencerApiTest.scala

@@ -206,7 +206,10 @@ abstract class SequencerApiTest
               }) or include("Detected new members without sequencer counter") or
                 include regex "Creating .* at block height None" or
                 include("Subscribing to block source from") or
-                include("Advancing sim clock"))
+                include("Advancing sim clock") or
+                (include("Creating ForkJoinPool with parallelism") and include(
+                  "to avoid starvation"
+                )))
             },
           )
         } yield {

sdk/canton/community/integration-testing/src/main/scala/com/digitalasset/canton/integration/EnvironmentSetup.scala

@@ -4,6 +4,7 @@
 package com.digitalasset.canton.integration
 
 import com.digitalasset.canton.CloseableTest
+import com.digitalasset.canton.config.DefaultPorts
 import com.digitalasset.canton.config.RequireTypes.PositiveInt
 import com.digitalasset.canton.environment.Environment
 import com.digitalasset.canton.logging.{LogEntry, NamedLogging, SuppressingLogger}
@@ -83,7 +84,9 @@ sealed trait EnvironmentSetup[E <: Environment, TCE <: TestConsoleEnvironment[E]
           config
       )
     }
-    val finalConfig = configTransform(pluginConfig)
+
+    // Once all the plugins and config transformation is done apply the defaults
+    val finalConfig = configTransform(pluginConfig).withDefaults(new DefaultPorts())
 
     val scopedMetricsFactory = new ScopedInMemoryMetricsFactory
     val environmentFixture =

sdk/canton/community/participant/src/main/scala/com/digitalasset/canton/participant/ParticipantNode.scala

@@ -987,7 +987,7 @@ class ParticipantNode(
     val id: ParticipantId,
     val metrics: ParticipantMetrics,
     val config: LocalParticipantConfig,
-    storage: Storage,
+    val storage: Storage,
     override protected val clock: Clock,
     val cryptoPureApi: CryptoPureApi,
     identityPusher: ParticipantTopologyDispatcher,

sdk/canton/community/participant/src/main/scala/com/digitalasset/canton/participant/admin/AdminWorkflowServices.scala

@@ -172,7 +172,7 @@ class AdminWorkflowServices(
                   packageService
                     .vetPackages(
                       AdminWorkflowServices.AdminWorkflowPackages.keys.toSeq,
-                      syncVetting = false,
+                      synchronizeVetting = PackageVettingSynchronization.NoSync,
                     )
                 )
               )
@@ -200,7 +200,7 @@ class AdminWorkflowServices(
           fileNameO = Some(AdminWorkflowServices.AdminWorkflowDarResourceName),
           submissionIdO = None,
           vetAllPackages = true,
-          synchronizeVetting = false,
+          synchronizeVetting = PackageVettingSynchronization.NoSync,
         )
         .void
     )

sdk/canton/community/participant/src/main/scala/com/digitalasset/canton/participant/admin/PackageOps.scala

@@ -5,6 +5,7 @@ package com.digitalasset.canton.participant.admin
 
 import cats.data.EitherT
 import cats.implicits.toBifunctorOps
+import cats.syntax.functor.*
 import cats.syntax.parallel.*
 import com.daml.nameof.NameOf.functionFullName
 import com.digitalasset.canton.LfPackageId
@@ -41,7 +42,7 @@ trait PackageOps extends NamedLogging {
 
   def vetPackages(
       packages: Seq[PackageId],
-      synchronize: Boolean,
+      synchronizeVetting: PackageVettingSynchronization,
   )(implicit
       traceContext: TraceContext
   ): EitherT[FutureUnlessShutdown, ParticipantTopologyManagerError, Unit]
@@ -106,15 +107,25 @@ class PackageOpsImpl(
     packageIsVettedOn.bimap(PackageMissingDependencies.Reject(packageId, _), _.contains(true))
   }
 
-  override def vetPackages(packages: Seq[PackageId], synchronize: Boolean)(implicit
+  override def vetPackages(
+      packages: Seq[PackageId],
+      synchronizeVetting: PackageVettingSynchronization,
+  )(implicit
       traceContext: TraceContext
   ): EitherT[FutureUnlessShutdown, ParticipantTopologyManagerError, Unit] = {
-    modifyVettedPackages { existingPackages =>
-      // Keep deterministic order for testing and keep optimal O(n)
-      val existingPackagesSet = existingPackages.toSet
-      val packagesToBeAdded = packages.filterNot(existingPackagesSet)
-      existingPackages ++ packagesToBeAdded
-    }
+    for {
+      newVettedPackagesCreated <- modifyVettedPackages { existingPackages =>
+        // Keep deterministic order for testing and keep optimal O(n)
+        val existingPackagesSet = existingPackages.toSet
+        val packagesToBeAdded = packages.filterNot(existingPackagesSet)
+        existingPackages ++ packagesToBeAdded
+      }
+      // only synchronize with the connected domains if a new VettedPackages transaction was actually issued
+      _ <- EitherTUtil.ifThenET(newVettedPackagesCreated) {
+        synchronizeVetting.sync(packages.toSet)
+      }
+    } yield ()
+
   }
 
   override def revokeVettingForPackages(
@@ -124,14 +135,15 @@ class PackageOpsImpl(
   )(implicit tc: TraceContext): EitherT[FutureUnlessShutdown, CantonError, Unit] = {
     val packagesToUnvet = packages.toSet
 
-    modifyVettedPackages(_.filterNot(packagesToUnvet)).leftWiden
+    modifyVettedPackages(_.filterNot(packagesToUnvet)).leftWiden[CantonError].void
   }
 
+  /** Returns true if a new VettedPackages transaction was authorized. */
   def modifyVettedPackages(
       action: Seq[LfPackageId] => Seq[LfPackageId]
   )(implicit
       tc: TraceContext
-  ): EitherT[FutureUnlessShutdown, ParticipantTopologyManagerError, Unit] = {
+  ): EitherT[FutureUnlessShutdown, ParticipantTopologyManagerError, Boolean] = {
     // TODO(#14069) this vetting extension might fail on concurrent requests
 
     for {
@@ -179,6 +191,6 @@ class PackageOpsImpl(
             .map(_ => ())
         )
       }
-    } yield ()
+    } yield newVettedPackagesState != currentPackages
   }
 }

sdk/canton/community/participant/src/main/scala/com/digitalasset/canton/participant/admin/PackageService.scala

@@ -60,7 +60,7 @@ trait DarService {
       fileNameO: Option[String],
       submissionIdO: Option[LedgerSubmissionId],
       vetAllPackages: Boolean,
-      synchronizeVetting: Boolean,
+      synchronizeVetting: PackageVettingSynchronization,
   )(implicit traceContext: TraceContext): EitherT[FutureUnlessShutdown, DamlError, Hash]
 
   def validateDar(
@@ -150,12 +150,15 @@ class PackageService(
   ): EitherT[FutureUnlessShutdown, CantonError, Unit] =
     ifDarExists(darHash)(removeDarLf(_, _))(ifNotExistsOperationFailed = "DAR archive removal")
 
-  def vetDar(darHash: Hash, synchronize: Boolean)(implicit
+  def vetDar(
+      darHash: Hash,
+      synchronizeVetting: PackageVettingSynchronization,
+  )(implicit
       traceContext: TraceContext
   ): EitherT[FutureUnlessShutdown, CantonError, Unit] =
     ifDarExists(darHash) { (_, darLf) =>
       packageOps
-        .vetPackages(darLf.all.map(readPackageId), synchronize)
+        .vetPackages(darLf.all.map(readPackageId), synchronizeVetting)
         .leftWiden[CantonError]
     }(ifNotExistsOperationFailed = "DAR archive vetting")
 
@@ -305,14 +308,16 @@ class PackageService(
     * @param fileNameO The DAR filename, present if uploaded via the Admin API.
     * @param submissionIdO upstream submissionId for ledger api server to recognize previous package upload requests
     * @param vetAllPackages if true, then the packages will be vetted automatically
-    * @param synchronizeVetting if true, the future will terminate once the participant observed the package vetting on all connected domains
+    * @param synchronizeVetting a value of PackageVettingSynchronization, that checks that the packages have been vetted on all connected domains.
+    *                            The Future returned by the check will complete once all domains have observed the vetting for the new packages.
+    *                            The caller may also pass be a no-op implementation that immediately returns, depending no the caller's needs for synchronization.
     */
   def upload(
       darBytes: ByteString,
       fileNameO: Option[String],
       submissionIdO: Option[LedgerSubmissionId],
       vetAllPackages: Boolean,
-      synchronizeVetting: Boolean,
+      synchronizeVetting: PackageVettingSynchronization,
   )(implicit traceContext: TraceContext): EitherT[FutureUnlessShutdown, DamlError, Hash] = {
     val submissionId =
       submissionIdO.getOrElse(LedgerSubmissionId.assertFromString(UUID.randomUUID().toString))
@@ -348,11 +353,14 @@ class PackageService(
         .map(_.toRight(s"No such dar ${darId}").flatMap(PackageService.darToLf))
     )
 
-  def vetPackages(packages: Seq[PackageId], syncVetting: Boolean)(implicit
+  def vetPackages(
+      packages: Seq[PackageId],
+      synchronizeVetting: PackageVettingSynchronization,
+  )(implicit
       traceContext: TraceContext
   ): EitherT[FutureUnlessShutdown, DamlError, Unit] =
     packageOps
-      .vetPackages(packages, syncVetting)
+      .vetPackages(packages, synchronizeVetting)
       .leftMap[DamlError] { err =>
         implicit val code = err.code
         CantonPackageServiceError.IdentityManagerParentError(err)

sdk/canton/community/participant/src/main/scala/com/digitalasset/canton/participant/admin/PackageVettingSynchronization.scala

@@ -0,0 +1,26 @@
+// Copyright (c) 2024 Digital Asset (Switzerland) GmbH and/or its affiliates. All rights reserved.
+// SPDX-License-Identifier: Apache-2.0
+
+package com.digitalasset.canton.participant.admin
+
+import cats.data.EitherT
+import com.digitalasset.canton.lifecycle.FutureUnlessShutdown
+import com.digitalasset.canton.participant.topology.ParticipantTopologyManagerError
+import com.digitalasset.canton.tracing.TraceContext
+import com.digitalasset.canton.util.EitherTUtil
+import com.digitalasset.daml.lf.data.Ref.PackageId
+
+// TODO(#15087) remove this synchronization logic once topology events are published on the ledger api
+trait PackageVettingSynchronization {
+  def sync(packages: Set[PackageId])(implicit
+      traceContext: TraceContext
+  ): EitherT[FutureUnlessShutdown, ParticipantTopologyManagerError, Unit]
+}
+
+object PackageVettingSynchronization {
+  object NoSync extends PackageVettingSynchronization {
+    override def sync(packages: Set[PackageId])(implicit
+        traceContext: TraceContext
+    ): EitherT[FutureUnlessShutdown, ParticipantTopologyManagerError, Unit] = EitherTUtil.unitUS
+  }
+}

sdk/canton/community/participant/src/main/scala/com/digitalasset/canton/participant/admin/grpc/GrpcPackageService.scala

@@ -11,8 +11,8 @@ import com.digitalasset.canton.admin.participant.v30.{DarDescription as ProtoDar
 import com.digitalasset.canton.crypto.Hash
 import com.digitalasset.canton.logging.{NamedLoggerFactory, NamedLogging}
 import com.digitalasset.canton.networking.grpc.CantonGrpcUtil.GrpcErrors
-import com.digitalasset.canton.participant.admin.PackageService
 import com.digitalasset.canton.participant.admin.PackageService.DarDescriptor
+import com.digitalasset.canton.participant.admin.{PackageService, PackageVettingSynchronization}
 import com.digitalasset.canton.tracing.{TraceContext, TraceContextGrpc}
 import com.digitalasset.canton.util.{EitherTUtil, OptionUtil}
 import com.digitalasset.canton.{LfPackageId, protocol}
@@ -24,6 +24,7 @@ import scala.concurrent.{ExecutionContext, Future}
 
 class GrpcPackageService(
     service: PackageService,
+    synchronizeVetting: PackageVettingSynchronization,
     protected val loggerFactory: NamedLoggerFactory,
 )(implicit ec: ExecutionContext)
     extends PackageServiceGrpc.PackageService
@@ -62,7 +63,9 @@ class GrpcPackageService(
           fileNameO = Some(request.filename),
           submissionIdO = None,
           vetAllPackages = request.vetAllPackages,
-          synchronizeVetting = request.synchronizeVetting,
+          synchronizeVetting =
+            if (request.synchronizeVetting) synchronizeVetting
+            else PackageVettingSynchronization.NoSync,
         )
       } yield UploadDarResponse(
         UploadDarResponse.Value.Success(UploadDarResponse.Success(hash.toHexString))
@@ -109,7 +112,10 @@ class GrpcPackageService(
     val ret = for {
       hash <- EitherT.fromEither[Future](extractHash(request.darHash))
       _unit <- service
-        .vetDar(hash, request.synchronize)
+        .vetDar(
+          hash,
+          if (request.synchronize) synchronizeVetting else PackageVettingSynchronization.NoSync,
+        )
         .leftMap(_.asGrpcError)
         .onShutdown(Left(GrpcErrors.AbortedDueToShutdown.Error().asGrpcError))
     } yield VetDarResponse()

sdk/canton/community/participant/src/main/scala/com/digitalasset/canton/participant/ledger/api/StartableStoppableLedgerApiDependentServices.scala

@@ -97,6 +97,7 @@ class StartableStoppableLedgerApiDependentServices(
                 .bindService(
                   new GrpcPackageService(
                     packageService,
+                    syncService.synchronizeVettingOnConnectedDomains,
                     loggerFactory,
                   ),
                   ec,

sdk/canton/community/participant/src/main/scala/com/digitalasset/canton/participant/protocol/TransactionProcessingSteps.scala

@@ -10,7 +10,6 @@ import cats.syntax.functor.*
 import cats.syntax.option.*
 import cats.syntax.parallel.*
 import cats.syntax.traverse.*
-import com.daml.error.utils.DecodedCantonError
 import com.daml.metrics.api.MetricsContext
 import com.daml.nonempty.NonEmpty
 import com.daml.nonempty.catsinstances.*
@@ -1089,15 +1088,7 @@ class TransactionProcessingSteps(
       submitterMetaO.flatMap(completionInfoFromSubmitterMetadataO(_, freshOwnTimelyTx))
 
     rejectionReason.logWithContext(Map("requestId" -> pendingTransaction.requestId.toString))
-    val rejectionReasonStatus = rejectionReason.reason()
-    val mappedRejectionReason =
-      DecodedCantonError.fromGrpcStatus(rejectionReasonStatus) match {
-        case Right(error) => rejectionReasonStatus
-        case Left(err) =>
-          logger.warn(s"Failed to parse the rejection reason: $err")
-          rejectionReasonStatus
-      }
-    val rejection = LedgerSyncEvent.CommandRejected.FinalReason(mappedRejectionReason)
+    val rejection = LedgerSyncEvent.CommandRejected.FinalReason(rejectionReason.reason())
 
     val tseO = completionInfoO.map(info =>
       TimestampedEvent(

sdk/canton/community/participant/src/main/scala/com/digitalasset/canton/participant/protocol/validation/TransactionConfirmationResponseFactory.scala

@@ -67,11 +67,11 @@ class TransactionConfirmationResponseFactory(
         viewValidationResult.activenessResult
 
       if (inactive.nonEmpty)
-        logger.debug(
+        logger.info(
           show"View $viewHash of request $requestId rejected due to inactive contract(s) $inactive"
         )
       if (alreadyLocked.nonEmpty)
-        logger.debug(
+        logger.info(
           show"View $viewHash of request $requestId rejected due to contention on contract(s) $alreadyLocked"
         )
 

sdk/canton/community/participant/src/main/scala/com/digitalasset/canton/participant/sync/CantonSyncService.scala

@@ -222,6 +222,44 @@ class CantonSyncService(
     loggerFactory,
   )
 
+  /** Validates that the provided packages are vetted on the currently connected domains. */
+  // TODO(#15087) remove this waiting logic once topology events are published on the ledger api
+  val synchronizeVettingOnConnectedDomains: PackageVettingSynchronization =
+    new PackageVettingSynchronization {
+      override def sync(packages: Set[PackageId])(implicit
+          traceContext: TraceContext
+      ): EitherT[FutureUnlessShutdown, ParticipantTopologyManagerError, Unit] = {
+        // wait for packages to be vetted on the currently connected domains
+        EitherT
+          .right[ParticipantTopologyManagerError](
+            connectedDomainsLookup.snapshot.toSeq.parTraverse { case (domainId, syncDomain) =>
+              syncDomain.topologyClient
+                .await(
+                  _.findUnvettedPackagesOrDependencies(participantId, packages)
+                    .bimap(
+                      _missingPackage => false,
+                      unvettedPackages => unvettedPackages.nonEmpty,
+                    )
+                    .merge
+                    .onShutdown(false),
+                  timeouts.network.duration,
+                )
+                .map(domainId -> _)
+            }
+          )
+          .map { result =>
+            result.foreach { case (domainId, successful) =>
+              if (!successful)
+                logger.warn(
+                  s"Waiting for vetting of packages $packages on domain $domainId timed out."
+                )
+            }
+            result
+          }
+          .void
+      }
+    }
+
   private case class AttemptReconnect(
       alias: DomainAlias,
       last: CantonTimestamp,
@@ -661,7 +699,7 @@ class CantonSyncService(
             fileNameO = None,
             submissionIdO = Some(submissionId),
             vetAllPackages = true,
-            synchronizeVetting = false,
+            synchronizeVetting = synchronizeVettingOnConnectedDomains,
           )
           .map(_ => SubmissionResult.Acknowledged)
           .onShutdown(Left(CommonErrors.ServerIsShuttingDown.Reject()))

sdk/canton/community/participant/src/test/scala/com/digitalasset/canton/participant/admin/PackageOpsForTesting.scala

@@ -40,7 +40,10 @@ class PackageOpsForTesting(
   )(implicit tc: TraceContext): EitherT[FutureUnlessShutdown, CantonError, Unit] =
     EitherT.rightT(())
 
-  override def vetPackages(packages: Seq[PackageId], synchronize: Boolean)(implicit
+  override def vetPackages(
+      packages: Seq[PackageId],
+      synchronizeVetting: PackageVettingSynchronization,
+  )(implicit
       traceContext: TraceContext
   ): EitherT[FutureUnlessShutdown, ParticipantTopologyManagerError, Unit] =
     EitherT.rightT(())

sdk/canton/community/participant/src/test/scala/com/digitalasset/canton/participant/admin/PackageOpsTest.scala

@@ -208,7 +208,7 @@ class PackageOpsTest extends PackageOpsTestBase {
         arrangeCurrentlyVetted(List(pkgId1))
         expectNewVettingState(List(pkgId1, pkgId2))
         packageOps
-          .vetPackages(Seq(pkgId1, pkgId2), synchronize = false)
+          .vetPackages(Seq(pkgId1, pkgId2), PackageVettingSynchronization.NoSync)
           .value
           .unwrap
           .map(inside(_) { case UnlessShutdown.Outcome(Right(_)) => succeed })
@@ -222,7 +222,7 @@ class PackageOpsTest extends PackageOpsTestBase {
         // Not ordered to prove that we check set-equality not ordered
         arrangeCurrentlyVetted(List(pkgId2, pkgId1))
         packageOps
-          .vetPackages(Seq(pkgId1, pkgId2), synchronize = false)
+          .vetPackages(Seq(pkgId1, pkgId2), PackageVettingSynchronization.NoSync)
           .value
           .unwrap
           .map(inside(_) { case UnlessShutdown.Outcome(Right(_)) =>

sdk/canton/community/participant/src/test/scala/com/digitalasset/canton/participant/admin/PackageServiceTest.scala

@@ -131,7 +131,7 @@ class PackageServiceTest
             fileNameO = Some("CantonExamples"),
             submissionIdO = None,
             vetAllPackages = false,
-            synchronizeVetting = false,
+            synchronizeVetting = PackageVettingSynchronization.NoSync,
           )
           .value
           .map(_.valueOrFail("append dar"))
@@ -154,7 +154,7 @@ class PackageServiceTest
             fileNameO = Some("some/path/CantonExamples.dar"),
             submissionIdO = None,
             vetAllPackages = false,
-            synchronizeVetting = false,
+            synchronizeVetting = PackageVettingSynchronization.NoSync,
           )
           .value
           .map(_.valueOrFail("should be right"))
@@ -201,7 +201,7 @@ class PackageServiceTest
             fileNameO = Some("some/path/CantonExamples.dar"),
             submissionIdO = None,
             vetAllPackages = false,
-            synchronizeVetting = false,
+            synchronizeVetting = PackageVettingSynchronization.NoSync,
           )
           .valueOrFail("appending dar")
         deps <- packageDependencyResolver.packageDependencies(mainPackageId).value
@@ -253,7 +253,7 @@ class PackageServiceTest
             Some(badDarPath),
             None,
             vetAllPackages = false,
-            synchronizeVetting = false,
+            synchronizeVetting = PackageVettingSynchronization.NoSync,
           )
         )("append illformed.dar").failOnShutdown
       } yield {
@@ -299,7 +299,7 @@ class PackageServiceTest
     "requested by PackageService.vetDar" should {
       "reject the request with an error" in withEnv(
         rejectOnMissingDar(
-          _.vetDar(unknownDarHash, synchronize = true),
+          _.vetDar(unknownDarHash, PackageVettingSynchronization.NoSync),
           unknownDarHash,
           "DAR archive vetting",
         )
@@ -326,9 +326,9 @@ class PackageServiceTest
               sut.upload(
                 darBytes = payload,
                 fileNameO = Some(darName),
-                None,
+                submissionIdO = None,
                 vetAllPackages = false,
-                synchronizeVetting = false,
+                synchronizeVetting = PackageVettingSynchronization.NoSync,
               )
             )
         }

sdk/canton/ref

@@ -1 +1 @@
-20240702.13586.v19985bc9
+20240703.13595.v030861a1