Fix conversion from contract to node ids in the scenario service (#5577)

* Fix conversion from contract to node ids in the scenario service

Previously we only included the mapping from the ledger. However, this
does not include any contracts which might have been created in a
partial transaction that failed. This caused a
`NoSuchElementException` when converting the error which is obviously
not what we want.

This PR extends the mapping to include any contracts created in the
current partial transaction.

changelog_begin

- [DAML Studio] Fix a bug where a failed transaction that included
  references to a transient contract returned a gRPC error instead of
  the expected error message.

changelog_end

* Update compiler/scenario-service/server/src/main/scala/com/digitalasset/daml/lf/scenario/Conversions.scala

Co-Authored-By: Remy <remy.haemmerle@daml.com>

* Update compiler/scenario-service/server/src/main/scala/com/digitalasset/daml/lf/scenario/Conversions.scala

Co-Authored-By: Remy <remy.haemmerle@daml.com>

* Update compiler/scenario-service/server/src/main/scala/com/digitalasset/daml/lf/scenario/Conversions.scala

Co-Authored-By: Remy <remy.haemmerle@daml.com>

* Update compiler/scenario-service/server/src/main/scala/com/digitalasset/daml/lf/scenario/Conversions.scala

Co-Authored-By: Remy <remy.haemmerle@daml.com>

* Update compiler/scenario-service/server/src/main/scala/com/digitalasset/daml/lf/scenario/Conversions.scala

Co-Authored-By: Remy <remy.haemmerle@daml.com>

Co-authored-by: Remy <remy.haemmerle@daml.com>

compiler/damlc/tests/daml-test-files/TransientFailure.daml

@@ -0,0 +1,35 @@
+-- Copyright (c) 2020, Digital Asset (Switzerland) GmbH and/or its affiliates.
+-- All rights reserved.
+
+-- @ERROR exercise C on #1:1
+module TransientFailure where
+
+template T'
+  with
+    p: Party
+  where
+    signatory p
+    choice C : ()
+      controller p
+      do assert False
+
+template T
+  with
+    p: Party
+  where
+    signatory p
+    nonconsuming choice FailingTransient : ()
+      controller p
+      do cid <- create T' with p
+         exercise cid C
+
+testBio : Scenario ()
+testBio  = do
+  p <- getParty "p"
+  latestCid <- submit p do create T with p
+  -- This produces a failing transaction with a contract created
+  -- in the same transaction. In the past this resulted
+  -- in an exception in the scenario service when converting
+  -- between contract ids and node ids.
+  submit p do exercise latestCid FailingTransient
+  return ()

compiler/scenario-service/server/src/main/scala/com/digitalasset/daml/lf/scenario/Conversions.scala

@@ -24,7 +24,20 @@ final class Conversions(
   private val packageIdSelf: PackageIdentifier =
     PackageIdentifier.newBuilder.setSelf(empty).build
 
-  private val coidToNodeId = ledger.ledgerData.coidToNodeId
+  // The ledger data will not contain information from the partial transaction at this point.
+  // We need the mapping for converting error message so we manually add it here.
+  private val ptxCoidToNodeId = machine.ptx.nodes
+    .collect {
+      case (nodeId, node: N.NodeCreate.WithTxValue[V.ContractId]) =>
+        node.coid match {
+          case acoid: V.AbsoluteContractId =>
+            acoid -> ledger.ptxNodeId(nodeId)
+          case V.RelativeContractId(_) =>
+            throw new IllegalArgumentException("unexpected relative contract id")
+        }
+    }
+
+  private val coidToNodeId = ledger.ledgerData.coidToNodeId ++ ptxCoidToNodeId
 
   private val nodes =
     ledger.ledgerData.nodeInfos.map(Function.tupled(convertNode))
@@ -308,7 +321,7 @@ final class Conversions(
       case acoid: V.AbsoluteContractId =>
         coidToNodeId(acoid)
       case V.RelativeContractId(_) =>
-        throw new IllegalArgumentException("unexpected relative cotnract id")
+        throw new IllegalArgumentException("unexpected relative contract id")
     }
 
   def convertScenarioStep(

daml-lf/interpreter/src/main/scala/com/digitalasset/daml/lf/types/Ledger.scala

@@ -389,6 +389,11 @@ object Ledger {
           }
       }
     }
+
+    // Given a ledger and the node index of a node in a partial transaction
+    // turn it into a node it that can be used in scenario error messages.
+    def ptxNodeId(nodeIdx: NodeId): ScenarioNodeId =
+      ScenarioNodeId(scenarioStepId.makeCommitPrefix, nodeIdx)
   }
 
   sealed trait CommitError