digital-asset/daml
1
1
Fork 0
mirror of https://github.com/digital-asset/daml.git synced 2024-09-20 09:17:43 +03:00
Code Issues Projects Releases Wiki Activity

Remove blog post notifications (#3794)

Browse Source 
* Disable IDE notifications about new blog posts

* Remove notification setting
This commit is contained in:
Rohan Jacob-Rao 2019-12-09 15:41:56 -05:00 committed by GitHub
parent 6e17cdba90
commit 37fa12c943
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 42 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
compiler/daml-extension/package.json
View File

@ -107,11 +107,6 @@
"default": "From consent popup",
"description": "Controls whether you send DAML usage data to Digital Asset"
},
"daml.showNewBlogPosts": {
"type": "boolean",
"default": true,
"description": "Notify when new DAML Driven blog posts are available"
},
"daml.extraArguments": {
"type": "string",
"default": "",

38
compiler/daml-extension/src/extension.ts
View File

@ -14,15 +14,13 @@ import { LanguageClient, LanguageClientOptions, RequestType, NotificationType, T
import { Uri, Event, TextDocumentContentProvider, ViewColumn, EventEmitter, window, QuickPickOptions, ExtensionContext, env, WorkspaceConfiguration } from 'vscode';
import * as which from 'which';
import * as util from 'util';
import fetch, { Response } from 'node-fetch';
import fetch from 'node-fetch';
import { getOrd } from 'fp-ts/lib/Array';
import { ordNumber } from 'fp-ts/lib/Ord';
import { parseStringPromise } from 'xml2js';
let damlRoot: string = path.join(os.homedir(), '.daml');
const versionContextKey = 'version'
const recentBlogContextKey = 'lastSeenBlog'
type WebviewFiles = {
src: Uri; // The JavaScript file.
@ -42,8 +40,6 @@ export async function activate(context: vscode.ExtensionContext) {
// Display release notes on updates
showReleaseNotesIfNewVersion(context);
// Notify about new blog posts
showBlogIfNotSeen(config, context);
damlLanguageClient = createLanguageClient(config, await consent);
damlLanguageClient.registerProposedFeatures();
@ -161,38 +157,6 @@ async function showReleaseNotes(version: string) {
} catch (_error) {}
}
// Check if there is a new blog post which the user has not yet seen.
// If so, display a notification with the link to the new post.
// Update the user state so we don't notify about the same blog post again.
// The user can opt out of these notifications entirely by changing the
// 'daml.showNewBlogPosts' setting.
async function showBlogIfNotSeen(config: WorkspaceConfiguration, context: ExtensionContext) {
if (!config.get('showNewBlogPosts')) { return; }
try {
const feedUrl = 'https://blog.daml.com/daml-driven/rss.xml';
const res = await fetch(feedUrl);
if (res.ok) {
const rssXml = await res.text();
const rss = await parseStringPromise(rssXml);
const latestBlog = rss.rss.channel[0].item[0];
const latestTitle = latestBlog.title[0];
const lastSeenBlog = context.globalState.get(recentBlogContextKey);
if (latestBlog && (!lastSeenBlog || lastSeenBlog !== latestTitle)) {
// Update last seen blog to avoid showing the same notification again.
await context.globalState.update(recentBlogContextKey, latestTitle);
const clicked = await window.showInformationMessage(
`New blog post: ${latestTitle}`,
'Go to blog'
);
if (clicked === 'Go to blog') {
const link = latestBlog.link[0];
env.openExternal(Uri.parse(link));
}
}
}
} catch (_error) {}
}
function getViewColumnForShowResource(): ViewColumn {
const active = vscode.window.activeTextEditor;
if (!active || !active.viewColumn) { return ViewColumn.One; }