From 45f19f4255830c22d69df249b1a14fe99e854723 Mon Sep 17 00:00:00 2001 From: Moritz Kiefer Date: Thu, 6 Feb 2020 15:59:54 +0100 Subject: [PATCH] Mark packaging tests as non-flaky (#4429) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit I’ve spend several hours trying to get them to fail on Linux and Windows and have failed completely (apart from making my machine roun out of memory, thanks crashplan). I also inserted explicit delays to make the failure more often frequent without any sucess (at making it fail). I don’t really have a satisfying explanation of why this is gone now. My best guess is that the `ghcide` upgrade fixed this since it included some fixes and changes around how we kill and start the shake process. fixes #4328 changelog_begin changelog_end --- compiler/damlc/tests/BUILD.bazel | 2 -- 1 file changed, 2 deletions(-) diff --git a/compiler/damlc/tests/BUILD.bazel b/compiler/damlc/tests/BUILD.bazel index f9c69b5eb3e..ba6c2ae1a74 100644 --- a/compiler/damlc/tests/BUILD.bazel +++ b/compiler/damlc/tests/BUILD.bazel @@ -213,8 +213,6 @@ da_haskell_test( "//daml-lf/repl", "@davl//:released/davl-v3.dar", ], - # See https://github.com/digital-asset/daml/issues/4328 - flaky = True, hackage_deps = [ "base", "bytestring",