digital-asset/daml
1
1
Fork 0
mirror of https://github.com/digital-asset/daml.git synced 2024-11-10 10:46:11 +03:00
Code Issues Projects Releases Wiki Activity

Bump timeout in CommandClientIT (#3879)

Browse Source 
This test suite was introduced in #3870 and seems to be extremely
flaky both locally (I get about 16/20 failures) and on CI.

The error is

  - should return completions of commands that are submitted after subscription *** FAILED *** (4 seconds, 945 milliseconds)
    Set() did not contain all elements of List("5104", "5100", "5105", "5109", "5103", "5106", "5107", "5102", "5108", "5101") (CommandClientIT.scala:330)

After bumping the timeout, I don’t get any failures locally.

Happy to choose another timeout, I have no clue what a sensible value
is here.
This commit is contained in:
Moritz Kiefer 2019-12-18 09:11:47 +01:00 committed by GitHub
parent f864ac955b
commit 4ad3a22c90
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ledger/ledger-api-client/src/it/scala/com/digitalasset/ledger/client/CommandClientIT.scala
View File

@ -164,7 +164,7 @@ final class CommandClientIT
client: CommandClient,
checkpoint: LedgerOffset,
expected: Set[String],
timeLimit: Span = 3.seconds): Future[(Set[String], Set[String])] =
timeLimit: Span = 6.seconds): Future[(Set[String], Set[String])] =
readExpectedElements(client.completionSource(submittingPartyList, checkpoint).collect {
case CompletionStreamElement.CompletionElement(c) => c.commandId
}, expected, timeLimit)