Mark Java Bot tests flaky (#10322)

See https://github.com/digital-asset/daml/issues/10273 for details on
the issue.

Summary is that the logic in the Java bots is fundamentally broken
since it modifies the pending set asynchronously so it can trigger for
the same contract multiple times.

While we can certainly fix that or hack around the bug in the tests,
given that the Java bots are deprecated, marking it flaky seems like a
better use of our time.

changelog_begin
changelog_end
This commit is contained in:
Moritz Kiefer 2021-07-20 10:50:12 +02:00 committed by GitHub
parent a6bf892f72
commit 8360e9f75a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -4,6 +4,7 @@
load(
"//bazel_tools:scala.bzl",
"da_scala_library",
"da_scala_test",
"da_scala_test_suite",
)
load("//bazel_tools:pom_file.bzl", "pom_file")
@ -85,12 +86,17 @@ da_scala_library(
],
)
bot_test = "src/test/scala/com/daml/ledger/rxjava/components/BotTest.scala"
da_scala_test_suite(
name = "bindings-java-tests",
srcs = glob([
"src/test/**/*Spec.scala",
"src/test/**/*Test.scala",
]),
srcs = glob(
[
"src/test/**/*Spec.scala",
"src/test/**/*Test.scala",
],
exclude = [bot_test],
),
data = [
":bindings-integration-tests-model-latest.dar",
],
@ -126,6 +132,43 @@ da_scala_test_suite(
],
)
da_scala_test(
name = "bindings-java-bot-tests",
srcs = [bot_test],
data = [
":bindings-integration-tests-model-latest.dar",
],
# See https://github.com/digital-asset/daml/issues/10273#issuecomment-882681521
flaky = True,
resources = [
":src/test/resources/logback-test.xml",
],
scala_deps = [
"@maven//:org_scalactic_scalactic",
"@maven//:org_scalatest_scalatest",
],
versioned_scala_deps = {
"2.12": ["@maven//:org_scala_lang_modules_scala_collection_compat"],
},
deps = [
":bindings-java-tests-lib",
":bindings-rxjava",
"//language-support/java/bindings:bindings-java",
"//ledger-api/grpc-definitions:ledger_api_proto_scala",
"//ledger/ledger-api-auth",
"//ledger/ledger-api-common",
"//libs-scala/grpc-utils",
"@maven//:com_google_api_grpc_proto_google_common_protos",
"@maven//:com_google_protobuf_protobuf_java",
"@maven//:io_grpc_grpc_core",
"@maven//:io_grpc_grpc_netty",
"@maven//:io_reactivex_rxjava2_rxjava",
"@maven//:org_pcollections_pcollections",
"@maven//:org_reactivestreams_reactive_streams",
"@maven//:org_slf4j_slf4j_api",
],
)
daml_compile(
name = "bindings-integration-tests-model-latest",
srcs = ["src/main/daml/TemplateUtils.daml"],