digital-asset/daml
1
1
Fork 0
mirror of https://github.com/digital-asset/daml.git synced 2024-09-20 01:07:18 +03:00
Code Issues Projects Releases Wiki Activity

Remove dependency and data-dependency arguments from daml-helper (#5262)

Browse Source 
Those were originally used for `damlc migrate`. However, that command
no longer exists and the only call site of `runNew` sets those
arguments to an empty list.

changelog_begin
changelog_end
This commit is contained in:
Moritz Kiefer 2020-03-30 10:40:34 +02:00 committed by GitHub
parent 1e296aa91f
commit a37d898e77
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
daml-assistant/daml-helper/src/DA/Daml/Helper/Main.hs
View File

@ -319,7 +319,7 @@ runCommand = \case
runJar jarPath mbLogbackConfig remainingArguments
New {..}
| templateNameM == Just "create-daml-app" -> runCreateDamlApp targetFolder
| otherwise -> runNew targetFolder templateNameM [] []
| otherwise -> runNew targetFolder templateNameM
CreateDamlApp{..} -> runCreateDamlApp targetFolder
Init {..} -> runInit targetFolderM
ListTemplates -> runListTemplates

6
daml-assistant/daml-helper/src/DA/Daml/Helper/Run.hs
View File

@ -566,8 +566,8 @@ runInit targetFolderM = do
-- * Creation of a project in existing folder (suggest daml init instead).
-- * Creation of a project inside another project.
--
runNew :: FilePath -> Maybe String -> [String] -> [String] -> IO ()
runNew targetFolder templateNameM pkgDeps dataDeps = do
runNew :: FilePath -> Maybe String -> IO ()
runNew targetFolder templateNameM = do
templatesFolder <- getTemplatesFolder
let templateName = fromMaybe defaultProjectTemplate templateNameM
templateFolder = templatesFolder </> templateName
@ -646,8 +646,6 @@ runNew targetFolder templateNameM pkgDeps dataDeps = do
sdkVersion <- getSdkVersion
let config = replace "__VERSION__" sdkVersion
. replace "__PROJECT_NAME__" projectName
. replace "__DEPENDENCIES__" (unlines [" - " <> dep | dep <- pkgDeps])
. replace "__DATA_DEPENDENCIES__" (unlines [" - " <> dep | dep <- dataDeps])
$ configTemplate
writeFileUTF8 configPath config
removeFile configTemplatePath