mirror of
https://github.com/digital-asset/daml.git
synced 2024-09-20 09:17:43 +03:00
Disable the checkTtl validation in kvutils (#2714)
The time model is being reworked and the current stack is not prepared to handle this additional check well. We will reimplement time model related checks once the redesign has been completed.
This commit is contained in:
parent
fca502ac9e
commit
a96f3fb736
@ -11,6 +11,9 @@ package com.daml.ledger.participant.state.kvutils
|
||||
* - Added 'Envelope' for compressing and versioning kvutils messages that are transmitted
|
||||
* or stored on disk. [[Envelope.enclose]] and [[Envelope.open]] should be now used for
|
||||
* submissions and for results from processing them.
|
||||
* - Disabled the time-to-live checks for ledger effective time and record time. The
|
||||
* time model is being redesigned and the checks will be reimplemented once we have
|
||||
* the new design.
|
||||
*
|
||||
* [since 100.13.16]: *BACKWARDS INCOMPATIBLE*
|
||||
* - Log entries are no longer used as inputs to submission processing. The
|
||||
|
@ -130,8 +130,12 @@ private[kvutils] case class ProcessTransactionSubmission(
|
||||
currentTime = recordTime.toInstant,
|
||||
givenLedgerEffectiveTime = givenLET,
|
||||
givenMaximumRecordTime = givenMRT)
|
||||
&&
|
||||
timeModelChecker.checkTtl(givenLET, givenMRT))
|
||||
/* NOTE(JM): This check has been disabled to be more lenient while
|
||||
* we're still in beta phase. Time model is being redesigned and
|
||||
* appropriate checks will be put back in place along with the new
|
||||
* implementation.
|
||||
*
|
||||
* && timeModelChecker.checkTtl(givenLET, givenMRT) */ )
|
||||
pass
|
||||
else
|
||||
reject(RejectionReason.MaximumRecordTimeExceeded)
|
||||
|
@ -3,8 +3,6 @@
|
||||
|
||||
package com.daml.ledger.participant.state.kvutils
|
||||
|
||||
import java.time.Duration
|
||||
|
||||
import com.daml.ledger.participant.state.kvutils.DamlKvutils.{
|
||||
DamlLogEntry,
|
||||
DamlTransactionRejectionEntry
|
||||
@ -45,6 +43,7 @@ class KVUtilsTransactionSpec extends WordSpec with Matchers {
|
||||
}
|
||||
)
|
||||
|
||||
/* Disabled while we rework the time model.
|
||||
"reject transaction with elapsed max record time" in KVTest.runTest(
|
||||
for {
|
||||
tx <- runCommand(alice, simpleCreateCmd)
|
||||
@ -55,6 +54,7 @@ class KVUtilsTransactionSpec extends WordSpec with Matchers {
|
||||
logEntry.getTransactionRejectionEntry.getReasonCase shouldEqual DamlTransactionRejectionEntry.ReasonCase.MAXIMUM_RECORD_TIME_EXCEEDED
|
||||
}
|
||||
)
|
||||
*/
|
||||
|
||||
"reject transaction with out of bounds LET" in KVTest.runTest(
|
||||
for {
|
||||
|
Loading…
Reference in New Issue
Block a user