Fix badly versioned empty tx (#10596)

* build correctly versioned empty tx

* dont call normalizeTx from Engine.validate

* dont recalc the tx-version in normalizeTx; just assume it is correct

CHANGELOG_BEGIN
CHANGELOG_END

daml-lf/engine/src/main/scala/com/digitalasset/daml/lf/engine/Engine.scala

@@ -222,7 +222,7 @@ class Engine(val config: EngineConfig = new EngineConfig(LanguageVersion.StableV
       (rtx, _) = result
       validationResult <-
         transaction.Validation
-          .isReplayedBy(transaction.Normalization.normalizeTx(tx), rtx)
+          .isReplayedBy(tx, rtx)
           .fold(
             e => ResultError(Error.Validation.ReplayMismatch(e)),
             _ => ResultDone.Unit,

daml-lf/transaction-test-lib/src/main/scala/lf/transaction/test/TransactionBuilder.scala

@@ -274,7 +274,7 @@ object TransactionBuilder {
   // not valid transactions.
   val Empty: Tx.Transaction =
     VersionedTransaction(
-      TransactionVersion.minNodeVersion,
+      TransactionVersion.minVersion, // A normalized empty tx is V10
       HashMap.empty,
       ImmArray.empty,
     )

daml-lf/transaction/src/main/scala/com/digitalasset/daml/lf/transaction/Normalization.scala

@@ -45,17 +45,9 @@ class Normalization[Nid, Cid] {
 
   def normalizeTx(vtx: VTX): VTX = {
     vtx match {
-      case VersionedTransaction(_, nodes, roots) =>
-        // TODO: Normalized version calc should be shared with code in asVersionedTransaction
-        val version = roots.iterator.foldLeft(TransactionVersion.minVersion) { (acc, nodeId) =>
-          import scala.Ordering.Implicits.infixOrderingOps
-          nodes(nodeId).optVersion match {
-            case Some(version) => acc max version
-            case None => acc max TransactionVersion.minExceptions
-          }
-        }
+      case VersionedTransaction(_, nodes, _) =>
         VersionedTransaction(
-          version,
+          vtx.version,
           nodes.map { case (k, v) =>
             (k, normNode(v))
           },