Stop pretending strings are booleans (#8885)

* Stop pretending strings are booleans

Sorry for all the mess here. I’m not capable of programming in yaml.

It turns out is_release is a string not a boolean and

```
and('false', eq('true', 'true'))
```

is true.

I hate everything about this.

changelog_begin
changelog_end

* Name bash step to reduce confusion

changelog_begin
changelog_end

* fix version in test

changelog_begin
changelog_end

* names can’t have spaces apparently

changelog_begin
changelog_end
This commit is contained in:
Moritz Kiefer 2021-02-17 17:13:54 +01:00 committed by GitHub
parent 2717e6a164
commit b47c1a974c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -82,7 +82,7 @@ jobs:
# The easiest option seems to be to still run the Scala 2.13 job but
# pretend its not a release build and thereby just run it against main
# so thats what we do here.
is_release: $[ and(dependencies.check_for_release.outputs['out.is_release'], eq(dependencies.check_for_release.outputs['out.scala_2_13'], 'true')) ]
is_release: $[ and(eq(dependencies.check_for_release.outputs['out.is_release'], 'true'), eq(dependencies.check_for_release.outputs['out.scala_2_13'], 'true')) ]
scala_2_13: $[ dependencies.check_for_release.outputs['out.scala_2_13'] ]
timeoutInMinutes: 360
pool:
@ -109,7 +109,8 @@ jobs:
bazel build //release:release
./bazel-bin/release/release --release-dir "$(mktemp -d)"
env:
DAML_SCALA_VERSION: ${{parameters.scala_version}}
DAML_SCALA_VERSION: "2.13.3"
name: maven_check
condition: and(succeeded(), ne(variables['is_release'], 'true'))
- template: tell-slack-failed.yml
parameters: