From dcb8588a65f6bdab55c69ba002ae81ae738fabd2 Mon Sep 17 00:00:00 2001 From: Carl Pulley <106966370+carlpulley-da@users.noreply.github.com> Date: Tue, 18 Jun 2024 16:51:14 +0100 Subject: [PATCH] Script should rely on the ledger to manager max message size (#19402) --- .../main/scala/com/daml/lf/scenario/ScenarioServiceMain.scala | 4 ++-- .../scala/com/daml/lf/engine/script/RunnerMainConfig.scala | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/sdk/compiler/scenario-service/server/src/main/scala/com/daml/lf/scenario/ScenarioServiceMain.scala b/sdk/compiler/scenario-service/server/src/main/scala/com/daml/lf/scenario/ScenarioServiceMain.scala index eff6266011..2dc7726d8c 100644 --- a/sdk/compiler/scenario-service/server/src/main/scala/com/daml/lf/scenario/ScenarioServiceMain.scala +++ b/sdk/compiler/scenario-service/server/src/main/scala/com/daml/lf/scenario/ScenarioServiceMain.scala @@ -38,8 +38,8 @@ private final case class ScenarioServiceConfig( @SuppressWarnings(Array("org.wartremover.warts.NonUnitStatements")) private object ScenarioServiceConfig { - // default to 128MB - val DefaultMaxInboundMessageSize: Int = 128 * 1024 * 1024 + // We default to MAXINT as we rely on the ledger to manage the message size + val DefaultMaxInboundMessageSize: Int = Int.MaxValue val parser = new scopt.OptionParser[ScenarioServiceConfig]("scenario-service") { head("scenario-service") diff --git a/sdk/daml-script/runner/src/main/scala/com/daml/lf/engine/script/RunnerMainConfig.scala b/sdk/daml-script/runner/src/main/scala/com/daml/lf/engine/script/RunnerMainConfig.scala index 4cf59103a8..5e8fe18bba 100644 --- a/sdk/daml-script/runner/src/main/scala/com/daml/lf/engine/script/RunnerMainConfig.scala +++ b/sdk/daml-script/runner/src/main/scala/com/daml/lf/engine/script/RunnerMainConfig.scala @@ -28,7 +28,8 @@ case class RunnerMainConfig( object RunnerMainConfig { val DefaultTimeMode: ScriptTimeMode = ScriptTimeMode.WallClock - val DefaultMaxInboundMessageSize: Int = 4194304 + // We default to MAXINT as we rely on the ledger to manage the message size + val DefaultMaxInboundMessageSize: Int = Int.MaxValue sealed trait RunMode object RunMode {