digital-asset/daml
1
1
Fork 0
mirror of https://github.com/digital-asset/daml.git synced 2024-09-20 01:07:18 +03:00
Code Issues Projects Releases Wiki Activity

Augment completion.proto with deduplication-related info [KVL-1057] (#10619)

Browse Source 
* Augment completion.proto with deduplication-related info

CHANGELOG_BEGIN
CHANGELOG_END

* Explicitly specify fields not yet filled in when building Completion

* Time-based deduplication periods are measured in record time of completions

* Add deduplication_offset as a deduplication_period option

* Don't skip proto field numbers

* CompletionFromTransaction: use default Completion constructor

* submission_rank: reserve proto field for future use

* Add comment about reserved proto field
This commit is contained in:
fabiotudone-da 2021-08-24 12:55:03 +02:00 committed by GitHub
parent a00608c8b3
commit e99254fd3e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 62 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
ledger-api/grpc-definitions/com/daml/ledger/api/v1/completion.proto
View File

@ -5,6 +5,8 @@ syntax = "proto3";
package com.daml.ledger.api.v1;
import "google/protobuf/duration.proto";
import "google/protobuf/timestamp.proto";
import "google/rpc/status.proto";
option java_outer_classname = "CompletionOuterClass";
@ -29,4 +31,50 @@ message Completion {
// Must be a valid LedgerString (as described in ``value.proto``).
// Optional
string transaction_id = 3;
// The application ID that was used for the submission, as described in ``commands.proto``.
// Must be a valid LedgerString (as described in ``value.proto``).
// Optional for historic completions where this data is not available.
string application_id = 4;
// The set of parties on whose behalf the commands were executed.
// Contains the union of ``party`` and ``act_as`` from ``commands.proto``.
// The order of the parties need not be the same as in the submission.
// Each element must be a valid PartyIdString (as described in ``value.proto``).
// Optional for historic completions where this data is not available.
repeated string act_as = 5;
// The submission ID this completion refers to, as described in ``commands.proto``.
// Must be a valid LedgerString (as described in ``value.proto``).
// Optional for historic completions where this data is not available.
string submission_id = 6;
reserved "submission_rank"; // For future use.
reserved 7; // For future use.
// The actual deduplication window used for the submission, which is derived from
// ``Commands.deduplication_period``. The ledger may convert the deduplication period into other
// descriptions and extend the period in implementation-specified ways.
//
// Used to audit the deduplication guarantee described in ``commands.proto``.
//
// Optional; the deduplication guarantee applies even if the completion omits this field.
oneof deduplication_period {
// Specifies the start of the deduplication period by a completion stream offset.
//
// Must be a valid LedgerString (as described in ``value.proto``).
string deduplication_offset = 8;
// Specifies the length of the deduplication period.
// It is measured in record time of completions.
//
// Must be non-negative.
google.protobuf.Duration deduplication_time = 9;
// Specifies a point in time in the past after which this submission should be de-duplicated
// w.r.t. previous submissions of the same commands.
//
// It is measured in record time of completions.
google.protobuf.Timestamp deduplication_start = 10;
}
}

16
ledger/participant-integration-api/src/main/scala/platform/store/CompletionFromTransaction.scala
View File

@ -29,7 +29,13 @@ private[platform] object CompletionFromTransaction {
): CompletionStreamResponse =
CompletionStreamResponse.of(
checkpoint = Some(toApiCheckpoint(recordTime, offset)),
completions = Seq(Completion.of(commandId, Some(OkStatus), transactionId)),
completions = Seq(
Completion(
commandId = commandId,
status = Some(OkStatus),
transactionId = transactionId,
)
),
)
def rejectedCompletion(
@ -40,7 +46,13 @@ private[platform] object CompletionFromTransaction {
): CompletionStreamResponse =
CompletionStreamResponse.of(
checkpoint = Some(toApiCheckpoint(recordTime, offset)),
completions = Seq(Completion.of(commandId, Some(status), RejectionTransactionId)),
completions = Seq(
Completion(
commandId = commandId,
status = Some(status),
transactionId = RejectionTransactionId,
)
),
)
private def toApiCheckpoint(recordTime: Instant, offset: Offset): Checkpoint =